Details

    • Type: Task Task
    • Status: Closed Closed
    • Priority: Critical Critical
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.5.2
    • Component/s: Performance
    • Security Level: Public (Public: Anyone can view)
    • Labels:
      None
    • Similar issues:
      KULRICE-14084Improvements for Key Personnel Search Rendering
      KULRICE-14085Improvements for Key Personnel Search
      KULRICE-7005Implement server paging of collection results
      KULRICE-10112docs and smoke test for server paging of collection results
      KULRICE-5257Suggest Box - Improvements
      KULRICE-11146Improve visual treatment of dialogs
      KULRICE-10890Perform analysis & implementation on Key Personnel dialog
      KULRICE-7547Kitchen sink other fields page not rendering fully
      KULRICE-4733Improve key values finder support
      KULRICE-12151ConfigurationTestView: Lookup Widgets tab renders blank page
    • Epic Link:
    • Rice Module:
      KIM
    • Application Requirement:
      KC
    • Sprint:
      Middleware 2.5.2 Sprint 3, Middleware 2.5.2 Sprint 4
    • KAI Review Status:
      Not Required
    • KTI Review Status:
      Not Required
    • Code Review Status:
      Not Required
    • Include in Release Notes?:
      Yes
    • Story Points:
      8

      Description

      As the number of added Key Personnel increases the freemarker and lifecycle times get higher as well and start accounting for a larger percentage of the response time. Look into tuning the key personnel collection group (lines). For example, possibly using ajax retrieval for the tabs, defaulting some of the lines to closed (disclosure with ajax), turning off auto inquiry/quickfinder, making sure there are no unneeded components.

      As number of key personnel increased, this popped up as trouble spot:

      ViewLifecycle.java:356 org.kuali.rice.krad.uif.element.PageValidationMessages.processEvent(ViewLifecycle$LifecycleEvent, View, Object, LifecycleElement) 640 0

      calls:

      ViewLifecycleUtils.java:140 org.kuali.rice.krad.uif.lifecycle.ViewLifecycleUtils.getElementsForLifecycle(LifecycleElement, String) 578 0

        Issue Links

          Activity

          Hide
          Steve Edgar (Inactive) added a comment -

          Added Brian as a watcher.

          Show
          Steve Edgar (Inactive) added a comment - Added Brian as a watcher.
          Hide
          Steve Edgar (Inactive) added a comment -

          Pair with Brian to look into Ajax disclosure triangles not working. A work-around was put into KC allowing this feature to work. According to Brian, the actual fix will likely have to be put into Rice. This did not fix the Ajax tab problem for the Proposal Person Certification tab, and so 5 of the 7 tabs remain "Ajax'd".

          Some quick timings with Chrome ...

          With server side paging on, Ajax on 5 of the 7 tabs, and Ajax on the disclosure triangles, Key Personnel page load is about 2 seconds. Opening a disclosure triangle is about 0.5 seconds. Loading data in an Ajax tab is about 0.5 seconds.

          With server side paging off, Ajax on 5 of the 7 tabs, and Ajax on the disclosure triangles, Key Personnel page load is about 3 seconds. Opening a disclosure triangle is about 0.5 seconds. Loading data in an Ajax tab is about 0.5 seconds.

          With server side paging off, no Ajax on tabs, and Ajax on the disclosure triangles, Key Personnel page load is about 6.5 seconds. Opening a disclosure triangle is 1.2 - 1.9 seconds. Tabs render fast, as they are already loaded.

          Show
          Steve Edgar (Inactive) added a comment - Pair with Brian to look into Ajax disclosure triangles not working. A work-around was put into KC allowing this feature to work. According to Brian, the actual fix will likely have to be put into Rice. This did not fix the Ajax tab problem for the Proposal Person Certification tab, and so 5 of the 7 tabs remain "Ajax'd". Some quick timings with Chrome ... With server side paging on, Ajax on 5 of the 7 tabs, and Ajax on the disclosure triangles, Key Personnel page load is about 2 seconds. Opening a disclosure triangle is about 0.5 seconds. Loading data in an Ajax tab is about 0.5 seconds. With server side paging off, Ajax on 5 of the 7 tabs, and Ajax on the disclosure triangles, Key Personnel page load is about 3 seconds. Opening a disclosure triangle is about 0.5 seconds. Loading data in an Ajax tab is about 0.5 seconds. With server side paging off, no Ajax on tabs, and Ajax on the disclosure triangles, Key Personnel page load is about 6.5 seconds. Opening a disclosure triangle is 1.2 - 1.9 seconds. Tabs render fast, as they are already loaded.
          Hide
          Brian Smith (Inactive) added a comment - - edited

          that last result is a bit shocking to me since it should be equivalent to the other 2 about (2-3 seconds) because the tabs do not need to be processed in an ajax disclosure situation. On a table base collection this is the case when using ajax details, I am not sure what is wrong here.

          Show
          Brian Smith (Inactive) added a comment - - edited that last result is a bit shocking to me since it should be equivalent to the other 2 about (2-3 seconds) because the tabs do not need to be processed in an ajax disclosure situation. On a table base collection this is the case when using ajax details, I am not sure what is wrong here.
          Hide
          Steve Edgar (Inactive) added a comment -

          As requested by Doug and Jerry at the 1:30 (EDT) meeting yesterday, commit and do a pull request for the current work-around, so folks can try it out. If it is decided to use Ajax disclosure triangles, the work-around would need to be replaced with a solution which better fits KRAD/Rice and KC.

          Show
          Steve Edgar (Inactive) added a comment - As requested by Doug and Jerry at the 1:30 (EDT) meeting yesterday, commit and do a pull request for the current work-around, so folks can try it out. If it is decided to use Ajax disclosure triangles, the work-around would need to be replaced with a solution which better fits KRAD/Rice and KC.
          Hide
          Joe Williams added a comment - - edited

          I am seeing some issues from the work done on https://github.com/kuali/kc/pull/1425. please see https://jira.kuali.org/browse/KRACOEUS-8699, if you add an item to either the degree or unit collection, the collection doesn't display automatically and requires you to switch to a different tab and move back. I worked out a solution for the degree collection by calling the tab navigate js on the successcall back of the add button, however, this issue seems more wide spread, as i also see this issue if i am on the degree tab for a person then add another person, then the degree collection will disappear.

          Since Brian Smith and Steve Edgar both know more about this issue, i was wondering what your input on fixing this would be.

          Show
          Joe Williams added a comment - - edited I am seeing some issues from the work done on https://github.com/kuali/kc/pull/1425 . please see https://jira.kuali.org/browse/KRACOEUS-8699 , if you add an item to either the degree or unit collection, the collection doesn't display automatically and requires you to switch to a different tab and move back. I worked out a solution for the degree collection by calling the tab navigate js on the successcall back of the add button, however, this issue seems more wide spread, as i also see this issue if i am on the degree tab for a person then add another person, then the degree collection will disappear. Since Brian Smith and Steve Edgar both know more about this issue, i was wondering what your input on fixing this would be.

            People

            • Assignee:
              Brian Smith (Inactive)
              Reporter:
              Jerry Neal (Inactive)
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Agile

                  Structure Helper Panel