Kuali Rice Development
  1. Kuali Rice Development
  2. KULRICE-14160

Document how we want to handle testing and verification of pull requests from external entities

    Details

    • Type: Task Task
    • Status: Closed Closed
    • Priority: Major Major
    • Resolution: Complete
    • Affects Version/s: None
    • Fix Version/s: 2.5.3
    • Component/s: Documentation
    • Security Level: Public (Public: Anyone can view)
    • Labels:
    • Similar issues:
      KULRICE-6258Document how to extract data from the database to create unit test data
      KULRICE-13298Principal deleted when person document routes if user cannot modify entities
      KULRICE-1983Entity Lookup Testing Scenario
      KULRICE-1984Entity Type Testing Scenario
      KULRICE-3890Determine how best to handle persistence, attached/detached, and lazy loading for the BusinessObjectService in the context of KNS
      KULRICE-3947Determine how to handle collections in JPA for existing applications
      KULRICE-8325Externalize text in script
      KULRICE-1799Figure out how to handle the potential conflict of having two different documents saving to the same join (i.e. group membership)
      KULRICE-4838Move integration tests into a separate module and improve the way we handle instantiation of test clients in the test harness, take advantage of maven integration-test lifecycle
      KULRICE-4923Implement database compatibility verification process
    • Sprint:
      Rice Sprint 2015-02-18, Rice Sprint 2015-03-04
    • KAI Review Status:
      Not Required
    • KTI Review Status:
      Not Required
    • Code Review Status:
      Not Required
    • Include in Release Notes?:
      Yes
    • Story Points:
      2

      Description

      For pull requests we get from universities (like some of the ones we have coming from IU). We need to decide how we will integrate this into the codebase and test them before doing so. We should document this and add it to our existing GitHub documentation:

      This documentation will probably end up around section 1.6 on this page.

      We also need to update the public documentation for the Rice Contribution Process:
      https://wiki.kuali.org/display/KULRICE/Rice+Contribution+Process

        Activity

        Hide
        Claus Niesen added a comment - - edited
        • Alert that security issues should go to security@kuali.org and no public pull request should be made until advised to do so.
        • Legal issues:
        • Rice contribution Queue (RICECNTRB)
          • Are we currently monitoring this queue actively? There are 25 issues, all are open. https://jira.kuali.org/issues/?jql=project%20%3D%20RICECNTRB
          • Do we require a RICECNTRB issue before looking at pull request or can pull requests be submitted and accepted without an RICEBNTRB issue?
          • How about KULRICE issues, do we need to create one for each pull request. Should be duplicate the RICECNTRB into a KULRICE issue?
        Show
        Claus Niesen added a comment - - edited Alert that security issues should go to security@kuali.org and no public pull request should be made until advised to do so. Legal issues: Do we need a signed CLA? The foundation wiki page says: Yes! Process to signing a CLA (see 1. Contributor License Agreement (CLA) ). In short: Contributor sends signed Contributor License Agreement to the Kuali Foundation (help@kuali.org) Foundation creates a KIS account. Before merger, rice team verifies that the contributor has the CLA indicator on KIS. Is there a simpler method for pull requests? Rice contribution Queue (RICECNTRB) Are we currently monitoring this queue actively? There are 25 issues, all are open. https://jira.kuali.org/issues/?jql=project%20%3D%20RICECNTRB Do we require a RICECNTRB issue before looking at pull request or can pull requests be submitted and accepted without an RICEBNTRB issue? How about KULRICE issues, do we need to create one for each pull request. Should be duplicate the RICECNTRB into a KULRICE issue?
        Hide
        Claus Niesen added a comment -

        Our before merger contribution checklist needs to include:

        • CLA signed
        • 3rd party licensed acceptable
        • Code style acceptable
        • Code review
        • Project builds
        • Unit tests passing

        Our after merger contribution checklist needs to include:

        • Integration test passing
        • Functional test passing
        Show
        Claus Niesen added a comment - Our before merger contribution checklist needs to include: CLA signed 3rd party licensed acceptable Code style acceptable Code review Project builds Unit tests passing Our after merger contribution checklist needs to include: Integration test passing Functional test passing
        Hide
        Claus Niesen added a comment -

        From Eric:

        yes we would still require a CLA for now I think, but I'm a little bit ambivalent about the ricecontrib jira, i kind of feel like a regular old rice jira is just fine, since we will have the pull request as documentation to know we have an outstanding contribute
        i think that was kind of the point of the RICECONTRIB jira originally was so that contributions didn't just get buried in our jira

        Show
        Claus Niesen added a comment - From Eric: yes we would still require a CLA for now I think, but I'm a little bit ambivalent about the ricecontrib jira, i kind of feel like a regular old rice jira is just fine, since we will have the pull request as documentation to know we have an outstanding contribute i think that was kind of the point of the RICECONTRIB jira originally was so that contributions didn't just get buried in our jira
        Hide
        Claus Niesen added a comment -

        Shannon made some updates to the page https://wiki.kuali.org/pages/viewpage.action?pageId=338978044
        and I further simplified the page (maybe a bit too drastic) https://wiki.kuali.org/display/KULRICE/Rice+Contribution+Process

        Eric, feel free to pick your favorite starting point and expanding on it. I'm not attached to my version.

        Show
        Claus Niesen added a comment - Shannon made some updates to the page https://wiki.kuali.org/pages/viewpage.action?pageId=338978044 and I further simplified the page (maybe a bit too drastic) https://wiki.kuali.org/display/KULRICE/Rice+Contribution+Process Eric, feel free to pick your favorite starting point and expanding on it. I'm not attached to my version.

          People

          • Assignee:
            Claus Niesen
            Reporter:
            Eric Westfall
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Agile

                Structure Helper Panel