Kuali Rice Development
  1. Kuali Rice Development
  2. KULRICE-14224

DocumentBase ends up with an immutable list of notes

    Details

    • Type: Bug Fix Bug Fix
    • Status: Closed Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.6
    • Component/s: Development
    • Security Level: Public (Public: Anyone can view)
    • Labels:
      None
    • Similar issues:
      KULRICE-1007remove supportsBoNotes from DocumentBase
      KULRICE-3358When reopening an event notification from the action list or doc search, the event's start/end date values have the wrong hour
      KULRICE-5340Determine why CXF Interceptor to enforce immutable lists/collections isn't working on remote tests
      KULRICE-6016Clean up release notes & docbook docs for beta
      KULRICE-888Add "Note" flag to action list fields
      KULRICE-1848DocumentBase should not be using KNSServiceLocator.getBean()
      KULRICE-1096Clean up and remove unnecessary JARs from Rice (i.e. Axis, etc)
      KULRICE-5380remove Timestamp from immutable *Member objects and replace with DateTime
      KULRICE-2565Help Desk action list login is not showing up on Action List
      KULRICE-11889Delimiters should not appear at the end of a checkbox group
    • Sprint:
      Rice Sprint 2015-04-1
    • KAI Review Status:
      Not Required
    • KTI Review Status:
      Not Required
    • Code Review Status:
      Not Required
    • Include in Release Notes?:
      Yes
    • Story Points:
      2

      Description

      KC ran into this problem and were going to patch in their Rice fork by changing the list in GenericQueryResults to a mutable list. But for the master of Rice, I think a better solution is the address the usage of org.kuali.rice.krad.service.NoteService.getByRemoteObjectId so that clients of that method treat it like an immutable list.

      The main issue with that right now is DocumentBase.getNotes. It should be getting the value back from getByRemoteObjectId and creating a new mutable list out of it. In fact, looking at the usage of that method, I think that's the only place this needs to be fixed.

        Activity

        Hide
        Shannon Hess added a comment -
        Show
        Shannon Hess added a comment - Pull request created- https://github.com/kuali/rice/pull/120/

          People

          • Assignee:
            Shannon Hess
            Reporter:
            Eric Westfall
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Agile

                Structure Helper Panel