Uploaded image for project: 'Kuali Rice Development'
  1. Kuali Rice Development
  2. KULRICE-1996

Remove lockCode from DocumentRouteHeaderValue

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.0
    • Component/s: Development
    • Labels:
      None
    • Rice Module:
      KEW

      Description

      This field on DocumentRouteHeaderValue is no longer being used. However it is referenced in a few places so be sure to remove all references to it (and check JSP pages as well). Also note that some of our struts actions are forwarding to a "documentLocked" mapping. This can be removed as well and it should be removed from the struts config and verified that there is not a corresponding JSP page.

      In addition, we can remove the column DOC_LOCK_CD from EN_DOC_HDR_T.

        Attachments

          Activity

          Hide
          delyea David Elyea added a comment -

          Hey Shubangi,

          Check out this website for some instructions on database changes. It goes into some detail about regenerating the main bootstrap files which uses Groovy. Not sure if you have that set up or not. If you need help setting that up let us know.

          https://test.kuali.org/confluence/display/KULRICE/Making+Database+and+Bootstrap+Data+Changes

          The one thing this doesn't mention that you should definately include in this is the mysql ddl file we have. Currently that's manually managed and hopefully by the 0.9.4 release it will be automatically generated but for now we still need to manage it manually. The file is /scripts/ddl/mysql.ddl. Just edit that to remove the field you need to take out.

          Let us know if you have any questions.

          Show
          delyea David Elyea added a comment - Hey Shubangi, Check out this website for some instructions on database changes. It goes into some detail about regenerating the main bootstrap files which uses Groovy. Not sure if you have that set up or not. If you need help setting that up let us know. https://test.kuali.org/confluence/display/KULRICE/Making+Database+and+Bootstrap+Data+Changes The one thing this doesn't mention that you should definately include in this is the mysql ddl file we have. Currently that's manually managed and hopefully by the 0.9.4 release it will be automatically generated but for now we still need to manage it manually. The file is /scripts/ddl/mysql.ddl. Just edit that to remove the field you need to take out. Let us know if you have any questions.
          Hide
          delyea David Elyea added a comment -

          Hey Shubhangi,

          I took a look at the commit and i think there are only two small things that might need changed. Since this Jira issue is still open you can go ahead and resolve it once you've made and committed these changes.

          The first is that in the EN_DOC_HDR_T.table.ddl file you should go ahead and just delete the columns instead of commenting out the lines with those fields. We have the SVN history of the file if we need to revert so you should be safe to remove the lines and use the dball.groovy script to regenerate the bootstrap files. Also on a side note, i don't know if the dball.groovy instructions say to refresh your project in eclipse before syncing the master bootstrap files but that is one thing you do need to do. That could have been the odd things you were seeing before with them.

          The only other thing i did see was that you had a schema name prefixing the table names in your kew-upgrade-0.9.3-to-0.9.4.sql. We try to do all our DDL and SQL assuming it will be run as the schema owner since we can't regulate what schema individual clients may use.

          Let us know if you have any questions.

          Show
          delyea David Elyea added a comment - Hey Shubhangi, I took a look at the commit and i think there are only two small things that might need changed. Since this Jira issue is still open you can go ahead and resolve it once you've made and committed these changes. The first is that in the EN_DOC_HDR_T.table.ddl file you should go ahead and just delete the columns instead of commenting out the lines with those fields. We have the SVN history of the file if we need to revert so you should be safe to remove the lines and use the dball.groovy script to regenerate the bootstrap files. Also on a side note, i don't know if the dball.groovy instructions say to refresh your project in eclipse before syncing the master bootstrap files but that is one thing you do need to do. That could have been the odd things you were seeing before with them. The only other thing i did see was that you had a schema name prefixing the table names in your kew-upgrade-0.9.3-to-0.9.4.sql. We try to do all our DDL and SQL assuming it will be run as the schema owner since we can't regulate what schema individual clients may use. Let us know if you have any questions.
          Hide
          stimble Shubhangi Timble (Inactive) added a comment -

          Hi David,
          I have removed the commented columns from EN_DOC_HDR_T.table.ddl and schema prefix from kew-upgrade-0.9.3-to-0.9.4.sql
          I had seen in my previous project, that database installation scripts failed, if schema name was not specified, so added it in the alter statements.

          Show
          stimble Shubhangi Timble (Inactive) added a comment - Hi David, I have removed the commented columns from EN_DOC_HDR_T.table.ddl and schema prefix from kew-upgrade-0.9.3-to-0.9.4.sql I had seen in my previous project, that database installation scripts failed, if schema name was not specified, so added it in the alter statements.
          Hide
          stimble Shubhangi Timble (Inactive) added a comment -

          I think the content of the files generated is same as the ones I was comparing with in repository, only the sequence of some create/alter statements is different.

          Show
          stimble Shubhangi Timble (Inactive) added a comment - I think the content of the files generated is same as the ones I was comparing with in repository, only the sequence of some create/alter statements is different.
          Hide
          stimble Shubhangi Timble (Inactive) added a comment -

          I compared the files generated today, with the ones in repository, the difference is only in the sequence of create/alter statements.

          Show
          stimble Shubhangi Timble (Inactive) added a comment - I compared the files generated today, with the ones in repository, the difference is only in the sequence of create/alter statements.
          Hide
          delyea David Elyea added a comment -

          Hi Shubhangi,

          I compared the commits (the first one you made and the one you just made just a few hours ago) and the master bootstrap files that needed to change did change. The two lines that had been commented out of the EN_DOC_HDR_T table creation are now completely removed. It's hard to compare since the dball script can't do a set ordering of the statements but your changes were put successfully where they needed to be. Thanks.

          Show
          delyea David Elyea added a comment - Hi Shubhangi, I compared the commits (the first one you made and the one you just made just a few hours ago) and the master bootstrap files that needed to change did change. The two lines that had been commented out of the EN_DOC_HDR_T table creation are now completely removed. It's hard to compare since the dball script can't do a set ordering of the statements but your changes were put successfully where they needed to be. Thanks.

            People

            • Assignee:
              stimble Shubhangi Timble (Inactive)
              Reporter:
              ewestfal Eric Westfall
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Time Tracking

                Estimated:
                Original Estimate - 30 minutes
                30m
                Remaining:
                Remaining Estimate - 30 minutes
                30m
                Logged:
                Time Spent - Not Specified
                Not Specified