Kuali Rice Development
  1. Kuali Rice Development
  2. KULRICE-2056

Improve handling of hidden values in lookup framework.

    Details

    • Type: Bug Fix Bug Fix
    • Status: Closed Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.0, KFS Release 3.0
    • Component/s: Development
    • Labels:
      None
    • Similar issues:
      KULRICE-9599Validation framework improvement for handling collections differently
      KULRICE-4543Exception and incident handling framework improvements
      KULRICE-12551Improvements on handling of template options
      KULRICE-3236Improve handling of person lookups when role is involved
      KULRICE-4737Improve configuration of development framework
      KULRICE-10454Improve handling of the binding errors
      KULRICE-6838UIF Framework - Framework Improvements (AJAX Improvements)
      KULRICE-7472CLONE - UIF Framework - Framework Improvements (AJAX Improvements)
      KULRICE-10917Improve visual treatment of Multi Value Lookups Selection Control
      KULRICE-6671UI Framework - Framework code improvements
    • Rice Module:
      KNS
    • Application Requirement:
      KFS

      Description

      see linked issue

        Issue Links

          Activity

          Hide
          Garey Taylor added a comment -

          Hi All,

          Sorry I was out the past two days, but if you ever feel the need, please email me. Even when I'm taking a day off I try to check my email a couple times a day.

          Thanks,

          Garey

          Show
          Garey Taylor added a comment - Hi All, Sorry I was out the past two days, but if you ever feel the need, please email me. Even when I'm taking a day off I try to check my email a couple times a day. Thanks, Garey
          Hide
          Garey Taylor added a comment -

          Hi All,

          Ok, so I spoke with Warren and I think we were able to figure all this out.

          1. I removed all my initial changes regarding the hidden fields on the standard FieldDefinition.

          1. Regarding KFSMI-2954
          This had been handled by passing the isLookup check into the readonlyfield.tag. So that code should no longer mess with the maintenance docs.

          2. I added a LookupFieldDefinition.java which extends FieldDefinition
          It has both readOnly and hidden boolean fields.

          So, if you want to make something readonly or hidden in lookup, set these fields.

          EX:
          <property name="lookupFields" >
          <list>
          <bean parent="FieldDefinition" p:attributeName="principalId" />
          <bean parent="LookupFieldDefinition" p:attributeName="principalName" p:defaultValue="user*" p:hidden="true"/>
          <bean parent="LookupFieldDefinition" p:attributeName="firstName" p:defaultValue="Eric" p:readOnly="true" />
          ...

          I'm not resolving this issue yet because I haven't had enough time to test these changes. I will do so later tonight. I'm in meetings the rest of the day, but because I have finished coding I thought I would toss this out there.

          Test is out and let me know if it works for you.

          Thanks,

          Garey

          Files Changed/Added:
          rice-0.9.4/impl/src/main/java/org/kuali/rice/kns/datadictionary/LookupFieldDefinition.java
          rice-0.9.4/impl/src/main/java/org/kuali/rice/kns/util/FieldUtils.java
          rice-0.9.4/web/src/main/webapp/WEB-INF/tags/kr/fieldShowReadOnly.tag
          rice-0.9.4/web/src/main/webapp/WEB-INF/tags/kr/readonlyfield.tag
          rice-0.9.4/web/src/main/webapp/WEB-INF/tags/kr/rowDisplay.tag

          Show
          Garey Taylor added a comment - Hi All, Ok, so I spoke with Warren and I think we were able to figure all this out. 1. I removed all my initial changes regarding the hidden fields on the standard FieldDefinition. 1. Regarding KFSMI-2954 This had been handled by passing the isLookup check into the readonlyfield.tag. So that code should no longer mess with the maintenance docs. 2. I added a LookupFieldDefinition.java which extends FieldDefinition It has both readOnly and hidden boolean fields. So, if you want to make something readonly or hidden in lookup, set these fields. EX: <property name="lookupFields" > <list> <bean parent="FieldDefinition" p:attributeName="principalId" /> <bean parent="LookupFieldDefinition" p:attributeName="principalName" p:defaultValue="user*" p:hidden="true"/> <bean parent="LookupFieldDefinition" p:attributeName="firstName" p:defaultValue="Eric" p:readOnly="true" /> ... I'm not resolving this issue yet because I haven't had enough time to test these changes. I will do so later tonight. I'm in meetings the rest of the day, but because I have finished coding I thought I would toss this out there. Test is out and let me know if it works for you. Thanks, Garey Files Changed/Added: rice-0.9.4/impl/src/main/java/org/kuali/rice/kns/datadictionary/LookupFieldDefinition.java rice-0.9.4/impl/src/main/java/org/kuali/rice/kns/util/FieldUtils.java rice-0.9.4/web/src/main/webapp/WEB-INF/tags/kr/fieldShowReadOnly.tag rice-0.9.4/web/src/main/webapp/WEB-INF/tags/kr/readonlyfield.tag rice-0.9.4/web/src/main/webapp/WEB-INF/tags/kr/rowDisplay.tag
          Hide
          Garey Taylor added a comment -

          Did one final commit because I forgot to pass the isLookup param properly into readonlyfield.tag

          Let me know if you have any issues with this.

          Thanks,

          Garey

          Show
          Garey Taylor added a comment - Did one final commit because I forgot to pass the isLookup param properly into readonlyfield.tag Let me know if you have any issues with this. Thanks, Garey
          Hide
          Warren Liang added a comment -

          FYI...I have just moved the hidden/readOnly properties from LookupFieldDefinition into FieldDefinition, and removed the former class.

          Show
          Warren Liang added a comment - FYI...I have just moved the hidden/readOnly properties from LookupFieldDefinition into FieldDefinition, and removed the former class.
          Hide
          Eric Westfall added a comment -

          Bulk change of all Rice 1.0 issues to closed after public release.

          Show
          Eric Westfall added a comment - Bulk change of all Rice 1.0 issues to closed after public release.

            People

            • Assignee:
              Garey Taylor
              Reporter:
              Ailish Byrne
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Structure Helper Panel