Uploaded image for project: 'Kuali Rice Development'
  1. Kuali Rice Development
  2. KULRICE-2238

Convert KEW Rule and Delegate rule documents to use the KNS

    Details

    • Type: Task
    • Status: Closed
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.0
    • Component/s: Development
    • Labels:
      None
    • Rice Module:
      KEW

      Description

      We need to convert the KEW Rule Document to use the KNS. Specific details can be found on the following page:

      https://test.kuali.org/confluence/x/i4CxAQ

        Attachments

          Issue Links

            Activity

            Hide
            ewestfal Eric Westfall added a comment -

            Committed initial round of work here, mostly just playing with the document framework so that I can gain an understanding of how it should work.

            Next step is to write up some enhancement proposals based on how the rule document is going to change. Primarily, I would like to remove the ability to directly define a delegation from a Rule, instead requiring that delegations be created seperately. This feeds into the "improved delegation" task some and perhaps should be treated as part of the enhancements to improve delegation in general.

            Show
            ewestfal Eric Westfall added a comment - Committed initial round of work here, mostly just playing with the document framework so that I can gain an understanding of how it should work. Next step is to write up some enhancement proposals based on how the rule document is going to change. Primarily, I would like to remove the ability to directly define a delegation from a Rule, instead requiring that delegations be created seperately. This feeds into the "improved delegation" task some and perhaps should be treated as part of the enhancements to improve delegation in general.
            Hide
            ewestfal Eric Westfall added a comment -

            There is a functional Rule Maintenance document in place now however it does not have any validation so that piece still needs to be added.

            Additional work which I still need to do here:

            1) Create a page to "front" this maintenance document for selecting RuleTemplate and DocumentType
            2) Add validation to the form (including validation provided by WorkflowAttribute implementations and RuleValidator)
            3) Implement copy functionality
            4) Add Lookup links for groups and persons
            5) Add role responsibilities (currently only has persons and groups)
            6) Update RuleQuickLinks so that it passes properly formed urls for creation of these documents
            7) Implement the Delegate Rule maintenance document (should be similar to rule with the addition of delegation type and selection of responsibility to delegate from)
            8) Clean up all the old rule GUIs and remove all the uneeded methods from RuleService (makeCurrent2, save2, etc.)

            Jeremy is working on the lookup.

            The data model behind all of this should essentially be stable at this point. I made a minor change to the KREW_DLGN_RSP_T table so that it points to it's delegating "responsibility id" instead of "rule responsibiliy id".

            The difference between these two is that "responsibility id" does not change across different versions of a rule, with the "rule responsibility id" is just a surrogate key generated from an oracle sequence which changes will every edit to a rule. This allowed me to break the hard link between RuleResponsibility and it's list of RuleDelegation objects. I modifed FlexRM appropriately to handle fetching of delegations under this tweak to the data model. Making this change should make the rule versioning code exponentially easier to maintain!

            Show
            ewestfal Eric Westfall added a comment - There is a functional Rule Maintenance document in place now however it does not have any validation so that piece still needs to be added. Additional work which I still need to do here: 1) Create a page to "front" this maintenance document for selecting RuleTemplate and DocumentType 2) Add validation to the form (including validation provided by WorkflowAttribute implementations and RuleValidator) 3) Implement copy functionality 4) Add Lookup links for groups and persons 5) Add role responsibilities (currently only has persons and groups) 6) Update RuleQuickLinks so that it passes properly formed urls for creation of these documents 7) Implement the Delegate Rule maintenance document (should be similar to rule with the addition of delegation type and selection of responsibility to delegate from) 8) Clean up all the old rule GUIs and remove all the uneeded methods from RuleService (makeCurrent2, save2, etc.) Jeremy is working on the lookup. The data model behind all of this should essentially be stable at this point. I made a minor change to the KREW_DLGN_RSP_T table so that it points to it's delegating "responsibility id" instead of "rule responsibiliy id". The difference between these two is that "responsibility id" does not change across different versions of a rule, with the "rule responsibility id" is just a surrogate key generated from an oracle sequence which changes will every edit to a rule. This allowed me to break the hard link between RuleResponsibility and it's list of RuleDelegation objects. I modifed FlexRM appropriately to handle fetching of delegations under this tweak to the data model. Making this change should make the rule versioning code exponentially easier to maintain!
            Hide
            ewestfal Eric Westfall added a comment -

            Additionally, started the following document in order to document the changes in the Rule documents between 0.9.3 and 1.0 for end users and implementors.

            https://test.kuali.org/confluence/x/xIHyBw

            Show
            ewestfal Eric Westfall added a comment - Additionally, started the following document in order to document the changes in the Rule documents between 0.9.3 and 1.0 for end users and implementors. https://test.kuali.org/confluence/x/xIHyBw
            Hide
            ewestfal Eric Westfall added a comment -

            This work has essentially been completed. There are some outlying tasks which relate to this that are captured in separate JIRAs. Those represent the remainder of work related to this task. This are linked to this jira as well.

            Show
            ewestfal Eric Westfall added a comment - This work has essentially been completed. There are some outlying tasks which relate to this that are captured in separate JIRAs. Those represent the remainder of work related to this task. This are linked to this jira as well.
            Hide
            ewestfal Eric Westfall added a comment -

            Bulk change of all Rice 1.0 issues to closed after public release.

            Show
            ewestfal Eric Westfall added a comment - Bulk change of all Rice 1.0 issues to closed after public release.

              People

              • Assignee:
                ewestfal Eric Westfall
                Reporter:
                ewestfal Eric Westfall
              • Votes:
                0 Vote for this issue
                Watchers:
                0 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Time Tracking

                  Estimated:
                  Original Estimate - 1 week
                  1w
                  Remaining:
                  Remaining Estimate - 1 week
                  1w
                  Logged:
                  Time Spent - Not Specified
                  Not Specified