Kuali Rice Development
  1. Kuali Rice Development
  2. KULRICE-240

review the maintenance framework dd override functionality

    Details

    • Type: Improvement Improvement
    • Status: Closed Closed
    • Priority: Major Major
    • Resolution: Won't Fix
    • Affects Version/s: None
    • Fix Version/s: Not version specific
    • Component/s: Analysis
    • Labels:
      None
    • Similar issues:
      KULRICE-4258Inconsistent use of Formatters in maintenance framework
      KULRICE-11390Create Automated Functional Tests for KRAD Labs - Maintenance Sample - Override Values
      KULRICE-8794Perform analysis of the KNS maintenance framework
      KULRICE-916Create a confluence page for the Maintenance Framework
      KULRICE-4102Maintenance Document framework assumes objects are persistable
      KULRICE-6420Javadocs for KRMS api & framework by function
      KULRICE-13518Create smoke test for the dd property allowsRecordDeletion
      KULRICE-139increase flexibility of field --> lookup associations in the maintenance framework
      KULRICE-901DD parse problem when BO & Trans. DD entries have related names
      KULRICE-13521 Create smoke test for KRAD Maintenance Document to test specifying a maintainableClass in DD

      Description

      Here are warren's comments. i link the related isue with more info...

      I think there should be improvements made to the maintainable's DD override framework. As it stands now,

      1) the override functionality is not completely implemented (since vendor was the only one that used the override in a non-trivial way, I took the fastest approach to resolve this issue). There are other places where the override methods need to be called in section/field bridge.

      2) every time the maint doc renders, it makes at least 2 (possibly many) copies of each maint doc DD section/field/collection entry (one each for new and old maintainable) using ObjectUtils.deepCopy regardless of whether a meaningful override is implemented. Copying prevents DD corruption issues by preventing changes to the global DD entries. The default meaningless override implementation does nothing, so a copy isn't needed.

      This probably isn't the fastest approach and it affects the performance whether or not a meaningful override is performed. Perhaps we could modify the maint doc DD service to return a new copy of the complete maint doc entry so that we can limit the system to one copy of the DD entry for that doc (i.e. make a deep copy at the <maintenanceDocument> level of a maint doc DD xml file) per maint doc web request.

      3) the DD override interface could probably be made more meaningful. The current interface is:
      public void overrideDataDictionaryFieldConfiguration(DataDictionaryDefinitionBase definition)
      public void overrideDataDictionarySectionConfiguration(DataDictionaryDefinitionBase definition)

      These methods could at least use parameter types that are more meaningful.

        Issue Links

          Activity

          Ailish Byrne made changes -
          Field Original Value New Value
          Link This issue discovered by KULRNE-4588 [ KULRNE-4588 ]
          Ailish Byrne made changes -
          Fix Version/s Wish List [ 13845 ]
          Ailish Byrne made changes -
          Fix Version/s KFS Release 4.0 [ 12781 ]
          Fix Version/s Wish List [ 13845 ]
          Kymber Horn made changes -
          Status Open [ 1 ] Closed [ 6 ]
          Resolution Fixed [ 1 ]
          Kymber Horn made changes -
          Resolution Fixed [ 1 ]
          Status Closed [ 6 ] Reopened [ 4 ]
          Kymber Horn made changes -
          Comment [ tech issue ]
          Kymber Horn made changes -
          Comment [ Oops!!! ]
          Ailish Byrne made changes -
          Reporter Ailish Byrne [ abyrne ] Jerry Neal [ jkneal ]
          Jerry Neal (Inactive) made changes -
          Fix Version/s KFS Release 4.0 [ 12781 ]
          Jerry Neal (Inactive) made changes -
          Reporter Jerry Neal [ jkneal ] Dan Lemus [ dlemus ]
          Jessica Coltrin (Inactive) made changes -
          Fix Version/s Not Scheduled [ 16113 ]
          Jessica Coltrin (Inactive) made changes -
          Fix Version/s 1.x [ 16014 ]
          Fix Version/s Not Scheduled [ 16113 ]
          Jessica Coltrin (Inactive) made changes -
          Start Date
          Fix Date [ set to sprint end date ]
          Jessica Coltrin (Inactive) made changes -
          Fix Version/s 2.x-backlog [ 15811 ]
          Fix Version/s 1.x-backlog [ 16014 ]
          Jessica Coltrin (Inactive) made changes -
          Start Date
          Fix Date [ set to sprint end date ]
          Shem Patterson (Inactive) made changes -
          Workflow custom [ 41900 ] Copy of custom for rice [ 208354 ]
          Shem Patterson (Inactive) made changes -
          Workflow Copy of custom for rice [ 208354 ] custom [ 218102 ]
          Shem Patterson (Inactive) made changes -
          Workflow custom [ 218102 ] Rice Workflow [ 227850 ]
          Jessica Coltrin (Inactive) made changes -
          Status Reopened [ 4 ] Closed [ 6 ]
          Resolution Won't Fix [ 2 ]
          Jessica Coltrin (Inactive) made changes -
          Fix Version/s Backlog [ 15811 ]
          Claus Niesen made changes -
          Fix Version/s Not version specific [ 17967 ]

            People

            • Assignee:
              Unassigned
              Reporter:
              Dan Lemus (Inactive)
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Structure Helper Panel