Kuali Rice Development
  1. Kuali Rice Development
  2. KULRICE-2416

all rice actions should extend KualiAction, so these permissions are enforced - they replace any existing app constants or configuration related to rice authz - please double check for any i missed

    Details

    • Type: Task Task
    • Status: Closed Closed
    • Priority: Blocker Blocker
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.0
    • Component/s: Development
    • Labels:
      None
    • Similar issues:
      KULRICE-8782KRAD AuthZ is difficult to extend
      KULRICE-2539Ensure old permission-related Application Constants are converted over to KIM, completely remove remaining pieces of Application Constants services and screens
      KULRICE-6497Change constant used in moduleLocked.jsp to be in KRADConstants instead of KualiAction
      KULRICE-6749Configure rice sample app as a client app running against a standalone server
      KULRICE-12426Move UifComponentValidationRegexPatternAftBase and dependencies to KRAD Sample App
      KULRICE-5612Check in selenium tests to rice-sampleapp module
      KULRICE-3185ActionList page doesn't have any internal margins
      KULRICE-2700Drop KREW_APPL_CNST_T from our database, update existing documentation on App constants to System parameter migration
      KULRICE-4192Clean up references to "kew.standalone.server" and other out-of-date Rice configuration parameters
      KULRICE-5418Setup build tools to enforce some set of code formatting standards
    • Rice Module:
      Rice Core, KSB, KNS, KEW, KEN, KCB, KIM, KOM
    • Application Requirement:
      KFS, KC, KS, Rice

      Description

      format is template / permission namespace / permission details
      KR-SYS Use Screen / KR-WKFLW / org.kuali.rice.kew.documentoperation.web.DocumentOperationAction
      KR-SYS Use Screen / KR-BUS / org.kuali.rice.ksb.security.admin.web.JavaSecurityManagementAction
      KR-SYS Use Screen / KR-BUS / org.kuali.rice.ksb.messaging.web.MessageQueueAction
      KR-SYS Use Screen / KR-BUS / org.kuali.rice.ksb.messaging.web.ServiceRegistryAction
      KR-SYS Use Screen / KR-BUS / org.kuali.rice.ksb.messaging.web.ThreadPoolAction
      KR-SYS Use Screen / KR-BUS / org.kuali.rice.ksb.messaging.web.QuartzQueueAction

        Issue Links

          Activity

          Hide
          Ailish Byrne added a comment -

          as usual - fee free to assign someone else

          Show
          Ailish Byrne added a comment - as usual - fee free to assign someone else
          Hide
          Eric Westfall added a comment -

          Ailish, so simply having our actions extend from KualiAction will allow for these checks to take place (i.e. there's nothing additional that needs to be done here?)

          Casey, in general regarding this work we should replace anywhere where we extend either WorkflowAction or KSBAction with KualiAction. KualiAction should have most of the functionality that these other 2 actions have, however it doesn't have all of it. So if this is an issue, an interim solution would be to have KSBAction and WorkflowAction extend KualiAction and then just remove any duplicate methods from the workflow/ksb actions. As we continue to work on the KEW -> KNS refactoring we will probably no longer need any of these custom methods (i.e. cancelDocument on WorkflowAction).

          There are some screens in workflow which you don't need to worry about converting yet. These include:

          1) WorkgroupAction (will be replaced by KIM)
          2) WorkgroupTypeAction (will be replaced by KIM)
          3) WorkflowUserAction (will be replaced by KIM)
          4) ApplicationCOnstantsAction (will be replaced by system parameters)

          Thanks,
          Eric

          Show
          Eric Westfall added a comment - Ailish, so simply having our actions extend from KualiAction will allow for these checks to take place (i.e. there's nothing additional that needs to be done here?) Casey, in general regarding this work we should replace anywhere where we extend either WorkflowAction or KSBAction with KualiAction. KualiAction should have most of the functionality that these other 2 actions have, however it doesn't have all of it. So if this is an issue, an interim solution would be to have KSBAction and WorkflowAction extend KualiAction and then just remove any duplicate methods from the workflow/ksb actions. As we continue to work on the KEW -> KNS refactoring we will probably no longer need any of these custom methods (i.e. cancelDocument on WorkflowAction). There are some screens in workflow which you don't need to worry about converting yet. These include: 1) WorkgroupAction (will be replaced by KIM) 2) WorkgroupTypeAction (will be replaced by KIM) 3) WorkflowUserAction (will be replaced by KIM) 4) ApplicationCOnstantsAction (will be replaced by system parameters) Thanks, Eric
          Hide
          Ailish Byrne added a comment -

          yes - there's a checkAuthorization method in KualiAction that uses the ModuleAuthorizer now and will be modified to look for these permissions in kim. KualiLookupAction, KualiInquiryAction, and KualiDocumentAction will override that to do more specific / detailed permission checking -thanks! p.s. so i think this should eliminate the need for the ksb authz service we had to implement in kfs to lock down those screens per the ksb authz model

          Show
          Ailish Byrne added a comment - yes - there's a checkAuthorization method in KualiAction that uses the ModuleAuthorizer now and will be modified to look for these permissions in kim. KualiLookupAction, KualiInquiryAction, and KualiDocumentAction will override that to do more specific / detailed permission checking -thanks! p.s. so i think this should eliminate the need for the ksb authz service we had to implement in kfs to lock down those screens per the ksb authz model
          Hide
          Eric Westfall added a comment -

          Regarding this issue, I discovered it was going to be an easier transition here if I just added the checkAuthorization method to the KSBAction. Have these extend from KualiAction would result in more sweeping changes that I don't think is worth dealing with right now (the idea is to refactor away from KSBAction and WorkflowAction into KualiAction eventually anyway).

          Casey, I made this change for the KSBAction by adding and call the checkAuthorization method. Can you make a corresponding change in WorkflowAction to accomodate this? Thanks!

          Show
          Eric Westfall added a comment - Regarding this issue, I discovered it was going to be an easier transition here if I just added the checkAuthorization method to the KSBAction. Have these extend from KualiAction would result in more sweeping changes that I don't think is worth dealing with right now (the idea is to refactor away from KSBAction and WorkflowAction into KualiAction eventually anyway). Casey, I made this change for the KSBAction by adding and call the checkAuthorization method. Can you make a corresponding change in WorkflowAction to accomodate this? Thanks!
          Hide
          Casey Boettcher (Inactive) added a comment -

          Made appropriate changes to WorkflowAction

          Show
          Casey Boettcher (Inactive) added a comment - Made appropriate changes to WorkflowAction
          Hide
          Eric Westfall added a comment -

          Bulk change of all Rice 1.0 issues to closed after public release.

          Show
          Eric Westfall added a comment - Bulk change of all Rice 1.0 issues to closed after public release.

            People

            • Assignee:
              Casey Boettcher (Inactive)
              Reporter:
              Ailish Byrne
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Due:
                Created:
                Updated:
                Resolved:

                Structure Helper Panel