Kuali Rice Development
  1. Kuali Rice Development
  2. KULRICE-2548

Docs opened from action list and document search are opening in a new window

    Details

    • Type: Bug Fix Bug Fix
    • Status: Closed Closed
    • Priority: Critical Critical
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.0, KFS Release 3.0
    • Component/s: Development
    • Labels:
      None
    • Similar issues:
      KULRICE-1605Clicking on a Document ID from Doc Search opens a new window (different behavior than Action List)
      KULRICE-4104Opening from doc search opens new window - clicking close returns to the portal in the new window
      KULRICE-2006Opening KIM docs from workflow action list should not spawn new browser window
      KULRICE-12542Prevent KRAD views from opening in doc search iframe
      KULRICE-6587Document Search Results open in a new window regardless of the system parameter (DOCUMENT_SEARCH_POPUP_IND) value
      KULRICE-1710Opening a Maintenance Document from the Action List or Document Search throws NPE
      KULRICE-3928KIM Lookups not opening inquiries in new windows
      KULRICE-8693'Fiscal Officer Info Maintenance Document' type item not accessible from Action List and Doc Search
      KULRICE-1119Dochandler links not launching in new window in sample app
      KULRICE-5463Rice Dev: Trying to open newly created Campus Maintenance eDoc from doc search throws error
    • Rice Module:
      KEW
    • Application Requirement:
      KFS, KC, KS, Rice

      Description

      i'm assuming this relates to the workflow changes? see linked issue

        Issue Links

          Activity

          Hide
          Jeremy Hanson added a comment -

          Action List now only opens a new page for each document if System Parameter ACTION_LIST_DOCUMENT_POPUP_IND is set to 'Y'

          Show
          Jeremy Hanson added a comment - Action List now only opens a new page for each document if System Parameter ACTION_LIST_DOCUMENT_POPUP_IND is set to 'Y'
          Hide
          Ailish Byrne added a comment -

          we are still having this problem with docs opened from doc search and we have the corresponding parm set to N. sorry that i didn't mention doc search in this issues originally - an mission on my part

          Show
          Ailish Byrne added a comment - we are still having this problem with docs opened from doc search and we have the corresponding parm set to N. sorry that i didn't mention doc search in this issues originally - an mission on my part
          Hide
          Jeremy Hanson added a comment -

          It looks like StandardDocumentSearchResultProcessor is generating the url correctly (there is no target="_blank"), but then in DocSearchCriteriaDTO, it reconstructs the url for the Column columnAnchor field.

          From there, KualiLookup.jsp adds the target="_blank" property on the link.

          Show
          Jeremy Hanson added a comment - It looks like StandardDocumentSearchResultProcessor is generating the url correctly (there is no target="_blank"), but then in DocSearchCriteriaDTO, it reconstructs the url for the Column columnAnchor field. From there, KualiLookup.jsp adds the target="_blank" property on the link.
          Hide
          Jeremy Hanson added a comment -

          In my local files, I've modifed KualiLookup.jsp so that instead of always using target="blank" on each column link, I grab the columnAnchor.target value and use it unless it is empty (null or ""), if it is empty a target="_blank" value is used to match the default of what is happening now.

          Then when recreating the urls in DocSearchCriteriaDTOLookupableHelper, the AnchorHtmlData's target property is set based off the url created in StandardDocumentSearchResultProcessor.

          This is working locally for me, and not breaking any current lookups that I can see. Is there any concerns with modifying KualiLookup.jsp to behave this way?

          Show
          Jeremy Hanson added a comment - In my local files, I've modifed KualiLookup.jsp so that instead of always using target="blank" on each column link, I grab the columnAnchor.target value and use it unless it is empty (null or ""), if it is empty a target="_blank" value is used to match the default of what is happening now. Then when recreating the urls in DocSearchCriteriaDTOLookupableHelper, the AnchorHtmlData's target property is set based off the url created in StandardDocumentSearchResultProcessor. This is working locally for me, and not breaking any current lookups that I can see. Is there any concerns with modifying KualiLookup.jsp to behave this way?
          Hide
          Eric Westfall added a comment -

          That sounds good to me. Should be non-impacting

          Show
          Eric Westfall added a comment - That sounds good to me. Should be non-impacting
          Hide
          Jeremy Hanson added a comment -

          This change has been committed and Document Search links should now only pop up depending on the corresponding System Parameters.

          Show
          Jeremy Hanson added a comment - This change has been committed and Document Search links should now only pop up depending on the corresponding System Parameters.
          Hide
          Ailish Byrne added a comment -

          kfs issue was reopened

          Show
          Ailish Byrne added a comment - kfs issue was reopened
          Hide
          Ailish Byrne added a comment -

          annoying. i checked that it wasn't in dba before reopening but didn't look at reg. one tester must have flipped and the other didn't know. sorry to both jeremy

          Show
          Ailish Byrne added a comment - annoying. i checked that it wasn't in dba before reopening but didn't look at reg. one tester must have flipped and the other didn't know. sorry to both jeremy

            People

            • Assignee:
              Jeremy Hanson
              Reporter:
              Ailish Byrne
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Structure Helper Panel