Uploaded image for project: 'Kuali Rice Development'
  1. Kuali Rice Development
  2. KULRICE-2548

Docs opened from action list and document search are opening in a new window

    Details

    • Type: Bug Fix
    • Status: Closed
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.0, KFS Release 3.0
    • Component/s: Development
    • Labels:
      None
    • Rice Module:
      KEW
    • Application Requirement:
      KFS, KC, KS, Rice

      Description

      i'm assuming this relates to the workflow changes? see linked issue

        Attachments

          Issue Links

            Activity

            Hide
            jjhanso Jeremy Hanson added a comment -

            Action List now only opens a new page for each document if System Parameter ACTION_LIST_DOCUMENT_POPUP_IND is set to 'Y'

            Show
            jjhanso Jeremy Hanson added a comment - Action List now only opens a new page for each document if System Parameter ACTION_LIST_DOCUMENT_POPUP_IND is set to 'Y'
            Hide
            abyrne Ailish Byrne added a comment -

            we are still having this problem with docs opened from doc search and we have the corresponding parm set to N. sorry that i didn't mention doc search in this issues originally - an mission on my part

            Show
            abyrne Ailish Byrne added a comment - we are still having this problem with docs opened from doc search and we have the corresponding parm set to N. sorry that i didn't mention doc search in this issues originally - an mission on my part
            Hide
            jjhanso Jeremy Hanson added a comment -

            It looks like StandardDocumentSearchResultProcessor is generating the url correctly (there is no target="_blank"), but then in DocSearchCriteriaDTO, it reconstructs the url for the Column columnAnchor field.

            From there, KualiLookup.jsp adds the target="_blank" property on the link.

            Show
            jjhanso Jeremy Hanson added a comment - It looks like StandardDocumentSearchResultProcessor is generating the url correctly (there is no target="_blank"), but then in DocSearchCriteriaDTO, it reconstructs the url for the Column columnAnchor field. From there, KualiLookup.jsp adds the target="_blank" property on the link.
            Hide
            jjhanso Jeremy Hanson added a comment -

            In my local files, I've modifed KualiLookup.jsp so that instead of always using target="blank" on each column link, I grab the columnAnchor.target value and use it unless it is empty (null or ""), if it is empty a target="_blank" value is used to match the default of what is happening now.

            Then when recreating the urls in DocSearchCriteriaDTOLookupableHelper, the AnchorHtmlData's target property is set based off the url created in StandardDocumentSearchResultProcessor.

            This is working locally for me, and not breaking any current lookups that I can see. Is there any concerns with modifying KualiLookup.jsp to behave this way?

            Show
            jjhanso Jeremy Hanson added a comment - In my local files, I've modifed KualiLookup.jsp so that instead of always using target="blank" on each column link, I grab the columnAnchor.target value and use it unless it is empty (null or ""), if it is empty a target="_blank" value is used to match the default of what is happening now. Then when recreating the urls in DocSearchCriteriaDTOLookupableHelper, the AnchorHtmlData's target property is set based off the url created in StandardDocumentSearchResultProcessor. This is working locally for me, and not breaking any current lookups that I can see. Is there any concerns with modifying KualiLookup.jsp to behave this way?
            Hide
            ewestfal Eric Westfall added a comment -

            That sounds good to me. Should be non-impacting

            Show
            ewestfal Eric Westfall added a comment - That sounds good to me. Should be non-impacting
            Hide
            jjhanso Jeremy Hanson added a comment -

            This change has been committed and Document Search links should now only pop up depending on the corresponding System Parameters.

            Show
            jjhanso Jeremy Hanson added a comment - This change has been committed and Document Search links should now only pop up depending on the corresponding System Parameters.
            Hide
            abyrne Ailish Byrne added a comment -

            kfs issue was reopened

            Show
            abyrne Ailish Byrne added a comment - kfs issue was reopened
            Hide
            abyrne Ailish Byrne added a comment -

            annoying. i checked that it wasn't in dba before reopening but didn't look at reg. one tester must have flipped and the other didn't know. sorry to both jeremy

            Show
            abyrne Ailish Byrne added a comment - annoying. i checked that it wasn't in dba before reopening but didn't look at reg. one tester must have flipped and the other didn't know. sorry to both jeremy

              People

              • Assignee:
                jjhanso Jeremy Hanson
                Reporter:
                abyrne Ailish Byrne
              • Votes:
                0 Vote for this issue
                Watchers:
                0 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: