Uploaded image for project: 'Kuali Rice Development'
  1. Kuali Rice Development
  2. KULRICE-2592

Ensure that the XML Ingester is returning meaningful messages

    Details

    • Type: Task
    • Status: Closed
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.0
    • Component/s: Development
    • Labels:
      None
    • Rice Module:
      KEW

      Description

      Essentially, if ingestion throws an exception we need to make sure the error message on the exception is displayed properly.

        Attachments

          Activity

          Hide
          abyrne Ailish Byrne added a comment -

          i got an interesting error from te ingester earlier today - it complained that i'd defined nodes in the doc type i wasn't using. i don't care, just sort of suprised that you're required to use a node in a process defn if you define it

          Show
          abyrne Ailish Byrne added a comment - i got an interesting error from te ingester earlier today - it complained that i'd defined nodes in the doc type i wasn't using. i don't care, just sort of suprised that you're required to use a node in a process defn if you define it
          Hide
          ewestfal Eric Westfall added a comment -

          Yeah, that code was put in the document type xml parser to prevent orphaned nodes from getting created by accident (basically, it was assumed that if you declared a node but didn't use it, you made a mistake in your process definition

          Show
          ewestfal Eric Westfall added a comment - Yeah, that code was put in the document type xml parser to prevent orphaned nodes from getting created by accident (basically, it was assumed that if you declared a node but didn't use it, you made a mistake in your process definition
          Hide
          ewestfal Eric Westfall added a comment -

          Assigning to Peter.

          Peter, the url for the ingester will be http://localhost:8080/kr-dev/en/Ingester.do

          You've probably used it before so you may already be familiar with it. Essentially we need to make sure it is rendering it's error messages properly formatted (i.e. each line of the stack trace on it's own line). Right now they are all jumbled together. Might be as easy as inserting a <pre>...</pre> around the error message.

          After you do that, I want to address some of the visual issues. The file boxes don't really line up very well and the button looks weird if I recall correct (has a recessed border around it).

          Essentially, we want it to have a similar look and feel to some of our lookup screens regarding how the button looks (you can look at the Document Type lookup, Rule Attribute Lookup, Rule Template lookup, etc. for an example of what I mean).

          Show
          ewestfal Eric Westfall added a comment - Assigning to Peter. Peter, the url for the ingester will be http://localhost:8080/kr-dev/en/Ingester.do You've probably used it before so you may already be familiar with it. Essentially we need to make sure it is rendering it's error messages properly formatted (i.e. each line of the stack trace on it's own line). Right now they are all jumbled together. Might be as easy as inserting a <pre>...</pre> around the error message. After you do that, I want to address some of the visual issues. The file boxes don't really line up very well and the button looks weird if I recall correct (has a recessed border around it). Essentially, we want it to have a similar look and feel to some of our lookup screens regarding how the button looks (you can look at the Document Type lookup, Rule Attribute Lookup, Rule Template lookup, etc. for an example of what I mean).
          Hide
          gilesp Peter Giles (Inactive) added a comment -

          Refactored ingester.jsp:

          • improved formatting of errors by surrounding error messages with pre tags
          • used tag libs for iteration instead of inline java
          • wrapped form elements in a table to more closely match lookup screens
          • restructured the jsp to more closely follow the model of KualiLookup.jsp.
          Show
          gilesp Peter Giles (Inactive) added a comment - Refactored ingester.jsp: improved formatting of errors by surrounding error messages with pre tags used tag libs for iteration instead of inline java wrapped form elements in a table to more closely match lookup screens restructured the jsp to more closely follow the model of KualiLookup.jsp.
          Hide
          ewestfal Eric Westfall added a comment -

          Re-opening to update fix version.

          Show
          ewestfal Eric Westfall added a comment - Re-opening to update fix version.
          Hide
          ewestfal Eric Westfall added a comment -

          Bulk change of all Rice 1.0 issues to closed after public release.

          Show
          ewestfal Eric Westfall added a comment - Bulk change of all Rice 1.0 issues to closed after public release.

            People

            • Assignee:
              gilesp Peter Giles (Inactive)
              Reporter:
              ewestfal Eric Westfall
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: