Uploaded image for project: 'Kuali Rice Development'
  1. Kuali Rice Development
  2. KULRICE-2649

Verify that our jsps and tag libraries are using quotes properly and work successfully in Tomcat 5.5.27

    Details

    • Type: Task
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.0
    • Component/s: Application Server
    • Labels:
      None

      Description

      See the following Tomcat bug report for details of what we need to verify

      https://issues.apache.org/bugzilla/show_bug.cgi?id=45015

        Attachments

          Issue Links

            Activity

            Hide
            jjhanso Jeremy Hanson added a comment -

            In the bugzilla link there is a nice regular expression to find instances of these problems.

            <\w+:[^>]="[^<"]<%=[^%]"|<\w:[^>]+='[^<']<%=[^%]'

            I ran this and there are currently only two places in all jsp and tag files that need to be updated.

            Row 29 of KualiExceptionIncident.jsp
            – should be changed to:
            value='<%=request.getAttribute("org.kuali.rice.kns.web.struts.action.KualiExceptionHandlerAction")%>' />
            and
            Row 670 of rowDisplay.tag
            – should be changed to:
            <c:out value='<%=((String) request.getAttribute("fileName"))%>' /> 

            Show
            jjhanso Jeremy Hanson added a comment - In the bugzilla link there is a nice regular expression to find instances of these problems. <\w+: [^>] =" [^<"] <%= [^%] "|<\w : [^>] +=' [^<'] <%= [^%] ' I ran this and there are currently only two places in all jsp and tag files that need to be updated. Row 29 of KualiExceptionIncident.jsp – should be changed to: value='<%=request.getAttribute("org.kuali.rice.kns.web.struts.action.KualiExceptionHandlerAction")%>' /> and Row 670 of rowDisplay.tag – should be changed to: <c:out value='<%=((String) request.getAttribute("fileName"))%>' /> 
            Hide
            ewestfal Eric Westfall added a comment -

            Initial version has been deployed to maven repository and weekly deployments are in place on Friday's at 4 in continuum.

            Show
            ewestfal Eric Westfall added a comment - Initial version has been deployed to maven repository and weekly deployments are in place on Friday's at 4 in continuum.
            Hide
            smummadi Srikanth Mummadi (Inactive) added a comment -

            I am still getting the following error when I try to deploy "rice-0.9.4-SNAPSHOT-server.war" in Tomcat.

            org.springframework.beans.factory.BeanCreationException: Error creating bean with name 'rice' defined in class path resource [org/kuali/rice/config/RiceSpringBeans.xml]: Invocation of init method failed; nested exception is java.io.FileNotFoundException: class path resource [log4j.properties] cannot be resolved to absolute file path because it does not reside in the file system: jar:file:/C:/Program%20Files/Apache%20Software%20Foundation/Tomcat%205.5/webapps/rice-0.9.4-SNAPSHOT-server/WEB-INF/lib/bsf-2.4.0.jar!/log4j.properties

            But I tested rowDisplay.tag in KFS 1092 build, but it throws the following exception

            org.apache.jasper.JasperException: /WEB-INF/tags/kr/rowDisplay.tag(670,26) Attribute value ((String) request.getAttribute("fileName")) is quoted with " which must be escaped when used within the value

            I corrected this file and checked in.
            For KualiExceptionIncident.jsp, I could not generate Exception condition in KFS so could not test/change it.

            Show
            smummadi Srikanth Mummadi (Inactive) added a comment - I am still getting the following error when I try to deploy "rice-0.9.4-SNAPSHOT-server.war" in Tomcat. org.springframework.beans.factory.BeanCreationException: Error creating bean with name 'rice' defined in class path resource [org/kuali/rice/config/RiceSpringBeans.xml] : Invocation of init method failed; nested exception is java.io.FileNotFoundException: class path resource [log4j.properties] cannot be resolved to absolute file path because it does not reside in the file system: jar: file:/C:/Program%20Files/Apache%20Software%20Foundation/Tomcat%205.5/webapps/rice-0.9.4-SNAPSHOT-server/WEB-INF/lib/bsf-2.4.0.jar!/log4j.properties But I tested rowDisplay.tag in KFS 1092 build, but it throws the following exception org.apache.jasper.JasperException: /WEB-INF/tags/kr/rowDisplay.tag(670,26) Attribute value ((String) request.getAttribute("fileName")) is quoted with " which must be escaped when used within the value I corrected this file and checked in. For KualiExceptionIncident.jsp, I could not generate Exception condition in KFS so could not test/change it.
            Hide
            ewestfal Eric Westfall added a comment -

            Thanks Srikanth and Jeremy. I went ahead and fixed this in the incident report as well.

            Show
            ewestfal Eric Westfall added a comment - Thanks Srikanth and Jeremy. I went ahead and fixed this in the incident report as well.
            Hide
            ewestfal Eric Westfall added a comment -

            Bulk change of all Rice 1.0 issues to closed after public release.

            Show
            ewestfal Eric Westfall added a comment - Bulk change of all Rice 1.0 issues to closed after public release.

              People

              • Assignee:
                smummadi Srikanth Mummadi (Inactive)
                Reporter:
                ewestfal Eric Westfall
              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: