Kuali Rice Development
  1. Kuali Rice Development
  2. KULRICE-2884

Move existing struts-based screens and actions out of the "en" module struts-config.xml into the "kew" struts module

    Details

    • Type: Improvement Improvement
    • Status: Closed Closed
    • Priority: Critical Critical
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.0
    • Component/s: Development
    • Labels:
      None
    • Similar issues:
      KULRICE-2177Consolidate all Rice Struts modules into a single struts module
      KULRICE-2992Delete EN web module
      KULRICE-2706Create forwards from "kew" struts module to screens that still remain in the "en" struts module
      KULRICE-2975Move KEW HtmlUnit tests into the "web" module
      KULRICE-2704Remove temporary struts mappings in the "en" struts-config.xml file
      KULRICE-4042updateTextArea forward missing from struts config
      KULRICE-8428Improved support for KRAD modules
      KULRICE-2644Implement a "front page" for routing rule creation that allows the user to select the document type and rule template prior to creating the rule
      KULRICE-5708Move only partially realized impl and framework modules back into the catchall "impl" module
      KULRICE-8939Move non-UIF dependent components out of KRAD app-framework module
    • Rice Module:
      KEW

      Description

      We should go ahead and kill off the "en" struts module. There are a few screens still hanging around in there but I think it will be easy to move them out. It will involve the following:

      1) Change them from extending WorkflowAction to KewKualiAction
      2) Make any changes in the jsps necessary to use the KNS tag libraries
      3) We need to communicate with KFS once this struts module has been removed so that they can update any old links they might have
      4) Verify we don't have any links into the old struts-module
      5) Remove the temporary forward mappings that are in the "kew" struts-config.xml that forward into the "en" struts module
      6) Move any message resources properties that are needed from org.kuali.rice.kew.ApplicationResources.properties into KR-ApplicationResources.properties (i think that's the right file?) or create a new KEW-ApplicationResources.properties and put it in the configurationServiceData.xml

      Jeremy, I think you already have done this for routing report and route log. I think the only screens left are:

      SuperUser
      Stats
      Ingester
      Backdoor
      Portal
      Administration
      Preferences
      DocHandler
      etc.

      just take a look at what is in the "en" struts-config.xml

      The following screens I think we can just remove:

      /Rule
      /DelegateRule
      /WorkflowDocHandler? (i don't think this is being used anymore?)
      /Feedback? (after we move these out can we just use the KNS incident reporting screen?)
      All the old action list stuff

        Issue Links

          Activity

          Hide
          Jeremy Hanson added a comment -

          Primary commit is done. All screens should be moved out of en and either deleted or moved to KEW.

          EN module has not been removed yet. EN's web.xml file is required for KEW's unit tests, and currently the en module's struts-config.xml file forwards everything to kew.

          Should I resolve this jira and create a new one about removing the remaining portion of the en web module?

          Show
          Jeremy Hanson added a comment - Primary commit is done. All screens should be moved out of en and either deleted or moved to KEW. EN module has not been removed yet. EN's web.xml file is required for KEW's unit tests, and currently the en module's struts-config.xml file forwards everything to kew. Should I resolve this jira and create a new one about removing the remaining portion of the en web module?
          Hide
          Eric Westfall added a comment -

          Great, thanks Jeremy. Yes please resolve this and create a new one. We will need to do some work on the kew unit tests to effectively finish removing the en struts module for good but we can resolve this issue which represents the lion's share of this work.

          Show
          Eric Westfall added a comment - Great, thanks Jeremy. Yes please resolve this and create a new one. We will need to do some work on the kew unit tests to effectively finish removing the en struts module for good but we can resolve this issue which represents the lion's share of this work.
          Hide
          David Elyea added a comment -

          Do we need to change the default workflow.url parameter to point to /kew instead of /en as part of this change? I believe it's in the rice-config.xml file in /web/src/main/config/example-config/. I don't think that rice-config.xml file is in any way correct but if we can start tracking changes correctly in these files we should be able to catch back up.

          Show
          David Elyea added a comment - Do we need to change the default workflow.url parameter to point to /kew instead of /en as part of this change? I believe it's in the rice-config.xml file in /web/src/main/config/example-config/. I don't think that rice-config.xml file is in any way correct but if we can start tracking changes correctly in these files we should be able to catch back up.
          Hide
          Jeremy Hanson added a comment -

          Probably yes. Things will work at the moment because of the forwards, but once the en struts-config is gone, this could probably cause some problems.

          Show
          Jeremy Hanson added a comment - Probably yes. Things will work at the moment because of the forwards, but once the en struts-config is gone, this could probably cause some problems.
          Hide
          Eric Westfall added a comment -

          Bulk change of all Rice 1.0 issues to closed after public release.

          Show
          Eric Westfall added a comment - Bulk change of all Rice 1.0 issues to closed after public release.

            People

            • Assignee:
              Jeremy Hanson
              Reporter:
              Eric Westfall
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Time Tracking

                Estimated:
                Original Estimate - 2 days
                2d
                Remaining:
                Remaining Estimate - 2 days
                2d
                Logged:
                Time Spent - Not Specified
                Not Specified

                  Structure Helper Panel