Kuali Rice Development
  1. Kuali Rice Development
  2. KULRICE-2948

Rename TARGET_PRIMARY_KEY column on certain KIM tables

    Details

    • Type: Improvement Improvement
    • Status: Closed Closed
    • Priority: Blocker Blocker
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.0
    • Component/s: Database, Development
    • Labels:
      None
    • Similar issues:
      KULRICE-4992Review and rename tables/columns in master database
      KULRICE-1519Rename KIM_NMSPCE_DLFT_ATTR_T.constraints.ddl to match table name
      KULRICE-6534Rename KREW_STYLE_T table to KRCR_STYLE_T, change it's id column to a string, and change StyleContract.getStyleId to StyleContract.getId() returning a String instead of a Long
      KULRICE-7166KRMS valid tables PKs and a few FKs need renaming
      KULRICE-8037Analysis: Rename KRAD database tables
      KULRICE-1481Add a new KIM_PERSONS_PRINCIPALS_T table
      KULRICE-3522Drop application URL from KIM attribute definition table
      KULRICE-7042Component name cannot be null on KIM type table
      KULRICE-5589Rename TypeContract and Type classes in Kim to CodedAttributeContract and CodedAttribute
      KULRICE-1539Refactor the KIM_GROUPS_PERSONS_T table to be named KIM_GROUPS_PRINCIPALS_T instead

      Description

      As per discussion with Jonathan, there is really no need for this column to be named this way anymore on these tables as these tables reference specific foreign keys now. The name change should be:

      KRIM_DLGN_MBR_ATTR_DATA_T.TARGET_PRIMARY_KEY -> DLGN_MBR_ID
      KRIM_GRP_ATTR_DATA_T.TARGET_PRIMARY_KEY -> GRP_ID
      KRIM_PERM_ATTR_DATA_T.TARGET_PRIMARY_KEY -> PERM_ID
      KRIM_ROLE_MBR_ATTR_DATA_T.TARGET_PRIMARY_KEY -> ROLE_MBR_ID
      KRIM_PND_ROLE_MBR_ATTR_DATA_MT.TARGET_PRIMARY_KEY -> ROLE_MBR_ID
      KRIM_RSP_ATTR_DATA_T.TARGET_PRIMARY_KEY -> RSP_ID

      A couple of things to remember here:

      1) This needs to be updated in all 4 of our dbs that require updating (rice094dba, rice094dev, rice094ci, ricekulcli094dba)
      2) We will also need to update any OJB and jpa mappings that point to these columns and any other files (probably just search the project for TARGET_PRIMARY_KEY)
      3) We will want to include the update sql in the updates-during-qa filder
      4) We will need to notify krice.dev@kuali.org as soon as this change is committed so that KFS will know that they need to update their database.
      5) We will want to make this change fairly soon since it involves database changes.

        Activity

        Hide
        Jeremy Hanson added a comment -

        What about the KRIM_PND_DLGN_MBR_ATTR_DATA_T table?

        do we want to update this to ROLE_MBR_ID as well?

        Show
        Jeremy Hanson added a comment - What about the KRIM_PND_DLGN_MBR_ATTR_DATA_T table? do we want to update this to ROLE_MBR_ID as well?
        Hide
        Eric Westfall added a comment -

        Hmm, i don't even see that table in the Rice database, do you? Do we need to get it from the KFS database? We may want to compare what we have with what they have as far as these tables go.

        Also, the column name there would be DLGN_MBR_ID i believe instead of ROLE_MBR_ID.

        Show
        Eric Westfall added a comment - Hmm, i don't even see that table in the Rice database, do you? Do we need to get it from the KFS database? We may want to compare what we have with what they have as far as these tables go. Also, the column name there would be DLGN_MBR_ID i believe instead of ROLE_MBR_ID.
        Hide
        Jeremy Hanson added a comment -

        Committed update that resolves this issue.

        Show
        Jeremy Hanson added a comment - Committed update that resolves this issue.
        Hide
        Eric Westfall added a comment -

        Bulk change of all Rice 1.0 issues to closed after public release.

        Show
        Eric Westfall added a comment - Bulk change of all Rice 1.0 issues to closed after public release.

          People

          • Assignee:
            Jeremy Hanson
            Reporter:
            Eric Westfall
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Time Tracking

              Estimated:
              Original Estimate - 2 hours
              2h
              Remaining:
              Remaining Estimate - 2 hours
              2h
              Logged:
              Time Spent - Not Specified
              Not Specified

                Structure Helper Panel