Uploaded image for project: 'Kuali Rice Development'
  1. Kuali Rice Development
  2. KULRICE-3000

Alter the system where DocumentType document handler url is being used and allow for that field to be empty on any given document type

    Details

    • Type: Task
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.0
    • Component/s: Development
    • Labels:
      None
    • Rice Module:
      KEW
    • Application Requirement:
      Rice

      Description

      The document handler URL had been a non-required field for a document type but many places in the system the field was assumed to be filled in. In many places NullPointerExceptions would have been thrown if a document type makes it into the system with no document handler url. We need to verify that those places are fixed so that if the document type has an empty document handler url that it will not get a URL link rendered.

      Two main places to check for this start with but are not limited to Document Search and Action List.

        Attachments

          Activity

          Hide
          chagstrom Chad Hagstrom added a comment -

          The only places I've found thus far that require modification are: KCBNotificationService at about line 63, and DocSearchDTO at line 191. I've changed these locations so that they now check if the doc handler URLs are blank before trying to use them. Also, although ClientAppDocHandlerRedirectAction.execute will throw an exception if the doc handler URL is blank, I discussed this with David and discovered that this behavior is intentional. In addition, I've removed the DocumentTypeBusinessRules and DocumentTypeBusinessRulesTest classes, since they won't be needed if blank doc handler URLs are now permissible. I believe I've fixed all of the necessary areas for this issue, so I'm ready to commit the fix as soon as the 1.0 branch is created on SVN.

          Show
          chagstrom Chad Hagstrom added a comment - The only places I've found thus far that require modification are: KCBNotificationService at about line 63, and DocSearchDTO at line 191. I've changed these locations so that they now check if the doc handler URLs are blank before trying to use them. Also, although ClientAppDocHandlerRedirectAction.execute will throw an exception if the doc handler URL is blank, I discussed this with David and discovered that this behavior is intentional. In addition, I've removed the DocumentTypeBusinessRules and DocumentTypeBusinessRulesTest classes, since they won't be needed if blank doc handler URLs are now permissible. I believe I've fixed all of the necessary areas for this issue, so I'm ready to commit the fix as soon as the 1.0 branch is created on SVN.
          Hide
          ewestfal Eric Westfall added a comment -

          Sounds good Chad. Go ahead and commit when you get over to that branch. Thanks.

          Show
          ewestfal Eric Westfall added a comment - Sounds good Chad. Go ahead and commit when you get over to that branch. Thanks.
          Hide
          ewestfal Eric Westfall added a comment -

          Bulk change of all Rice 1.0 issues to closed after public release.

          Show
          ewestfal Eric Westfall added a comment - Bulk change of all Rice 1.0 issues to closed after public release.

            People

            • Assignee:
              chagstrom Chad Hagstrom
              Reporter:
              delyea David Elyea
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: