Uploaded image for project: 'Kuali Rice Development'
  1. Kuali Rice Development
  2. KULRICE-3356

"Travel Account" field on Travel Request creation page is not working properly

    Details

    • Rice Team:
      QA

      Description

      On the Travel Request creation page, I've noticed several problems with the "Travel Account" field. First, if the user clicks the lookup link on the field and then either clicks "cancel" or returns a value from the lookup, the iframe shows a blank white page. This problem also occurs if the user opens the field's direct inquiry link with Javascript disabled and then clicks "close". I believe the problem lies with the fact that TravelDocumentAction2.refresh simply does nothing other than returning null, so this method needs to be implemented appropriately.

      Another problem with the "Travel Account" field is the list of accounts that it maintains. Whenever the user clicks "add", a new item is added to the list regardless of whether or not the text field is empty or contains invalid data. If the data is valid, the account appears to be properly added to the list; otherwise, a supposedly blank entry is added to the list, which can result in NullPointerException-induced HTTP 500 errors when saving or routing the document. In addition, there does not appear to be any way to remove list items once they have been placed in, and it is possible to include duplicate account entries.

        Attachments

          Activity

          Hide
          chagstrom Chad Hagstrom added a comment -

          I've fixed the "Travel Account" field's problems mentioned above, so it should be working as expected now. However, I discovered one other odd detail that I wanted to get feedback on before resolving this issue. I noticed that the Travel Request creation page includes a drop-down for choosing a particular account type code, yet the "Travel Account" field allows users to add travel accounts of any type to its list, regardless of whether or not they conform to the selected type code. Is this intentional, or is there supposed to be some sort of validation in place to ensure that the added travel accounts have the proper code? Or is the drop-down intended for some other purpose?

          Show
          chagstrom Chad Hagstrom added a comment - I've fixed the "Travel Account" field's problems mentioned above, so it should be working as expected now. However, I discovered one other odd detail that I wanted to get feedback on before resolving this issue. I noticed that the Travel Request creation page includes a drop-down for choosing a particular account type code, yet the "Travel Account" field allows users to add travel accounts of any type to its list, regardless of whether or not they conform to the selected type code. Is this intentional, or is there supposed to be some sort of validation in place to ensure that the added travel accounts have the proper code? Or is the drop-down intended for some other purpose?
          Hide
          ewestfal Eric Westfall added a comment -

          Hi Chad, I think the way it's implemented currently is fine. I'll go ahead and resolve this issue. Thanks!

          Show
          ewestfal Eric Westfall added a comment - Hi Chad, I think the way it's implemented currently is fine. I'll go ahead and resolve this issue. Thanks!
          Hide
          ewestfal Eric Westfall added a comment -

          Bulk change of all Rice 1.0 issues to closed after public release.

          Show
          ewestfal Eric Westfall added a comment - Bulk change of all Rice 1.0 issues to closed after public release.

            People

            • Assignee:
              chagstrom Chad Hagstrom
              Reporter:
              chagstrom Chad Hagstrom
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: