Kuali Rice Development
  1. Kuali Rice Development
  2. KULRICE-3575

when a new rule delegation is created, the document requeuer is never invoked

    Details

    • Type: Bug Fix Bug Fix
    • Status: Closed Closed
    • Priority: Critical Critical
    • Resolution: Fixed
    • Affects Version/s: 1.0.1
    • Fix Version/s: 1.0.1
    • Component/s: Development
    • Labels:
      None
    • Similar issues:
      KULRICE-4344 Rule Delegation - Create new delegation - Unable to determine Future Action Requests
      KULRICE-928can't create rule delegations
      KULRICE-4378Rule Delegation - Create new delegation - Error displaying more than one responsibility person and/or groups
      KULRICE-7239Routing Rules Delegation Create New Screen: Unable to add person in Persons section (or group in Group)
      KULRICE-3609Cancelling the creation of a new delegate rule results in a NullPointerException
      KULRICE-1318Rule re-versioning has some bugs when changing users in delegation rules using the Remove/Replace User function
      KULRICE-5582Rice Dev: Create new Routing Rule and Routing Rule Delegation bombs
      KULRICE-3344Parent Responsibility and NullPointerException problems on the "Delegate Routing Rule Creation" screen.
      KULRICE-2653Implement business rules for the new Routing Rule Delegation maintenance document
      KULRICE-763Rule DocHandler does not hide delegations when there are more than 20 of them
    • Rice Module:
      KEW

      Description

      in working on KULRICE-2182 I discovered that when a rule delegation is created, DocumentRequeuerImpl.requeueDocument(...) isn't invoked. I'm 99% sure it should be, since it is on changes to a rule delegation, include when a rule delegation is made inactive. Without document requeuing, the delegate won't get action items for pending action requests that they should now be responsible for.

        Issue Links

          Activity

          Hide
          Peter Giles (Inactive) added a comment -

          Committed fix + new test method.

          RuleServiceImpl.java:

          • now adding the responsibility from the delegate rule to the list passed in to ActionRequestService.updateActionRequestsForResponsibilityChange(...)
          • minor FindBugs cleanup

          MockDocumentRequeuerImpl.java: (added)

          • extends DocumentRequeuerImpl, but puts makes the ids for requeued documents accessible for verification in tests.

          AddRuleDelegationTest.java:

          • added testNewDelegationTriggersRequeue() test method

          OverrideTestSpringBeans.xml:

          • overrode enDocumentRequeuerService with MockDocumentRequeuerImpl
          Show
          Peter Giles (Inactive) added a comment - Committed fix + new test method. RuleServiceImpl.java: now adding the responsibility from the delegate rule to the list passed in to ActionRequestService.updateActionRequestsForResponsibilityChange(...) minor FindBugs cleanup MockDocumentRequeuerImpl.java: (added) extends DocumentRequeuerImpl, but puts makes the ids for requeued documents accessible for verification in tests. AddRuleDelegationTest.java: added testNewDelegationTriggersRequeue() test method OverrideTestSpringBeans.xml: overrode enDocumentRequeuerService with MockDocumentRequeuerImpl

            People

            • Assignee:
              Peter Giles (Inactive)
              Reporter:
              Peter Giles (Inactive)
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Structure Helper Panel