Uploaded image for project: 'Kuali Rice Development'
  1. Kuali Rice Development
  2. KULRICE-3711

When KR-WKFLW / Document / DOCUMENT_SEARCH_ROUTE_LOG_POPUP_IND is Y, route log link in doc search results is malformed

    Details

    • Rice Module:
      KEW
    • Application Requirement:
      KFS

      Description

      If the parameter KR-WKFLW / Document / DOCUMENT_SEARCH_ROUTE_LOG_POPUP_IND is set to "Y", then the Route Log URL ends up looking like this:

      <a href="../kew/RouteLog.do?routeHeaderId=3003" target="_new" target='_new' title=""><img alt="Route Log for Document" src="images/my_route_log.gif"/></a>

      ie, broken. Seems to have something to do with StandardDocumentSearchResultProcessor#getRouteLogFieldDisplayValue; I'm continuing research.

        Attachments

          Issue Links

            Activity

            Hide
            jksmith James Smith added a comment -

            The problem here isn't StandardDocumentSearchResultProcessor#getRouteLogFieldDisplayValue - that works perfectly. It's DocSearchCriteriaDTOLookupableHelperServiceImpl#performLookup (around line 379 or so) which uses a bad regex that grabs the target="_new" as well as the URL being linked to.

            Show
            jksmith James Smith added a comment - The problem here isn't StandardDocumentSearchResultProcessor#getRouteLogFieldDisplayValue - that works perfectly. It's DocSearchCriteriaDTOLookupableHelperServiceImpl#performLookup (around line 379 or so) which uses a bad regex that grabs the target="_new" as well as the URL being linked to.
            Hide
            jksmith James Smith added a comment -

            Okay, I've got a fix for this which uses a smarter regex. Should I commit?

            Show
            jksmith James Smith added a comment - Okay, I've got a fix for this which uses a smarter regex. Should I commit?
            Hide
            jksmith James Smith added a comment -

            Updated to show that KFS would evidently like this to part of the patch (see KFS-602)

            Show
            jksmith James Smith added a comment - Updated to show that KFS would evidently like this to part of the patch (see KFS-602 )
            Hide
            gtaylor Garey Taylor added a comment -

            Please commit when you get the chance.

            Thanks!

            Show
            gtaylor Garey Taylor added a comment - Please commit when you get the chance. Thanks!
            Hide
            jksmith James Smith added a comment -

            Done. Just as a note: DocSearchCriteriaDTOLookupableHelperServiceImpl#performLookup also had some other regexes to deal with <a> tags, but I believe those regexes to be smarter (slightly) about how to capture the information they're attempting to capture - so I didn't touch those. Thanks!

            Show
            jksmith James Smith added a comment - Done. Just as a note: DocSearchCriteriaDTOLookupableHelperServiceImpl#performLookup also had some other regexes to deal with <a> tags, but I believe those regexes to be smarter (slightly) about how to capture the information they're attempting to capture - so I didn't touch those. Thanks!

              People

              • Assignee:
                jksmith James Smith
                Reporter:
                jksmith James Smith
              • Votes:
                0 Vote for this issue
                Watchers:
                0 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: