Uploaded image for project: 'Kuali Rice Development'
  1. Kuali Rice Development
  2. KULRICE-3811

JPA - investigate the KFS and KC applications and make sure they don't have any custom OJB converters

    Details

    • Type: Task
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.0
    • Fix Version/s: 1.1-JPA
    • Component/s: Analysis, JPA
    • Labels:
      None

      Description

      investigate the KFS and KC applications and make sure they don't have any custom OJB converters. If they do, we will need to figure out how to handle them

      • we also need to look at the converters in Rice - there is one I believe that handles encryption/decryption of data from the database
      • we've already mentioned the boolean converter but there may be more

      we can remove the need to configure OJB platform as part of the configuration, we should try and make this easier for client applications so that they only need to configure their platform in one place in their rice configuration (right now they have to do it in two places)

        Attachments

          Issue Links

            Activity

            Hide
            ewestfal Eric Westfall added a comment -

            Set Ge as the assignee and added Dan as a watcher. I believe you guys were working on this as part of your conversion script work, correct?

            Show
            ewestfal Eric Westfall added a comment - Set Ge as the assignee and added Dan as a watcher. I believe you guys were working on this as part of your conversion script work, correct?
            Hide
            g1zhang Ge Zhang (Inactive) added a comment - - edited

            After a quick look at this issue, I found below customer converters in KFS and KC:

            For KFS(br:release-3-0-1-1):

            org.kuali.kfs.coa.util.OjbAccountActiveIndicatorConversion.java
            org.kuali.kfs.module.bc.util.OjbBCPositionActiveIndicatorConversion.java
            org.kuali.kfs.module.bc.util.OjbBudgetConstructionFTEConversion.java
            org.kuali.kfs.module.bc.util.OjbBudgetConstructionPercentTimeConversion.java
            org.kuali.kfs.module.bc.util.OjbPendingBCAppointmentFundingActiveIndicatorConversion.java
            org.kuali.kfs.sys.dataaccess.OjbCharBooleanFieldInverseConversion.java

            For KC(br: kc_project-rice-1-0-kc-upgrade-br)

            org.kuali.kra.award.contacts.UnitContactTypeConverter.java
            org.kuali.kra.award.contacts.UnitTypeConverter.java
            org.kuali.kra.infrastructure.OjbBudgetDecimalFieldConversion.java
            org.kuali.kra.infrastructure.OjbOnOffCampusFlagFieldConversion.java
            org.kuali.kra.infrastructure.OjbRateDecimalFieldConversion.java

            All these types either directly implement org.apache.ojb.broker.accesslayer.conversions.FieldConversion or extends rice converters, so it is pretty straight forward to fix them in the same way as we did for rice kns.util type converters

            About rice converters, besides the 11 converters in kns(already been handled), we still have:

            org.kuali.rice.core.util.OjbCharBooleanFieldConversionBase
            org.kuali.rice.ken.util.OjbCharBooleanConversion
            org.kuali.rice.kew.ojb.IdentityTypeConversion
            org.kuali.rice.kew.ojb.OjbCharBooleanConversion
            org.kuali.rice.kew.ojb.OjbEncryptDecryptFieldConversion

            We should have these done pretty quickly for KULRICE-3866. Below is the list of already converted conversion types, put it here for a complete reference

            OjbCharBooleanConversion------------------------------>org.hibernate.annotations.Type
            OjbCharBooleanFieldTFConversion-------------------->org.hibernate.annotations.Type
            OjbCharBooleanFieldAIConversion--------------------->org.kuali.rice.kns.util.HibernateKualiCharBooleanAIType
            OjbKualiHashFieldConversion--------------------------->org.kuali.rice.kns.util.HibernateKualiHashType
            OjbKualiEncryptDecryptFieldConversion-------------->org.kuali.rice.kns.util.HibernateKualiEncryptDecryptUserType
            OjbKualiDecimalFieldConversion----------------------->org.kuali.rice.kns.util.HibernateKualiDecimalFieldType
            OjbDecimalKualiPercentFieldConversion------------->org.kuali.rice.kns.util.HibernateKualiDecimalPercentFieldType
            OjbDecimalPercentageFieldConversion--------------->org.kuali.rice.kns.util.HibernateKualiDecimalPercentageFieldType
            OjbKualiIntegerFieldConversion-------------------------->org.kuali.rice.kns.util.HibernateKualiIntegerFieldType
            OjbKualiPercentFieldConversion------------------------->org.kuali.rice.kns.util.HibernateKualiIntegerPercentFieldType
            OjbKualiIntegerPercentageFieldConversion---------->org.kuali.rice.kns.util.HibernateKualiIntegerPercentageFieldType

            I think Dan will go head to finish KULRICE-3866(try another search to see if there is something else left), and I will take care KFS and KC converters after talking to their team to see if there is something else

            Show
            g1zhang Ge Zhang (Inactive) added a comment - - edited After a quick look at this issue, I found below customer converters in KFS and KC: For KFS(br:release-3-0-1-1): org.kuali.kfs.coa.util.OjbAccountActiveIndicatorConversion.java org.kuali.kfs.module.bc.util.OjbBCPositionActiveIndicatorConversion.java org.kuali.kfs.module.bc.util.OjbBudgetConstructionFTEConversion.java org.kuali.kfs.module.bc.util.OjbBudgetConstructionPercentTimeConversion.java org.kuali.kfs.module.bc.util.OjbPendingBCAppointmentFundingActiveIndicatorConversion.java org.kuali.kfs.sys.dataaccess.OjbCharBooleanFieldInverseConversion.java For KC(br: kc_project-rice-1-0-kc-upgrade-br) org.kuali.kra.award.contacts.UnitContactTypeConverter.java org.kuali.kra.award.contacts.UnitTypeConverter.java org.kuali.kra.infrastructure.OjbBudgetDecimalFieldConversion.java org.kuali.kra.infrastructure.OjbOnOffCampusFlagFieldConversion.java org.kuali.kra.infrastructure.OjbRateDecimalFieldConversion.java All these types either directly implement org.apache.ojb.broker.accesslayer.conversions.FieldConversion or extends rice converters, so it is pretty straight forward to fix them in the same way as we did for rice kns.util type converters About rice converters, besides the 11 converters in kns(already been handled), we still have: org.kuali.rice.core.util.OjbCharBooleanFieldConversionBase org.kuali.rice.ken.util.OjbCharBooleanConversion org.kuali.rice.kew.ojb.IdentityTypeConversion org.kuali.rice.kew.ojb.OjbCharBooleanConversion org.kuali.rice.kew.ojb.OjbEncryptDecryptFieldConversion We should have these done pretty quickly for KULRICE-3866 . Below is the list of already converted conversion types, put it here for a complete reference OjbCharBooleanConversion------------------------------>org.hibernate.annotations.Type OjbCharBooleanFieldTFConversion-------------------->org.hibernate.annotations.Type OjbCharBooleanFieldAIConversion--------------------->org.kuali.rice.kns.util.HibernateKualiCharBooleanAIType OjbKualiHashFieldConversion--------------------------->org.kuali.rice.kns.util.HibernateKualiHashType OjbKualiEncryptDecryptFieldConversion-------------->org.kuali.rice.kns.util.HibernateKualiEncryptDecryptUserType OjbKualiDecimalFieldConversion----------------------->org.kuali.rice.kns.util.HibernateKualiDecimalFieldType OjbDecimalKualiPercentFieldConversion------------->org.kuali.rice.kns.util.HibernateKualiDecimalPercentFieldType OjbDecimalPercentageFieldConversion--------------->org.kuali.rice.kns.util.HibernateKualiDecimalPercentageFieldType OjbKualiIntegerFieldConversion-------------------------->org.kuali.rice.kns.util.HibernateKualiIntegerFieldType OjbKualiPercentFieldConversion------------------------->org.kuali.rice.kns.util.HibernateKualiIntegerPercentFieldType OjbKualiIntegerPercentageFieldConversion---------->org.kuali.rice.kns.util.HibernateKualiIntegerPercentageFieldType I think Dan will go head to finish KULRICE-3866 (try another search to see if there is something else left), and I will take care KFS and KC converters after talking to their team to see if there is something else
            Hide
            g1zhang Ge Zhang (Inactive) added a comment -

            Need update the status of this one in case I forget it, I have finihsed implementation of the JPA style converters 1.5 weeks, will check in the code when KFS/KRA update there lib to have rice-1.1.0 and JPA2.0/Hibernate on the class path. below is the list of work done:

            For KFS(jpa-refactoring br):
            org.kuali.kfs.coa.util.OjbAccountActiveIndicatorConversion: can directly be replaced by Hibernate yes_no type, the annotation is like:

            org.kuali.kfs.sys.dataaccess.HibernateKFSCharBoolenFieldInverseType: replaces OjbCharBooleanFieldInverseConversion
            org.kuali.kfs.sys.dataaccess.package-info.java : descibes type name for anootation

            org.kuali.kfs.module.bc.util.HibernateKFSBCPositionActiveIndicatiorType replaces OjbBCPositionActiveIndicatorConversion.java
            org.kuali.kfs.module.bc.util.HibernateKFSBudgetConstructionFTEType replaces OjbBudgetConstructionFTEConversion.java
            org.kuali.kfs.module.bc.util.HibernateKFSConstructionPercentTimeType replaces OjbBudgetConstructionPercentTimeConversion.java
            org.kuali.kfs.module.bc.util.HibernateKFSPendingBCAppointmentFundingActiveIndictorType replaces OjbPendingBCAppointmentFundingActiveIndicatorConversion.java
            org.kuali.kfs.module.bc.util.HibernateKFSTypeConversionUtil isa helper class
            org.kuali.kfs.module.bc.util.package-info.java : descibes type names for anootation

            For KRA(KC_Project-jpa-test br)

            org.kuali.kra.award.contacts.HibernateKRAUnitContatcTypeType replaces UnitContactTypeConverter.java
            org.kuali.kra.award.contacts.package-info.java : descibes type name for anootation

            org.kuali.kra.infrastructure.HibernateKRADecimaFiedType repalces OjbBudgetDecimalFieldConversion.java
            org.kuali.kra.infrastructure.HibernateKRAOnOffCampusFlagFieldType replaces OjbOnOffCampusFlagFieldConversion.java
            org.kuali.kra.infrastructure.HibernateKRARateDecimalFieldType repalces OjbRateDecimalFieldConversion.java
            org.kuali.kra.infrastructure.package-info.java : descibes type names for anootation

            Show
            g1zhang Ge Zhang (Inactive) added a comment - Need update the status of this one in case I forget it, I have finihsed implementation of the JPA style converters 1.5 weeks, will check in the code when KFS/KRA update there lib to have rice-1.1.0 and JPA2.0/Hibernate on the class path. below is the list of work done: For KFS(jpa-refactoring br): org.kuali.kfs.coa.util.OjbAccountActiveIndicatorConversion: can directly be replaced by Hibernate yes_no type, the annotation is like: org.kuali.kfs.sys.dataaccess.HibernateKFSCharBoolenFieldInverseType: replaces OjbCharBooleanFieldInverseConversion org.kuali.kfs.sys.dataaccess.package-info.java : descibes type name for anootation org.kuali.kfs.module.bc.util.HibernateKFSBCPositionActiveIndicatiorType replaces OjbBCPositionActiveIndicatorConversion.java org.kuali.kfs.module.bc.util.HibernateKFSBudgetConstructionFTEType replaces OjbBudgetConstructionFTEConversion.java org.kuali.kfs.module.bc.util.HibernateKFSConstructionPercentTimeType replaces OjbBudgetConstructionPercentTimeConversion.java org.kuali.kfs.module.bc.util.HibernateKFSPendingBCAppointmentFundingActiveIndictorType replaces OjbPendingBCAppointmentFundingActiveIndicatorConversion.java org.kuali.kfs.module.bc.util.HibernateKFSTypeConversionUtil isa helper class org.kuali.kfs.module.bc.util.package-info.java : descibes type names for anootation For KRA(KC_Project-jpa-test br) org.kuali.kra.award.contacts.HibernateKRAUnitContatcTypeType replaces UnitContactTypeConverter.java org.kuali.kra.award.contacts.package-info.java : descibes type name for anootation org.kuali.kra.infrastructure.HibernateKRADecimaFiedType repalces OjbBudgetDecimalFieldConversion.java org.kuali.kra.infrastructure.HibernateKRAOnOffCampusFlagFieldType replaces OjbOnOffCampusFlagFieldConversion.java org.kuali.kra.infrastructure.HibernateKRARateDecimalFieldType repalces OjbRateDecimalFieldConversion.java org.kuali.kra.infrastructure.package-info.java : descibes type names for anootation
            Hide
            g1zhang Ge Zhang (Inactive) added a comment -

            close it since the implementation was done

            Show
            g1zhang Ge Zhang (Inactive) added a comment - close it since the implementation was done

              People

              • Assignee:
                g1zhang Ge Zhang (Inactive)
                Reporter:
                gtaylor Garey Taylor
              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: