Kuali Rice Development
  1. Kuali Rice Development
  2. KULRICE-3908

Approve fails to clear out saved ad hoc route requests...

    Details

    • Type: Bug Fix Bug Fix
    • Status: Closed Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.0
    • Component/s: Development
    • Labels:
      None
    • Similar issues:
      KULRICE-1156ad hoc route for completion
      KULRICE-7842Ad Hoc Route for Completion recipient does not have the Approve action available in the Action Requested drop down field
      KULRICE-637Simple & Event Messages - should be able to Save, Cancel, Ad Hoc Route, Copy
      KULRICE-3718Allow Ad Hoc action requests on documents with no route nodes
      KULRICE-3603After a document is saved but before it is routed, the "Future Action Requests" tab on the doc's route log does not display any of the ad hoc requests
      KULRICE-14019Problem With Ad Hoc Group Request Additions
      KULRICE-13996Problems sending ad hoc group requests on KRAD documents
      KULRICE-13109AFT Failure DemoTravelAccountMaintenanceAdHocRecipientsPersonAft Invalid Ad Hoc Routing Person Network Id
      KULRICE-2417Permit Edoclite to allow ad-hoc workgroup routing.
      KULRICE-7864CONTRIB: do not ignore validation when ad hoc route for completion request is receiving positive action (complete, approve, blanket approve)
    • Rice Module:
      KNS, KEW

      Description

      Nor blanket approve nor disapprove, for that matter.

      Open a document, say a DI (I discovered this doing KFS work for AZ). Add a source and target accounting line and submit the document.

      The FO opens the document. They add an ad hoc route person request. They save the document. They approve the document.

      Unsuspecting ad hoc person request user opens document. They approve. They check action list. Document is back in their list. Why? Because the ad hoc route person was saved and never cleared from the db, so unless the request user opens that tab and deletes the request, they keep generating new requests to themselves.

      I'm guessing the solution would be to call DocumentServiceImpl#removeAdHocPersonsAndWorkgroups in approve, blanket approve, and disapprove, as is done for route, cancel, and sendAdHocRequests in that service. I just wanted to sanity check with someone before I coded that up (I'm happy to code up for Rice since I have to do that for UA's Rice fork anyway).

        Issue Links

          Activity

          Hide
          James Smith added a comment -

          Since I was assigned the KFS issue, I'll grab this one too. As far as I know, my proposed fix has been working seamlessly at UA.

          Show
          James Smith added a comment - Since I was assigned the KFS issue, I'll grab this one too. As far as I know, my proposed fix has been working seamlessly at UA.
          Hide
          James Smith added a comment -

          I'm guessing this should be applied to 1.1 since it's a KFS issue, right?

          Show
          James Smith added a comment - I'm guessing this should be applied to 1.1 since it's a KFS issue, right?
          Hide
          Garey Taylor added a comment -

          Yes, this should be a 1.1 fix. If it becomes an issue for them then we can patch a previous release.

          Thanks James!

          Show
          Garey Taylor added a comment - Yes, this should be a 1.1 fix. If it becomes an issue for them then we can patch a previous release. Thanks James!
          Hide
          James Smith added a comment -

          Great. So, for the record, I'm deleting ad hoc requests after:

          approve
          superUserApprove
          superUserCancel
          superUserDisapprove
          disapprove
          acknowledge
          blanketApprove
          clearFYI

          Show
          James Smith added a comment - Great. So, for the record, I'm deleting ad hoc requests after: approve superUserApprove superUserCancel superUserDisapprove disapprove acknowledge blanketApprove clearFYI
          Hide
          James Smith added a comment -

          This should be fixed now.

          Show
          James Smith added a comment - This should be fixed now.
          Hide
          Travis Schneeberger added a comment -

          attaching backported fix for 1.0.3.1 in case anyone is interested

          Show
          Travis Schneeberger added a comment - attaching backported fix for 1.0.3.1 in case anyone is interested

            People

            • Assignee:
              James Smith
              Reporter:
              James Smith
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Structure Helper Panel