Kuali Rice Development
  1. Kuali Rice Development
  2. KULRICE-392

fix page render issue on maintenance documents when errors are displayed

    Details

    • Type: Bug Fix Bug Fix
    • Status: Closed Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.9 General Development and Work
    • Fix Version/s: 0.9, KFS Release 2.0
    • Component/s: Development
    • Labels:
      None
    • Similar issues:
      KULRICE-3452Extra white area appears in Firefox when tabs display error messages
      KULRICE-7668Ajax Rendering of Lightbox doesn't block page
      KULRICE-3046Numerous issues with new Routing Rule maintenance document
      KULRICE-9218Components for pages not displayed not getting ids causes state issues
      KULRICE-12320Issues with person maintenance document
      KULRICE-9477Freemarker error with column calculation and submit of maintenance document
      KULRICE-5991View/Page Loading fixes - indicator and visual appearance during load
      KULRICE-3119Error messages at the top of the maintenance.do page do not display properly in IE
      KULRICE-494resolve page render issues when returning from multiple value lookup
      KULRICE-6862Person and Role documents stop rendering on edit
    • Application Requirement:
      KFS

      Description

      see linked issue

        Issue Links

          Activity

          Hide
          Aaron Godert (Inactive) added a comment -

          Should this be tagged with the PIIa fix version?

          Show
          Aaron Godert (Inactive) added a comment - Should this be tagged with the PIIa fix version?
          Hide
          Ailish Byrne added a comment -

          yup sorry - forgot about that in trying to be considerate about new versions do you just want me to worry about the kfs p2a version and ignore the .9?

          Show
          Ailish Byrne added a comment - yup sorry - forgot about that in trying to be considerate about new versions do you just want me to worry about the kfs p2a version and ignore the .9?
          Hide
          Ailish Byrne added a comment -

          crud - i just noticed i screwed it up further, cause you were changing from the .9 version i used to another

          Show
          Ailish Byrne added a comment - crud - i just noticed i screwed it up further, cause you were changing from the .9 version i used to another
          Hide
          Jerry Neal (Inactive) added a comment -

          Fixed. Basically, after errors it was not recognizing the JSP as maintenance because of a jstl var 'isMaintenance' was being incorrectly set. This var has two conditions:

          <c:set var="isMaintenance" value="$

          {KualiForm.class.name eq 'org.kuali.core.web.struts.form.KualiMaintenanceForm' || maintenanceViewMode eq Constants.PARAM_MAINTENANCE_VIEW_MODE_MAINTENANCE}

          " />

          The second conditions gets exported in the maintenance action execute. Since in this case there was pojo errors, processing stopped in the action before this request param could be exported. I assume that is why the comparison to the form class was added, but it was comparing against a kfs maintenance form which does not exist anymore. I changed the comparison to use the rice maintenance form, and all is good.

          Show
          Jerry Neal (Inactive) added a comment - Fixed. Basically, after errors it was not recognizing the JSP as maintenance because of a jstl var 'isMaintenance' was being incorrectly set. This var has two conditions: <c:set var="isMaintenance" value="$ {KualiForm.class.name eq 'org.kuali.core.web.struts.form.KualiMaintenanceForm' || maintenanceViewMode eq Constants.PARAM_MAINTENANCE_VIEW_MODE_MAINTENANCE} " /> The second conditions gets exported in the maintenance action execute. Since in this case there was pojo errors, processing stopped in the action before this request param could be exported. I assume that is why the comparison to the form class was added, but it was comparing against a kfs maintenance form which does not exist anymore. I changed the comparison to use the rice maintenance form, and all is good.
          Hide
          Ailish Byrne added a comment -

          jerry, just wanted to note that kymber attached a screenshot to the source cg issue that tells hows to replicate this on vendor

          Show
          Ailish Byrne added a comment - jerry, just wanted to note that kymber attached a screenshot to the source cg issue that tells hows to replicate this on vendor

            People

            • Assignee:
              Jerry Neal (Inactive)
              Reporter:
              Jerry Neal (Inactive)
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Due:
                Created:
                Updated:
                Resolved:

                Time Tracking

                Estimated:
                Original Estimate - 2 hours
                2h
                Remaining:
                Remaining Estimate - 2 hours
                2h
                Logged:
                Time Spent - Not Specified
                Not Specified

                  Structure Helper Panel