Details

    • Type: Bug Fix Bug Fix
    • Status: Closed Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 1.0, 1.0.1, 1.0.1.1
    • Fix Version/s: 1.0.3
    • Component/s: Database
    • Labels:
      None
    • Similar issues:
      KULRICE-3463Server distribution's impex tool is not packaged correctly
      KULRICE-3805Create 1.1.0 Database/Impex/CI
      KULRICE-10426Theme builder requires copy to temp directory
      KULRICE-3925Impex appears to be broken with Ant 1.8.0
      KULRICE-4333Typo in the Rice Server and binary distribution of impex-build.properties.sample
      KULRICE-231Provide Maven2 POM to rice-commons to build Rice Commons and allow other projects to use rice-commons through maven2
      KULRICE-6044Step 4 and 5 of createproject.groovy's "Instructions to complete Rice Template Install" are hard to follow for an inexperienced user
      KULRICE-228Clean up lib directory
      KULRICE-4950Fix impex tool so that it's not required to define import.torque.threads
      KULRICE-628Figure out how we are going to resource load are plugins better and build it
    • Rice Module:
      Rice Core
    • Application Requirement:
      Rice

      Description

      the build.xml for the database-impex load process has some inconsistent references to the intended location for outputing files. in some cases it uses the torque.sql.dir variable while in other places it routes output to a sub-directory of the schema directory. the load process works fine out of the box, because the torque.sql.dir default value is set to the same value as the hard coded references. however, changing the value of the torque.sql.dir variable can break the load. and worse, whether you change that variable value or not, the clean target is broken, as it will wipe out the database schema directory.

      it seems that it would be better to provide a more generalized output directory that is outside the context of the schema directory all together, and clearly the clean target needs attention.

      i'm attaching a recommended version for future releases. this version allows for the root of the output directory to be specified outside the context of the database schema directory, and it corrects the inconsistencies in the references to output directories.

      1. build.xml
        44 kB
        Garey Taylor
      2. build.xml
        36 kB
        tim carroll

        Activity

        Hide
        Garey Taylor added a comment -

        Chatted with Jonathan about this:

        1. It's fine to have a new output dir that contains both the sql and datasql directories
        2. The new directory var is called: "torque.output.dir"
        3. It will have a default value.
        <property name="torque.output.dir" value="$

        {torque.schema.dir}

        /output" />
        4. Need to have the clean target point to this new output dir. (as coded in the provided build.xml)
        5. This will be committed on the clover branch of Impex:
        https://test.kuali.org/svn/kul-cfg-dbs/branches/clover-integration/
        6. The new output dir needs to be setup with svn ignore

        Show
        Garey Taylor added a comment - Chatted with Jonathan about this: 1. It's fine to have a new output dir that contains both the sql and datasql directories 2. The new directory var is called: "torque.output.dir" 3. It will have a default value. <property name="torque.output.dir" value="$ {torque.schema.dir} /output" /> 4. Need to have the clean target point to this new output dir. (as coded in the provided build.xml) 5. This will be committed on the clover branch of Impex: https://test.kuali.org/svn/kul-cfg-dbs/branches/clover-integration/ 6. The new output dir needs to be setup with svn ignore
        Hide
        Garey Taylor added a comment -

        updated build.xml file

        Show
        Garey Taylor added a comment - updated build.xml file
        Hide
        Garey Taylor added a comment -

        Hi Jonathan,

        I created an updated version of the build.xml on the clover branch. It's attached to this jira. Couple questions:
        1. Should this go inside inittasks or outside:
        <path id="torque-classpath">
        <pathelement location="kuali-impextasks.jar" />
        <fileset dir="$

        {basedir}

        /..">
        <include name="lib/*.jar" />
        <include name="impex/lib/*.jar" />
        <include name="clover/lib/*.jar" />
        <include name="drivers/*.jar" />
        <include name="clover/plugins/*/.jar" />
        </fileset>
        </path>
        2. what is the sql loader on line 646,647
        3. Do I need to worry about these vars:
        $

        {post.import.workflow.xml.directory}

        $

        {post.import.liquibase.xml.directory}

        Also, could you look over the changes in general to make sure nothing is amiss.

        Thanks,

        Garey

        Show
        Garey Taylor added a comment - Hi Jonathan, I created an updated version of the build.xml on the clover branch. It's attached to this jira. Couple questions: 1. Should this go inside inittasks or outside: <path id="torque-classpath"> <pathelement location="kuali-impextasks.jar" /> <fileset dir="$ {basedir} /.."> <include name="lib/*.jar" /> <include name="impex/lib/*.jar" /> <include name="clover/lib/*.jar" /> <include name="drivers/*.jar" /> <include name="clover/plugins/* / .jar" /> </fileset> </path> 2. what is the sql loader on line 646,647 3. Do I need to worry about these vars: $ {post.import.workflow.xml.directory} $ {post.import.liquibase.xml.directory} Also, could you look over the changes in general to make sure nothing is amiss. Thanks, Garey
        Hide
        Jonathan Keller added a comment -

        1) It shouldn't matter. Either should define the classpath in time.
        2) That's an optimization added by Scott Gibson to use SQL Loader when available for enhanced performance.
        3) They need to stay around, but there are no standard values for them. Each project will need to set them appropriately.

        Show
        Jonathan Keller added a comment - 1) It shouldn't matter. Either should define the classpath in time. 2) That's an optimization added by Scott Gibson to use SQL Loader when available for enhanced performance. 3) They need to stay around, but there are no standard values for them. Each project will need to set them appropriately.
        Hide
        Garey Taylor added a comment -

        Committed changes to the clover-integration branch. Let me know if there are any issues.

        Note: torque.output.dir.2 has no default.

        Show
        Garey Taylor added a comment - Committed changes to the clover-integration branch. Let me know if there are any issues. Note: torque.output.dir.2 has no default.

          People

          • Assignee:
            Garey Taylor
            Reporter:
            tim carroll (Inactive)
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Time Tracking

              Estimated:
              Original Estimate - 3 hours
              3h
              Remaining:
              Remaining Estimate - 3 hours
              3h
              Logged:
              Time Spent - Not Specified
              Not Specified

                Structure Helper Panel