Kuali Rice Development
  1. Kuali Rice Development
  2. KULRICE-4025

Direct inquiry does not work properly in some conditions

    Details

    • Type: Bug Fix Bug Fix
    • Status: Open Open
    • Priority: Major Major
    • Resolution: Unresolved
    • Affects Version/s: 1.0.1.1, KFS Release 3.0.1
    • Fix Version/s: Backlog
    • Component/s: Development
    • Labels:
    • Similar issues:
      KULRICE-8394Direct Inquiry view not working properly
      KULRICE-1579Direct inquiry links do not work on maintenance documents
      KULRICE-5707Direct inquiry empty check not working and cancel on lightbox not working
      KULRICE-3426in Responsibility lookup, none of the field direct inquiry image links work
      KULRICE-5304KualiInquirableImpl doesn't check relationship in both directions
      KULRICE-10568direct inquiry link fails when identifier has a dot expression
      KULRICE-12547Direct inquiry renders including properties not present on the view
      KULRICE-3356"Travel Account" field on Travel Request creation page is not working properly
      KULRICE-8803Inquiry bases logic on readonly for building inquiry or direct inquiry based on the readonly flag of the Inquiry widget, not the field it applies to
      KULRICE-2729The "Future Action Requests" tab on the Route Log does not work properly with a client application using "embedded" mode
    • Rice Module:
      KNS
    • Application Requirement:
      Rice
    • KAI Review Status:
      Not Required
    • KTI Review Status:
      Not Required

      Description

      The direct inquiry framework seems to have a few bugs.

      1) If the value the user has entered into a field is not uppercase, and the matching value in the database is upper case, it does not find any results. The forceUppercase on the field is not applied before sending to the lookup.
      2) If you have a multi-part key, the javascript alert doesn't give you any clue which field is missing a value.
      3) On extension object properties (and perhaps any sub-object of the main maintained object), if no value is entered in the field, the inquiry runs but leaves the field blank upon sending to the lookup. The system then retrieves all records from the related object's table and displays the first one.
      4) In the same situations as above, the direct inquiry link opens in the same window as the document, rather than a new pop-up window.

        Activity

        Hide
        Eric Westfall added a comment -

        The first one on our list here got completed prior to the code freeze, but 2-4 are still outstanding. Since this one is not critical, we are going to defer the remainder of the work on this issue.

        Show
        Eric Westfall added a comment - The first one on our list here got completed prior to the code freeze, but 2-4 are still outstanding. Since this one is not critical, we are going to defer the remainder of the work on this issue.
        Hide
        Jonathan Keller added a comment -

        For #2:

        Find a direct inquiry on a field which is part of a multi-part key (like an account in KFS where the PK is chartOfAccountsCode / accountNumber) If you click on the direct inquiry for the account, it will give you the JS alert about a field not being filled in, but will not tell you which field.

        For #3:

        Click on a direct inquiry lookup on a field that is part of an extension object. (propertyName: extension.somePropName) It seems that it does not properly copy the value of the field when building the inquiry link, so that the property is passed to the inquiry page on the URL but with a blank value.

        And Ge, per your email - deferring what can not be completed is fine. These were my own observations when working with the system and are not related to the KFS 4 release.

        Show
        Jonathan Keller added a comment - For #2: Find a direct inquiry on a field which is part of a multi-part key (like an account in KFS where the PK is chartOfAccountsCode / accountNumber) If you click on the direct inquiry for the account, it will give you the JS alert about a field not being filled in, but will not tell you which field. For #3: Click on a direct inquiry lookup on a field that is part of an extension object. (propertyName: extension.somePropName) It seems that it does not properly copy the value of the field when building the inquiry link, so that the property is passed to the inquiry page on the URL but with a blank value. And Ge, per your email - deferring what can not be completed is fine. These were my own observations when working with the system and are not related to the KFS 4 release.
        Hide
        Jonathan Keller added a comment -

        Also - on #4:

        Direct inquiry (and all inquiries) need to open in a new window. If they do not, you can lose your document or lookup since there is no navigation to return to the source page.

        Show
        Jonathan Keller added a comment - Also - on #4: Direct inquiry (and all inquiries) need to open in a new window. If they do not, you can lose your document or lookup since there is no navigation to return to the source page.
        Hide
        Ge Zhang (Inactive) added a comment -

        Thanks Jonathan very much for your input, it is very helpful. I think these issues could be fixed by tweaking around KualiInquiryAction, InquiryForm and the java scripts(if I find where they are)
        however, I can not repeat them inside rice(all inquires do pop up a window in rice), so I will try to repeat them in KFS, if you know which KFS direct inquiry doesn't pop up a window, please let me know, it will save me some time, thank you.

        Show
        Ge Zhang (Inactive) added a comment - Thanks Jonathan very much for your input, it is very helpful. I think these issues could be fixed by tweaking around KualiInquiryAction, InquiryForm and the java scripts(if I find where they are) however, I can not repeat them inside rice(all inquires do pop up a window in rice), so I will try to repeat them in KFS, if you know which KFS direct inquiry doesn't pop up a window, please let me know, it will save me some time, thank you.
        Hide
        Jonathan Keller added a comment -

        I don't really have way to check this in KFS as KFS doesn't have any extension objects. I found this on the UCD implementation. I think there are some extension objects now in the Rice sample application which you may be able to test against. If not, maybe there have been enough infrastructure changes between 1.0.1.1 and 1.0.3 that some of the issues I reported went away.

        Show
        Jonathan Keller added a comment - I don't really have way to check this in KFS as KFS doesn't have any extension objects. I found this on the UCD implementation. I think there are some extension objects now in the Rice sample application which you may be able to test against. If not, maybe there have been enough infrastructure changes between 1.0.1.1 and 1.0.3 that some of the issues I reported went away.

          People

          • Assignee:
            Unassigned
            Reporter:
            Jonathan Keller
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:

              Time Tracking

              Estimated:
              Original Estimate - 1 day
              1d
              Remaining:
              Remaining Estimate - 1 day
              1d
              Logged:
              Time Spent - Not Specified
              Not Specified

                Structure Helper Panel