I just took the simplest route to get the rewritten method to work under the simplest test case. Feel free to get rid of the try/catch/throw RuntimeExcetpion, but it'll require more changes in code that call that method.

Warren:
I guess you will like this: replacing throws Exception with throws IOException, SAXException, ParserConfigurationException, InvalidXmlException, actually the test case is waiting for a WorkflowException which is super class of InvalidXmlException.

It passed the test cases, please let me know if we need finer tuning on it, then I will check in the change.

finer Exception handling only throws IOException, SAXException, ParserConfigurationException which are the possible exceptions could be thrown in the method,, avoid throwing RuntimeException, so that DTOConverter.handleException can wrap it into WorkflowException and catchable by other callers.

Hey Ge,

I think as long as it throws any exception it'll be fine. When I rewrote the method, I made it throw a RuntimeException because I did not want to change a lot of rice code to catch other exceptions. Do whatever you feel is best regarding exceptions.

Right, throwing any checked exception is fine, because org.kuali.rice.kew.dto.DTOConverter.handleException() will wrap all checked exception into WorkflowException, and unchecked exception into RuntimrException in the immediate caller of this method.

Making it throwing finer checked exceptions is for making a better interface in case some other methods really need to check them in the future.

The change has been committed and passed the tests

Thanks