Uploaded image for project: 'Kuali Rice Development'
  1. Kuali Rice Development
  2. KULRICE-4555

Combine SimpleDocumentActionsWebService with WorkflowDocumentActionsService, review and approve the new contract for workflow services

    Details

    • Rice Module:
      KEW
    • KAI Review Status:
      Not Required
    • KTI Review Status:
      Review Completed

      Description

      There is no real reason to have two separate services for this purpose. Instead they should be combined into a single service (basically move the simple operations into WorkflowDocumentActionsService).

      However I think we can improve it beyond that. Currently the simple actions service provides for simple service calls to be invoked without passing all of the extra RouteHeaderDTO information which is passed into WorkflowDocumentActionsService. A better approach might be to have operations like the following:

      public RouteHeaderDTO approveAndUpdate(
      @WebParam(name = "docId") String docId,
      @WebParam(name = "principalId") String principalId,
      @WebParam(name = "annotation") String annotation,
      @WebParam(name = "routeHeaderUpdate") RouteHeaderUpdateDTO routeHeaderUpdate
      );

      In this case, RouteHeaderUpdateDTO would be optional but would allow for the updating of things like XML document content, document title, etc.

      Then for simple cases where updates did not need to be based and the result didn't need to be read we could have an operation like the following:

      public void approve(
      @WebParam(name = "docId") String docId,
      @WebParam(name = "principalId") String principalId,
      @WebParam(name = "annotation") String annotation
      );

      Then on the java client we can code WorkflowDocument so that it's smart enough to know which of these methods to call based on updates to the data stored in the WorkflowDocument by the client application.

      In general, I think that we will want to go through a joint effort to design the workflow document services so that they have all of the appropriate operations and provide the desired level of functionality. This should be done in conjunction with the KTI.

        Attachments

          Issue Links

            Activity

            Hide
            riceci Rice-CI User (Inactive) added a comment -

            Integrated in rice-trunk-nightly #110 (See http://ci.rice.kuali.org/job/rice-trunk-nightly/110/)
            KULRICE-4555, KULRICE-5210 - removing usage of RouteHeaderDTO where possible

            Show
            riceci Rice-CI User (Inactive) added a comment - Integrated in rice-trunk-nightly #110 (See http://ci.rice.kuali.org/job/rice-trunk-nightly/110/ ) KULRICE-4555 , KULRICE-5210 - removing usage of RouteHeaderDTO where possible
            Hide
            ewestfal Eric Westfall added a comment -

            I'm going to consider this item mostly complete for the document action sservice. I've created various todos about follow up items in a document and will create jiras from that later as needed to complete this work.

            Show
            ewestfal Eric Westfall added a comment - I'm going to consider this item mostly complete for the document action sservice. I've created various todos about follow up items in a document and will create jiras from that later as needed to complete this work.
            Hide
            riceci Rice-CI User (Inactive) added a comment -

            Integrated in rice-trunk-nightly #111 (See http://ci.rice.kuali.org/job/rice-trunk-nightly/111/)
            KULRICE-4555, KULRICE-5005, KULRICE-4553 - ensured that new KEW services are getting published properly to the bus
            KULRICE-4555, KULRICE-5230 - removed WorkflowDocumentActions completely, updated spring files so WorkflowDocumentActionsService is getting published properly. Implemented KSB apis to lookup services by name and application id.

            Show
            riceci Rice-CI User (Inactive) added a comment - Integrated in rice-trunk-nightly #111 (See http://ci.rice.kuali.org/job/rice-trunk-nightly/111/ ) KULRICE-4555 , KULRICE-5005 , KULRICE-4553 - ensured that new KEW services are getting published properly to the bus KULRICE-4555 , KULRICE-5230 - removed WorkflowDocumentActions completely, updated spring files so WorkflowDocumentActionsService is getting published properly. Implemented KSB apis to lookup services by name and application id.
            Hide
            ewestfal Eric Westfall added a comment -

            Setting KTI review status to "completed" as the review process is currently in progress. See http://fisheye.kuali.org/cru/rice-84

            Show
            ewestfal Eric Westfall added a comment - Setting KTI review status to "completed" as the review process is currently in progress. See http://fisheye.kuali.org/cru/rice-84
            Hide
            jcoltrin Jessica Coltrin (Inactive) added a comment -

            Closing since these items are now in the release notes.

            Show
            jcoltrin Jessica Coltrin (Inactive) added a comment - Closing since these items are now in the release notes.

              People

              • Assignee:
                ewestfal Eric Westfall
                Reporter:
                ewestfal Eric Westfall
              • Votes:
                0 Vote for this issue
                Watchers:
                0 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Time Tracking

                  Estimated:
                  Original Estimate - 4 days
                  4d
                  Remaining:
                  Remaining Estimate - 4 days
                  4d
                  Logged:
                  Time Spent - Not Specified
                  Not Specified