Details
-
Type:
Improvement
-
Status: Closed
-
Priority:
Critical
-
Resolution: Complete
-
Affects Version/s: None
-
Component/s: Analysis, Development, Version Compatibility
-
Labels:None
-
Rice Module:KEW
-
KAI Review Status:Not Required
-
KTI Review Status:Review Completed
Description
There is no real reason to have two separate services for this purpose. Instead they should be combined into a single service (basically move the simple operations into WorkflowDocumentActionsService).
However I think we can improve it beyond that. Currently the simple actions service provides for simple service calls to be invoked without passing all of the extra RouteHeaderDTO information which is passed into WorkflowDocumentActionsService. A better approach might be to have operations like the following:
public RouteHeaderDTO approveAndUpdate(
@WebParam(name = "docId") String docId,
@WebParam(name = "principalId") String principalId,
@WebParam(name = "annotation") String annotation,
@WebParam(name = "routeHeaderUpdate") RouteHeaderUpdateDTO routeHeaderUpdate
);
In this case, RouteHeaderUpdateDTO would be optional but would allow for the updating of things like XML document content, document title, etc.
Then for simple cases where updates did not need to be based and the result didn't need to be read we could have an operation like the following:
public void approve(
@WebParam(name = "docId") String docId,
@WebParam(name = "principalId") String principalId,
@WebParam(name = "annotation") String annotation
);
Then on the java client we can code WorkflowDocument so that it's smart enough to know which of these methods to call based on updates to the data stored in the WorkflowDocument by the client application.
In general, I think that we will want to go through a joint effort to design the workflow document services so that they have all of the appropriate operations and provide the desired level of functionality. This should be done in conjunction with the KTI.
Attachments
Issue Links
- is duplicated by
-
KULRICE-1288 Take another look at Simple Web Service API for KEW
-
- Closed
-
-
KULRICE-4662 Clean up KEW services
-
- Closed
-
- is related to
-
KULRICE-2374 Make sure that all KEW super user actions are available on WorkflowDocument
-
- Closed
-
Activity
Field | Original Value | New Value |
---|---|---|
Component/s | Version Compatibility [ 13202 ] |
Assignee | Eric Westfall [ ewestfal ] |
Original Estimate | 4 days [ 115200 ] | |
Remaining Estimate | 4 days [ 115200 ] |
Fix Version/s | 2.0.0-m6 [ 16287 ] |
Start Date | ||
Fix Date | 2012-07-11 [ set to sprint end date ] |
Link |
This issue is duplicated by |
Link |
This issue is duplicated by |
Link |
This issue is related to |
Rice Module | [KEW] |
Assignee | Eric Westfall [ ewestfal ] |
Assignee | Eric Westfall [ ewestfal ] |
Status | Open [ 1 ] | In Progress [ 3 ] |
Status | In Progress [ 3 ] | Resolved [ 5 ] |
Resolution | Complete [ 6 ] |
KTI Review Status | Pending Review | Review Completed |
Status | Resolved [ 5 ] | Closed [ 6 ] |
Workflow | custom [ 86358 ] | Copy of custom for rice [ 212209 ] |
Workflow | Copy of custom for rice [ 212209 ] | custom [ 221957 ] |
Workflow | custom [ 221957 ] | Rice Workflow [ 231705 ] |
Setting this one as pending KTI review because I'd like to have KTI review the propsoal for API consolidation/improvements/changes to workflow.