Kuali Rice Development
  1. Kuali Rice Development
  2. KULRICE-4555

Combine SimpleDocumentActionsWebService with WorkflowDocumentActionsService, review and approve the new contract for workflow services

    Details

    • Similar issues:
      KULRICE-5369Combine Group and GroupUpate services
      KULRICE-4551Expose new service methods in SimpleDocumentActionsWebService including Super User actions and Adhoc revocation
      KULRICE-4505Decide on and document guidelines for how service contracts, DTOs, and implementations should be versioned
      KULRICE-5230Add ability to fetch a service from the ServiceBus by a combination of service name and application id
      KULRICE-7523Deprecate KRMS DefinitionContracts, extend new Contracts
      KULRICE-2196Create new workflow user service which uses KIM APIs
      KULRICE-889New workflow API
      KULRICE-7573The standalone version of WorkflowDocumentActionsService should always be called when kew.mode is Thin or Remote
      KULRICE-8360Create a new basic authentication service
      KULRICE-1153add api methods to identify all the places a given user appears in workflow, to remove a user from workflow, and to replace a user in workflow
    • Rice Module:
      KEW
    • KAI Review Status:
      Not Required
    • KTI Review Status:
      Review Completed

      Description

      There is no real reason to have two separate services for this purpose. Instead they should be combined into a single service (basically move the simple operations into WorkflowDocumentActionsService).

      However I think we can improve it beyond that. Currently the simple actions service provides for simple service calls to be invoked without passing all of the extra RouteHeaderDTO information which is passed into WorkflowDocumentActionsService. A better approach might be to have operations like the following:

      public RouteHeaderDTO approveAndUpdate(
      @WebParam(name = "docId") String docId,
      @WebParam(name = "principalId") String principalId,
      @WebParam(name = "annotation") String annotation,
      @WebParam(name = "routeHeaderUpdate") RouteHeaderUpdateDTO routeHeaderUpdate
      );

      In this case, RouteHeaderUpdateDTO would be optional but would allow for the updating of things like XML document content, document title, etc.

      Then for simple cases where updates did not need to be based and the result didn't need to be read we could have an operation like the following:

      public void approve(
      @WebParam(name = "docId") String docId,
      @WebParam(name = "principalId") String principalId,
      @WebParam(name = "annotation") String annotation
      );

      Then on the java client we can code WorkflowDocument so that it's smart enough to know which of these methods to call based on updates to the data stored in the WorkflowDocument by the client application.

      In general, I think that we will want to go through a joint effort to design the workflow document services so that they have all of the appropriate operations and provide the desired level of functionality. This should be done in conjunction with the KTI.

        Issue Links

          Activity

          Eric Westfall made changes -
          Field Original Value New Value
          Component/s Version Compatibility [ 13202 ]
          Eric Westfall made changes -
          Assignee Eric Westfall [ ewestfal ]
          Eric Westfall made changes -
          Original Estimate 4 days [ 115200 ]
          Remaining Estimate 4 days [ 115200 ]
          Eric Westfall made changes -
          Fix Version/s 2.0.0-m6 [ 16287 ]
          Eric Westfall made changes -
          Start Date
          Fix Date 2012-07-11 [ set to sprint end date ]
          Eric Westfall made changes -
          Link This issue is duplicated by KULRICE-1288 [ KULRICE-1288 ]
          Eric Westfall made changes -
          Link This issue is duplicated by KULRICE-4662 [ KULRICE-4662 ]
          Eric Westfall made changes -
          Link This issue is related to KULRICE-2374 [ KULRICE-2374 ]
          Eric Westfall made changes -
          Rice Module [KEW]
          Eric Westfall made changes -
          Assignee Eric Westfall [ ewestfal ]
          Eric Westfall made changes -
          Assignee Eric Westfall [ ewestfal ]
          Eric Westfall made changes -
          Status Open [ 1 ] In Progress [ 3 ]
          Eric Westfall made changes -
          Status In Progress [ 3 ] Resolved [ 5 ]
          Resolution Complete [ 6 ]
          Eric Westfall made changes -
          KTI Review Status Pending Review Review Completed
          Jessica Coltrin (Inactive) made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          Shem Patterson (Inactive) made changes -
          Workflow custom [ 86358 ] Copy of custom for rice [ 212209 ]
          Shem Patterson (Inactive) made changes -
          Workflow Copy of custom for rice [ 212209 ] custom [ 221957 ]
          Shem Patterson (Inactive) made changes -
          Workflow custom [ 221957 ] Rice Workflow [ 231705 ]

            People

            • Assignee:
              Eric Westfall
              Reporter:
              Eric Westfall
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Time Tracking

                Estimated:
                Original Estimate - 4 days
                4d
                Remaining:
                Remaining Estimate - 4 days
                4d
                Logged:
                Time Spent - Not Specified
                Not Specified

                  Structure Helper Panel