Uploaded image for project: 'Kuali Rice Development'
  1. Kuali Rice Development
  2. KULRICE-4561

Indicate First Name and Last Name are required on Person document

    Details

    • Type: Bug Fix
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.0.0-b6, 2.0
    • Component/s: Development
    • Labels:
      None
    • Rice Module:
      KIM
    • Application Requirement:
      KFS
    • KAI Review Status:
      Not Required
    • KTI Review Status:
      Not Required

      Description

      I don't think you can add a person manually without completing these two fields on at least one entry in the contact section.

        Attachments

          Issue Links

            Activity

            Hide
            jcoltrin Jessica Coltrin (Inactive) added a comment -

            needed for KFS 5.0 (currently planned to go with Rice 2.0).

            Show
            jcoltrin Jessica Coltrin (Inactive) added a comment - needed for KFS 5.0 (currently planned to go with Rice 2.0).
            Hide
            jcoltrin Jessica Coltrin (Inactive) added a comment -

            double-tagging with 2.0.0-b3 for review.

            Show
            jcoltrin Jessica Coltrin (Inactive) added a comment - double-tagging with 2.0.0-b3 for review.
            Hide
            sonam Sona Sona (Inactive) added a comment -

            Waiting for functional input.

            Show
            sonam Sona Sona (Inactive) added a comment - Waiting for functional input.
            Hide
            jkneal Jerry Neal (Inactive) added a comment -

            Sona,

            Can you post your questions on this Jira?

            thanks,
            Jerry

            Show
            jkneal Jerry Neal (Inactive) added a comment - Sona, Can you post your questions on this Jira? thanks, Jerry
            Hide
            sonam Sona Sona (Inactive) added a comment -

            This is what I had found out earlier.
            The validation for name is actually not on individual name properties, but on the entire name itself. IdentityManagementPersonDocument requires at least one of name, affiliation, employee info (when affiliation type is employee), and only one default within multiple names, emails, affiliations etc. All these validations are hardcoded in IdentityManagementPersonDocumentRule.java

            Can we discuss as to the scope of work I need to do tomorrow. Do we want to move all these hard coded validations from Java to XML ? Right now the XML are not structured to do any group validations or rendering. The rendering of each group is handled in individual .tag files.

            I was also asked to find out if I could add a required indicator on the name section. This is something that can be done by adding it to the .tag file. But Affiliations also has the same issue. So does that also need to be changed.

            Show
            sonam Sona Sona (Inactive) added a comment - This is what I had found out earlier. The validation for name is actually not on individual name properties, but on the entire name itself. IdentityManagementPersonDocument requires at least one of name, affiliation, employee info (when affiliation type is employee), and only one default within multiple names, emails, affiliations etc. All these validations are hardcoded in IdentityManagementPersonDocumentRule.java Can we discuss as to the scope of work I need to do tomorrow. Do we want to move all these hard coded validations from Java to XML ? Right now the XML are not structured to do any group validations or rendering. The rendering of each group is handled in individual .tag files. I was also asked to find out if I could add a required indicator on the name section. This is something that can be done by adding it to the .tag file. But Affiliations also has the same issue. So does that also need to be changed.
            Hide
            sonam Sona Sona (Inactive) added a comment -

            I have made changes to show firstname and last name as required fields. Is there anything else that is expected?

            Thanks,
            -Sona

            Show
            sonam Sona Sona (Inactive) added a comment - I have made changes to show firstname and last name as required fields. Is there anything else that is expected? Thanks, -Sona
            Hide
            ddorsey Damon Dorsey added a comment -

            Not from my perspective, thanks!
            Damon

            Show
            ddorsey Damon Dorsey added a comment - Not from my perspective, thanks! Damon
            Hide
            jcoltrin Jessica Coltrin (Inactive) added a comment -

            Closing since this item is now in the 2.0 release notes.

            Show
            jcoltrin Jessica Coltrin (Inactive) added a comment - Closing since this item is now in the 2.0 release notes.

              People

              • Assignee:
                sonam Sona Sona (Inactive)
                Reporter:
                ddorsey Damon Dorsey
              • Votes:
                0 Vote for this issue
                Watchers:
                0 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: