Uploaded image for project: 'Kuali Rice Development'
  1. Kuali Rice Development
  2. KULRICE-4805

DocumentTypePermissionServiceImpl seems to build permission details incorrectly

    Details

    • Type: Bug Fix
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.0.3.1
    • Component/s: Development
    • Labels:
      None
    • Rice Module:
      KEW
    • KAI Review Status:
      Not Required
    • KTI Review Status:
      Not Required

      Description

      I'm not sure if this is a problem or not, but it seems inconsistent. Look at the code below. When the document is not in I or S state, it puts the route status label into the route node detail type. It seems like this is mixing things a little. Shouldn't it be using the current route node name like the buildDocumentTypePermissionDetails() method below it?

      protected AttributeSet buildRouteHeaderIdRoleDocumentTypeDocumentStatusQualifiers(DocumentType documentType, String documentStatus, String routeHeaderId) {
      AttributeSet qualifiers = new AttributeSet();
      qualifiers.put(KimAttributes.DOCUMENT_NUMBER, routeHeaderId);
      if (!StringUtils.isBlank(documentStatus)) {
      qualifiers.put(KEWConstants.DOCUMENT_STATUS_DETAIL, documentStatus);
      if (KEWConstants.ROUTE_HEADER_INITIATED_CD.equals(documentStatus) || KEWConstants.ROUTE_HEADER_SAVED_CD.equals(documentStatus))

      { qualifiers.put(KimAttributes.ROUTE_NODE_NAME, DocumentAuthorizerBase.PRE_ROUTING_ROUTE_NAME); }

      else

      { qualifiers.put(KimAttributes.ROUTE_NODE_NAME, CodeTranslator.getRouteStatusLabel(documentStatus)); }

      }

        Attachments

          Issue Links

            Activity

            jkeller Jonathan Keller created issue -
            jkeller Jonathan Keller made changes -
            Field Original Value New Value
            Link This issue discovered by KFSMI-6158 [ KFSMI-6158 ]
            Hide
            jcoltrin Jessica Coltrin (Inactive) added a comment -

            should be trivial, but needs KTI review.

            Show
            jcoltrin Jessica Coltrin (Inactive) added a comment - should be trivial, but needs KTI review.
            jcoltrin Jessica Coltrin (Inactive) made changes -
            Fix Version/s 1.0.3.1 [ 16120 ]
            jcoltrin Jessica Coltrin (Inactive) made changes -
            Assignee William Balderamos [ wbalderamos ]
            wbalderamos William Balderamos (Inactive) made changes -
            Status Open [ 1 ] In Progress [ 3 ]
            Hide
            wbalderamos William Balderamos (Inactive) added a comment -

            See revision #15488.

            Show
            wbalderamos William Balderamos (Inactive) added a comment - See revision #15488.
            Hide
            wbalderamos William Balderamos (Inactive) added a comment -

            See revision #15506.

            Show
            wbalderamos William Balderamos (Inactive) added a comment - See revision #15506.
            wbalderamos William Balderamos (Inactive) made changes -
            Status In Progress [ 3 ] Resolved [ 5 ]
            Resolution Fixed [ 1 ]
            Hide
            wbalderamos William Balderamos (Inactive) added a comment -

            Reopening for code review changes.

            Show
            wbalderamos William Balderamos (Inactive) added a comment - Reopening for code review changes.
            wbalderamos William Balderamos (Inactive) made changes -
            Resolution Fixed [ 1 ]
            Status Resolved [ 5 ] Reopened [ 4 ]
            Hide
            wbalderamos William Balderamos (Inactive) added a comment -

            See revision #15540.
            Also see code review http://fisheye.kuali.org/cru/rice-19.

            Show
            wbalderamos William Balderamos (Inactive) added a comment - See revision #15540. Also see code review http://fisheye.kuali.org/cru/rice-19 .
            Hide
            wbalderamos William Balderamos (Inactive) added a comment -

            After code review, changes look good.

            Show
            wbalderamos William Balderamos (Inactive) added a comment - After code review, changes look good.
            wbalderamos William Balderamos (Inactive) made changes -
            Status Reopened [ 4 ] Resolved [ 5 ]
            Resolution Fixed [ 1 ]
            jcoltrin Jessica Coltrin (Inactive) made changes -
            KTI Review Status Pending Review Not Required
            Hide
            jcoltrin Jessica Coltrin (Inactive) added a comment -

            closing since 1.0.3.1 is released.

            Show
            jcoltrin Jessica Coltrin (Inactive) added a comment - closing since 1.0.3.1 is released.
            jcoltrin Jessica Coltrin (Inactive) made changes -
            Status Resolved [ 5 ] Closed [ 6 ]
            spatterson Shem Patterson (Inactive) made changes -
            Workflow custom [ 88226 ] Copy of custom for rice [ 212418 ]
            spatterson Shem Patterson (Inactive) made changes -
            Workflow Copy of custom for rice [ 212418 ] custom [ 222166 ]
            spatterson Shem Patterson (Inactive) made changes -
            Workflow custom [ 222166 ] Rice Workflow [ 231914 ]

              People

              • Assignee:
                wbalderamos William Balderamos (Inactive)
                Reporter:
                jkeller Jonathan Keller
              • Votes:
                0 Vote for this issue
                Watchers:
                0 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: