Kuali Rice Development
  1. Kuali Rice Development
  2. KULRICE-4805

DocumentTypePermissionServiceImpl seems to build permission details incorrectly

    Details

    • Type: Bug Fix Bug Fix
    • Status: Closed Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.0.3.1
    • Component/s: Development
    • Labels:
      None
    • Similar issues:
      KULRICE-8252Permission check for super user tab seems to be using the wrong namespace
      KULRICE-4295useKimPermission not being checked on canBlanketApprove in DocumentTypePermissionServiceImpl
      KULRICE-7274Creating an Initiate Document permission with an incorrect documentTypeName detail results in exception
      KULRICE-6549Display of AuthorizationException messages seems incorrect
      KULRICE-7182Permission lookup by Attribute Value doesn't seem to work
      KULRICE-3490make assembly of permission details (e.g. in DocumentTypePermissionServiceImpl.buildDocumentTypePermissionDetails(...)) dynamic based on db config
      KULRICE-6513DataObjectMetaDataServiceImpl's areNotesSupported method implementation seems to be incorrect
      KULRICE-4151Permission and responsibility lookups don't seem to take nested roles into account
      KULRICE-10251Maintain KRMS Agenda permission has confusing and unused permission detail
      KULRICE-4302Rice's .classpath seems out of whack...
    • Rice Module:
      KEW
    • KAI Review Status:
      Not Required
    • KTI Review Status:
      Not Required

      Description

      I'm not sure if this is a problem or not, but it seems inconsistent. Look at the code below. When the document is not in I or S state, it puts the route status label into the route node detail type. It seems like this is mixing things a little. Shouldn't it be using the current route node name like the buildDocumentTypePermissionDetails() method below it?

      protected AttributeSet buildRouteHeaderIdRoleDocumentTypeDocumentStatusQualifiers(DocumentType documentType, String documentStatus, String routeHeaderId) {
      AttributeSet qualifiers = new AttributeSet();
      qualifiers.put(KimAttributes.DOCUMENT_NUMBER, routeHeaderId);
      if (!StringUtils.isBlank(documentStatus)) {
      qualifiers.put(KEWConstants.DOCUMENT_STATUS_DETAIL, documentStatus);
      if (KEWConstants.ROUTE_HEADER_INITIATED_CD.equals(documentStatus) || KEWConstants.ROUTE_HEADER_SAVED_CD.equals(documentStatus))

      { qualifiers.put(KimAttributes.ROUTE_NODE_NAME, DocumentAuthorizerBase.PRE_ROUTING_ROUTE_NAME); }

      else

      { qualifiers.put(KimAttributes.ROUTE_NODE_NAME, CodeTranslator.getRouteStatusLabel(documentStatus)); }

      }

        Issue Links

          Activity

          Jonathan Keller made changes -
          Field Original Value New Value
          Link This issue discovered by KFSMI-6158 [ KFSMI-6158 ]
          Jessica Coltrin (Inactive) made changes -
          Fix Version/s 1.0.3.1 [ 16120 ]
          Jessica Coltrin (Inactive) made changes -
          Assignee William Balderamos [ wbalderamos ]
          William Balderamos (Inactive) made changes -
          Status Open [ 1 ] In Progress [ 3 ]
          William Balderamos (Inactive) made changes -
          Status In Progress [ 3 ] Resolved [ 5 ]
          Resolution Fixed [ 1 ]
          William Balderamos (Inactive) made changes -
          Resolution Fixed [ 1 ]
          Status Resolved [ 5 ] Reopened [ 4 ]
          William Balderamos (Inactive) made changes -
          Status Reopened [ 4 ] Resolved [ 5 ]
          Resolution Fixed [ 1 ]
          Jessica Coltrin (Inactive) made changes -
          KTI Review Status Pending Review Not Required
          Jessica Coltrin (Inactive) made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          Shem Patterson (Inactive) made changes -
          Workflow custom [ 88226 ] Copy of custom for rice [ 212418 ]
          Shem Patterson (Inactive) made changes -
          Workflow Copy of custom for rice [ 212418 ] custom [ 222166 ]
          Shem Patterson (Inactive) made changes -
          Workflow custom [ 222166 ] Rice Workflow [ 231914 ]

            People

            • Assignee:
              William Balderamos (Inactive)
              Reporter:
              Jonathan Keller
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Structure Helper Panel