Kuali Rice Development
  1. Kuali Rice Development
  2. KULRICE-4812

cannot add a principal to a group when principal is already a non direct memeber of that group

    Details

    • Type: Bug Fix Bug Fix
    • Status: Closed Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.0
    • Fix Version/s: 2.0
    • Component/s: Development
    • Labels:
      None
    • Similar issues:
      KULRICE-8201Group lookup by principal returns groups where member is inactive
      KULRICE-4249RoleMemberLookupableHelperServiceImpl assumes Principals and groups in local database
      KULRICE-3927Group or Role Lookup fail when a principal does not exist
      KULRICE-1805Add groups and group role qualifications, principals and principal role qualifications, and role attributes to the Role inquiry
      KULRICE-13298Principal deleted when person document routes if user cannot modify entities
      KULRICE-9054Principal Name Field in Group Lookup Returning Inaccurate Results
      KULRICE-12694People Flow: Principal, Group and Role add causes exception
      KULRICE-5784Group, Role, and Principal update methods need to call "inactivate" methods when their "active" status is changed to inactive
      KULRICE-4225Role service impl assumes groups and principals are stored in the KIM database
      KULRICE-5521Rice Dev: Group Lookup bombs if Principal Name is added
    • Rice Module:
      KIM
    • KAI Review Status:
      Not Required
    • KTI Review Status:
      Not Required

      Description

      Assume the following:

      active groups: Foo and Bar
      active principal: Travis

      group Foo is a member of group Bar
      principal Travis is a member of group Bar

      this means that Travis is also considered to be a member of Foo through Foo's member ship to Bar - an non-direct member

      So in GroupUpdateServiceImpl.addPrincipalToGroup() because of this non-direct membership you cannot make Travis a direct member of Foo. Is this correct? It doesn't seem right but maybe there are implications in having the relationship in both places.

      Right now a unit test is also failing because of this. I'll attach a patch file that fixes this but the question still remains do we allow the membership even when a non-direct membership already exists?

        Issue Links

          Activity

          Hide
          Travis Schneeberger added a comment -

          Garey mentioned that this jira might be related to work you or Ge is working on.

          Show
          Travis Schneeberger added a comment - Garey mentioned that this jira might be related to work you or Ge is working on.
          Hide
          Jeremy Hanson added a comment - - edited

          I'm not sure this is a bug.

          I think it relates to this jira: KULRICE-4538

          We turned off circular group memberships to avoid infinite loops. Should this be allowed? Could it cause problems?

          Show
          Jeremy Hanson added a comment - - edited I'm not sure this is a bug. I think it relates to this jira: KULRICE-4538 We turned off circular group memberships to avoid infinite loops. Should this be allowed? Could it cause problems?
          Hide
          Jeremy Hanson added a comment -

          Ok, so looking at this closer, it probably isn't related to that jira, and is just a discrepancy between 1.0.3 and 1.1's GroupUpdateServiceImpls addPrincipalToGroup method. I'll update 1.1 and it should fix the issue.

          Show
          Jeremy Hanson added a comment - Ok, so looking at this closer, it probably isn't related to that jira, and is just a discrepancy between 1.0.3 and 1.1's GroupUpdateServiceImpls addPrincipalToGroup method. I'll update 1.1 and it should fix the issue.
          Hide
          Jessica Coltrin (Inactive) added a comment -

          Closing since these items are now in the release notes.

          Show
          Jessica Coltrin (Inactive) added a comment - Closing since these items are now in the release notes.

            People

            • Assignee:
              Jeremy Hanson
              Reporter:
              Travis Schneeberger
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Structure Helper Panel