Details

    • Type: Sub Task
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.0
    • Fix Version/s: 2.0
    • Component/s: Modularity
    • Labels:
      None
    • KAI Review Status:
      Not Required
    • KTI Review Status:
      Not Required

      Description

      In order to create new modules under kew,kim, kns, etc we need to move the existing test framework from those directories.

      So, create a new top level module called "test" and move all current test modules into test.

      There is a bit of core test infrastructure so we might want to structure the module as:

      test

      • src
      • kcb
      • ken
      • kew
      • kim
      • kns
      • ksb

      src will contain default test data like "DefaultSuiteTestDataKNS.sql" because that file is needed for all base tests.

        Attachments

          Activity

          Hide
          gtaylor Garey Taylor added a comment -

          In the KCB test module I had to rename TestData.java to KCBTestData.java.

          For some reason Maven 3, with the surefire plugin was pulling in tests matching:
          List of patterns (separated by commas) used to specify the tests that should be included in testing. When not specified and when the test parameter is not specified, the default includes will be */Test.java **/*Test.java **/*TestCase.java. This parameter is ignored if TestNG suiteXmlFiles are specified.

          Working fine with Maven 2.2.1.

          Ignoring the fact that in the top level pom we specify: <test.includes>**/*Test.java</test.includes>

          Should investigate this more later.

          Show
          gtaylor Garey Taylor added a comment - In the KCB test module I had to rename TestData.java to KCBTestData.java. For some reason Maven 3, with the surefire plugin was pulling in tests matching: List of patterns (separated by commas) used to specify the tests that should be included in testing. When not specified and when the test parameter is not specified, the default includes will be * /Test .java **/*Test.java **/*TestCase.java. This parameter is ignored if TestNG suiteXmlFiles are specified. Working fine with Maven 2.2.1. Ignoring the fact that in the top level pom we specify: <test.includes>**/*Test.java</test.includes> Should investigate this more later.
          Hide
          gtaylor Garey Taylor added a comment -

          moved impl/src/test/config to devtools/src/main/resources. I also had to update RiceInternalSuiteDataTestCase with new locations and the ability to pull from a jar.

          Show
          gtaylor Garey Taylor added a comment - moved impl/src/test/config to devtools/src/main/resources. I also had to update RiceInternalSuiteDataTestCase with new locations and the ability to pull from a jar.
          Hide
          gtaylor Garey Taylor added a comment -

          Created a new top level module test. Created a sub module impl. Moved impl/src/test to the new sub module.

          Show
          gtaylor Garey Taylor added a comment - Created a new top level module test. Created a sub module impl. Moved impl/src/test to the new sub module.
          Hide
          gtaylor Garey Taylor added a comment -

          I was going to hold off until tomorrow, but it turns out I had to move the ksb module to get the secure service tests to work. Because of my changes to the way we look for test config files it was looking for the ksb keystore in the wrong location. Moving the ksb into the test module should clear that up.

          Show
          gtaylor Garey Taylor added a comment - I was going to hold off until tomorrow, but it turns out I had to move the ksb module to get the secure service tests to work. Because of my changes to the way we look for test config files it was looking for the ksb keystore in the wrong location. Moving the ksb into the test module should clear that up.
          Hide
          gtaylor Garey Taylor added a comment -

          The KEW tests aren't working because the jettey server start is pointing at the wrong directory.
          KEWTestCase.java::getJettyServerRelativeWebappRoot();

          We need to find a better way to dealing with these resources.
          Maybe we can look in the resource and pull via a classpath:blah... the test would then just depend on the web war. Can i do that from a war?

          Show
          gtaylor Garey Taylor added a comment - The KEW tests aren't working because the jettey server start is pointing at the wrong directory. KEWTestCase.java::getJettyServerRelativeWebappRoot(); We need to find a better way to dealing with these resources. Maybe we can look in the resource and pull via a classpath:blah... the test would then just depend on the web war. Can i do that from a war?
          Hide
          gtaylor Garey Taylor added a comment -

          same for kns and kim

          Show
          gtaylor Garey Taylor added a comment - same for kns and kim
          Hide
          gtaylor Garey Taylor added a comment -

          This module has been created.

          Show
          gtaylor Garey Taylor added a comment - This module has been created.
          Hide
          jcoltrin Jessica Coltrin (Inactive) added a comment -

          Closing since these items are now in the release notes.

          Show
          jcoltrin Jessica Coltrin (Inactive) added a comment - Closing since these items are now in the release notes.

            People

            • Assignee:
              gtaylor Garey Taylor
              Reporter:
              gtaylor Garey Taylor
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Time Tracking

                Estimated:
                Original Estimate - 3 days
                3d
                Remaining:
                Remaining Estimate - 3 days
                3d
                Logged:
                Time Spent - Not Specified
                Not Specified