Kuali Rice Development
  1. Kuali Rice Development
  2. KULRICE-5077

Lookup - Conditional enabling of 'return value' causes issues with the Lookup result table alignment

    Details

    • Type: Bug Fix Bug Fix
    • Status: Closed Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.0.3.2
    • Component/s: Development
    • Security Level: Public (Public: Anyone can view)
    • Labels:
      None
    • Similar issues:
      KULRICE-5289Lookup - Conditional enabling of 'return value' causes issues with the Lookup result table alignment
      KULRICE-7223Multivalue lookup not returning results
      KULRICE-1195Multi value lookup tables
      KULRICE-10977Multi Value Lookup : Implement server side paging for both rich and non rich tables when data selected is not on current page
      KULRICE-5355Lookup - return values opens new tab, the return target is not set
      KULRICE-13942Rice 2.4 KRAD lookups are not fully compatible with Rice 2.3 client application quickfinders
      KULRICE-12517Demo jQuery Table Features Multi-value lookup does not return values
      KULRICE-8318Error on clicking 'return value' in lookup dialog
      KULRICE-5777Lookup does not return value in Firefox 7.
      KULRICE-11887Workflow Routing Rules Doc Type Lookup fails to return result
    • KAI Review Status:
      Not Required
    • KTI Review Status:
      Not Required

      Description

      In Kuali Coeus, we have requirements to enable the 'return value' column based on some condition. When we do that, the lookup results table alignment gets skewed.Pls see linked JIRA for screenshot of the alignment problem.

        Issue Links

          Activity

          Hide
          Chitra Chandran added a comment - - edited

          When we took a quick look, it looks like replacing the following snippet (line 212 to 217) from KualiLookup.jsp

          KualiLookup.jsp
          
          <c:if test="${KualiForm.formKey!='' && KualiForm.hideReturnLink!=true && !KualiForm.multipleValues && !empty KualiForm.backLocation}">
          	<c:if test="${row.rowReturnable}">
          	     <display:column class="infocell" property="returnUrl" media="html" title="Return Value"/>
          	</c:if>
          </c:if>
          

          with this one:

          KualiLookup.jsp
          <c:if test="${KualiForm.formKey!='' && KualiForm.hideReturnLink!=true && !KualiForm.multipleValues && !empty KualiForm.backLocation}">
          	<c:choose>
          	        <c:when test="${row.rowReturnable}">    
          	              <display:column class="infocell" media="html" title="Return Value">${row.returnUrl}</display:column>
          	        </c:when>
          	        <c:otherwise>
          	              <display:column class="infocell" media="html" title="Return Value">&nbsp;</display:column>
          		</c:otherwise>
          	</c:choose>
          </c:if>
          

          fixes the issue.

          Show
          Chitra Chandran added a comment - - edited When we took a quick look, it looks like replacing the following snippet (line 212 to 217) from KualiLookup.jsp KualiLookup.jsp <c: if test= "${KualiForm.formKey!='' && KualiForm.hideReturnLink!= true && !KualiForm.multipleValues && !empty KualiForm.backLocation}" > <c: if test= "${row.rowReturnable}" > <display:column class= "infocell" property= "returnUrl" media= "html" title= "Return Value" /> </c: if > </c: if > with this one: KualiLookup.jsp <c: if test= "${KualiForm.formKey!='' && KualiForm.hideReturnLink!= true && !KualiForm.multipleValues && !empty KualiForm.backLocation}" > <c:choose> <c:when test= "${row.rowReturnable}" > <display:column class= "infocell" media= "html" title= "Return Value" >${row.returnUrl}</display:column> </c:when> <c:otherwise> <display:column class= "infocell" media= "html" title= "Return Value" >&nbsp;</display:column> </c:otherwise> </c:choose> </c: if > fixes the issue.
          Hide
          James Renfro (Inactive) added a comment -

          I've committed the fix suggested at r20536 in the rice-release-1-0-3-2-br branch. Please review and verify that it addresses the issue in KC, and I'll merge into 2.0 and trunk.

          Show
          James Renfro (Inactive) added a comment - I've committed the fix suggested at r20536 in the rice-release-1-0-3-2-br branch. Please review and verify that it addresses the issue in KC, and I'll merge into 2.0 and trunk.
          Hide
          Rice-CI User (Inactive) added a comment -

          Integrated in rice-1.0.3.2-nightly #31 (See http://ci.rice.kuali.org/job/rice-1.0.3.2-nightly/31/)
          KULRICE-5077 : Committing Chitra's suggested fix

          Show
          Rice-CI User (Inactive) added a comment - Integrated in rice-1.0.3.2-nightly #31 (See http://ci.rice.kuali.org/job/rice-1.0.3.2-nightly/31/ ) KULRICE-5077 : Committing Chitra's suggested fix
          Hide
          Chitra Chandran added a comment -

          Fix verified against KC

          Show
          Chitra Chandran added a comment - Fix verified against KC
          Hide
          Rice-CI User (Inactive) added a comment -

          Integrated in rice-trunk-nightly #95 (See http://ci.rice.kuali.org/job/rice-trunk-nightly/95/)
          KULRICE-5289: merging fix from KULRICE-5077

          Show
          Rice-CI User (Inactive) added a comment - Integrated in rice-trunk-nightly #95 (See http://ci.rice.kuali.org/job/rice-trunk-nightly/95/ ) KULRICE-5289 : merging fix from KULRICE-5077
          Hide
          Jessica Coltrin (Inactive) added a comment -

          closing since 1.0.3.2 is released.

          Show
          Jessica Coltrin (Inactive) added a comment - closing since 1.0.3.2 is released.

            People

            • Assignee:
              Chitra Chandran
              Reporter:
              Chitra Chandran
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Time Tracking

                Estimated:
                Original Estimate - 0 minutes
                0m
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 15 minutes
                15m

                  Structure Helper Panel