Details

    • Type: Task
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.0
    • Component/s: Development
    • Security Level: Public (Public: Anyone can view)
    • Labels:
      None
    • Rice Module:
      KRAD
    • KAI Review Status:
      Not Required
    • KTI Review Status:
      Not Required

      Description

      Development the ad hoc recipients tag for documents (transactional and maintenance). This is the tab that follows the notes tag (before the route log).

      Here are some directions (rough, likely missing some details):

      1) In AdHocRoutePerson.xml, set the 'controlField' property for actionRequest and id attribute definitions (take a look at Note.xml or TravelAccount.xml for example)
      2) Likewise, set controlField property for attribute definitions in AdHocRouteWorkgroup.xml
      3) Likewise, set controlField property for namespaceCode and name attrite definitions in PersonDocumentGroup.xml
      4) Create 'AdHocActionRequestCodesValuesFinder' in org.kuali.rice.kns.lookup.keyvalues (impl module), for now just return the codes without any checks

      • See KualiDocumentActionBase#populateAdHodActionRequestCodes method for KNS logic and constants for keyvalues
      • Once the value finders are enhanced to take in the model, we can add the conditional logic necessary

      5) Create 'Group_DocumentAdHocRecipients' in UifGroupDefinitions.xml

      6) In UifViewPageDefinitions.xml, add the Group_DocumentAdHocRecipients group to the 'DocumentView' items list. Place before 'Group_DocumentRouteLog' and give order="40" (also adjust order on document route log group to 50), default open on accordion should be false

      7) Create DocumentViewHelperServiceImpl in org.kuali.rice.kns.uif.service.impl and override performAddLineValidation

      • If propertyName on collectionGroup parameter is equal to the ad hod roc person or group list, perform authorization and rule checks
      • KNS logic for checking authorization and business rules found in KualiDocumentActionBase, copy logic over to performAddLineValidation (will need a few tweaks)
      • In DocumentView bean definition, configure viewHelperServiceClassName to DocumentViewHelperServiceImpl classname
      • Change KualiMaintainableImpl to extend DocumentViewHelperServiceImpl instead of ViewHelperServiceImpl

      8) Test by going to 'Travel Account Maintenance (New)' in KRAD Testing channel

      • Verify layout and fields are similar to KNS (note there will be some styling differences, but that is ok)
      • Verify the 'Action Requested' field has the valid options in the select control
      • Verify lookups on Person and Name work
      • Verify add and delete actions work
      • Test routing a document and with an ad hoc route person and group, and verify they receive an approve request in routing (check route log)

      Note: The control property in the data dictionary is name 'controlField', and in the UIF dictionary is named 'control'. This is because we are supporting both the old (KNS) and new (KRAD) controls in the data dictionary for now

        Attachments

          Issue Links

            Activity

            Hide
            riceci Rice-CI User (Inactive) added a comment -

            Integrated in rice-trunk-nightly #91 (See http://ci.rice.kuali.org/job/rice-trunk-nightly/91/)
            KULRICE-5153 - Implement ad-hoc recipients tag for documents

            Show
            riceci Rice-CI User (Inactive) added a comment - Integrated in rice-trunk-nightly #91 (See http://ci.rice.kuali.org/job/rice-trunk-nightly/91/ ) KULRICE-5153 - Implement ad-hoc recipients tag for documents
            Hide
            jkneal Jerry Neal (Inactive) added a comment -

            Matt,

            Need to make a change on this, where we had this:

            Likewise, set controlField property for namespaceCode and name attrite definitions in PersonDocumentGroup.xml

            Instead of working with PersonDocumentGroup.xml, we need to add recipientName and recipientNamespaceCode attribute definitions to AdHocRouteWorkgroup.xml.
            These attribute definitions can be copied from DocGroup-groupName and DocGroup-namespaceCode then changing the property name and adding the controlDefinition.

            The reason for this change is PersonDocumentGroup will be removed.

            Show
            jkneal Jerry Neal (Inactive) added a comment - Matt, Need to make a change on this, where we had this: Likewise, set controlField property for namespaceCode and name attrite definitions in PersonDocumentGroup.xml Instead of working with PersonDocumentGroup.xml, we need to add recipientName and recipientNamespaceCode attribute definitions to AdHocRouteWorkgroup.xml. These attribute definitions can be copied from DocGroup-groupName and DocGroup-namespaceCode then changing the property name and adding the controlDefinition. The reason for this change is PersonDocumentGroup will be removed.
            Hide
            riceci Rice-CI User (Inactive) added a comment -

            Integrated in rice-trunk-nightly #94 (See http://ci.rice.kuali.org/job/rice-trunk-nightly/94/)
            KULRICE-5153 - Adding definitions to AdHocRouteWorkgroup.xml since PersonDocumentGroup.xml is going away.

            Show
            riceci Rice-CI User (Inactive) added a comment - Integrated in rice-trunk-nightly #94 (See http://ci.rice.kuali.org/job/rice-trunk-nightly/94/ ) KULRICE-5153 - Adding definitions to AdHocRouteWorkgroup.xml since PersonDocumentGroup.xml is going away.
            Hide
            riceci Rice-CI User (Inactive) added a comment -

            Integrated in rice-trunk-nightly #95 (See http://ci.rice.kuali.org/job/rice-trunk-nightly/95/)
            KULRICE-5153 - Minor adjustments to look at document form, not just maintenance form.

            Show
            riceci Rice-CI User (Inactive) added a comment - Integrated in rice-trunk-nightly #95 (See http://ci.rice.kuali.org/job/rice-trunk-nightly/95/ ) KULRICE-5153 - Minor adjustments to look at document form, not just maintenance form.
            Hide
            matthew.wuertz Matthew Wuertz (Inactive) added a comment -

            Add line needs to be looked into. We added other tasks to try to help complete this, but it still does not work currently.

            Show
            matthew.wuertz Matthew Wuertz (Inactive) added a comment - Add line needs to be looked into. We added other tasks to try to help complete this, but it still does not work currently.
            Hide
            jkneal Jerry Neal (Inactive) added a comment -

            Complete except needs some styling work

            Show
            jkneal Jerry Neal (Inactive) added a comment - Complete except needs some styling work
            Hide
            jcoltrin Jessica Coltrin (Inactive) added a comment -

            Closing since these items are now in the release notes.

            Show
            jcoltrin Jessica Coltrin (Inactive) added a comment - Closing since these items are now in the release notes.

              People

              • Assignee:
                matthew.wuertz Matthew Wuertz (Inactive)
                Reporter:
                jkneal Jerry Neal (Inactive)
              • Votes:
                0 Vote for this issue
                Watchers:
                0 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: