Kuali Rice Development
  1. Kuali Rice Development
  2. KULRICE-5183

alternate/additonal DisplayAttributeName implementation not honoring key values finders

    Details

    • Type: Improvement Improvement
    • Status: Closed Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.0.0-m6, 2.0
    • Component/s: Development
    • Security Level: Public (Public: Anyone can view)
    • Labels:
      None
    • Similar issues:
      KULRICE-10907Caching for key value finders
      KULRICE-4733Improve key values finder support
      KULRICE-7594Provide input field instance to key value finder method getKeyValues
      KULRICE-3405Add support for injecting a values finder object into ControlDefinition
      KULRICE-12037Newer Rice 2.3.x releases are ignoring a KRAD field's default value finder class
      KULRICE-13570Create Default Value Finder Class AFT
      KULRICE-12297KRAD - Need way to disable radio buttons defined by values finder
      KULRICE-918Need a way to add context to value finder classes
      KULRICE-7694input field assumes option value of type string
      KULRICE-2907state values finder should be sorted by description, not code
    • Rice Module:
      KRAD
    • KAI Review Status:
      Not Required
    • KTI Review Status:
      Not Required

      Description

      Part of the alternate/additional DisplayAttributeName implementation should account for key values finders.

        Issue Links

          Activity

          Hide
          Jerry Neal (Inactive) added a comment -

          Ran into exception that seems related to work:

          java.lang.ClassCastException: java.lang.Boolean cannot be cast to java.lang.String
          at org.kuali.rice.krad.uif.field.AttributeField.setAlternateAndAdditionalDisplayValue(AttributeField.java:318)
          at org.kuali.rice.krad.uif.field.AttributeField.performFinalize(AttributeField.java:183)

          This is coming from:

          if (!additionalValueSet && !alternateValueSet && optionsFinder != null){
          String fieldValue = (String)ObjectPropertyUtils.getPropertyValue(model, getBindingInfo().getBindingPath());
          /**

          • If the field value is empty, dont set it
            */
            if (fieldValue != null)
            Unknown macro: { String keyLabel = optionsFinder.getKeyLabel(fieldValue); if (StringUtils.isNotBlank(keyLabel)){ alternateDisplayValue = keyLabel; } }

          Probably need to get as object first and check for string type or do a to string.

          You can see this from the VendorMaintenance link.

          Show
          Jerry Neal (Inactive) added a comment - Ran into exception that seems related to work: java.lang.ClassCastException: java.lang.Boolean cannot be cast to java.lang.String at org.kuali.rice.krad.uif.field.AttributeField.setAlternateAndAdditionalDisplayValue(AttributeField.java:318) at org.kuali.rice.krad.uif.field.AttributeField.performFinalize(AttributeField.java:183) This is coming from: if (!additionalValueSet && !alternateValueSet && optionsFinder != null){ String fieldValue = (String)ObjectPropertyUtils.getPropertyValue(model, getBindingInfo().getBindingPath()); /** If the field value is empty, dont set it */ if (fieldValue != null) Unknown macro: { String keyLabel = optionsFinder.getKeyLabel(fieldValue); if (StringUtils.isNotBlank(keyLabel)){ alternateDisplayValue = keyLabel; } } Probably need to get as object first and check for string type or do a to string. You can see this from the VendorMaintenance link.
          Hide
          Venkat PremChandran (Inactive) added a comment -

          checked in all the changes as reviewed by Jerry, pending with KIM permission check for AttributeSecurity. Needs discussion before working on this one

          Show
          Venkat PremChandran (Inactive) added a comment - checked in all the changes as reviewed by Jerry, pending with KIM permission check for AttributeSecurity. Needs discussion before working on this one
          Hide
          Venkat PremChandran (Inactive) added a comment -

          Jerry - i just checked in the fix for the above ClassCastException issue

          Show
          Venkat PremChandran (Inactive) added a comment - Jerry - i just checked in the fix for the above ClassCastException issue
          Hide
          Rice-CI User (Inactive) added a comment -

          Integrated in rice-trunk-nightly #86 (See http://ci.rice.kuali.org/job/rice-trunk-nightly/86/)
          KULRICE-5183 - alternate and additional field fixes/changes as suggested by Jerry

          Show
          Rice-CI User (Inactive) added a comment - Integrated in rice-trunk-nightly #86 (See http://ci.rice.kuali.org/job/rice-trunk-nightly/86/ ) KULRICE-5183 - alternate and additional field fixes/changes as suggested by Jerry
          Hide
          Jessica Coltrin (Inactive) added a comment -

          Closing since this item is now in the 2.0 release notes.

          Show
          Jessica Coltrin (Inactive) added a comment - Closing since this item is now in the 2.0 release notes.

            People

            • Assignee:
              Venkat PremChandran (Inactive)
              Reporter:
              Scott Gibson (Inactive)
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Structure Helper Panel