Kuali Rice Development
  1. Kuali Rice Development
  2. KULRICE-5209

Add servicePath to all of our Kuali Rice services that we are publishing

    Details

    • Type: Improvement Improvement
    • Status: Closed Closed
    • Priority: Critical Critical
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.0.0-b1, 2.0
    • Security Level: Public (Public: Anyone can view)
    • Labels:
      None
    • Similar issues:
      KULRICE-2421Implement service paths for all of our internal Rice services
      KULRICE-5820Determine if we want to drop the "Soap" from the end of our service names
      KULRICE-2812Review services we are publishing as SOAP services, ensure we have everything we need published
      KULRICE-3428Review all services published from each module and determine which should be exported to the bus under which run modes (local, embedded, remote)
      KULRICE-6995Add support for "fluent" builders to Kuali Rice apis
      KULRICE-4531Improve our use of namespaces for KimTypeServices, get rid of deprecated methods on KimCommonUtils
      KULRICE-2764Deploy Rice standalone server to our test environments
      KULRICE-4649Add support for publishing services with a pre-existing wsdl
      KULRICE-4496Speed Test: Soap vs java serialization for our remoted services
      KULRICE-4931Execute a review of all libraries and version in Kuali Rice 2.0
    • Rice Module:
      KSB, KNS, KEW, KEN, KCB, KIM, KRMS
    • KAI Review Status:
      Not Required
    • KTI Review Status:
      Not Required

      Description

      The service path should be based off the module name and version, so instead of publishing a service at an endpoint url like the following:

      http://rice.kuali.org/remoting/serviceRegistrySoap

      It would instead be published under:

      http://rice.kuali.org/remoting/ksb/v2_0/serviceRegistrySoap

      The later part of this ("ksb/v2_0") matches the same suffix that should be used on the actual namespace portion of the service in the registry.

        Activity

        Hide
        Eric Westfall added a comment -

        Escalating priority on this one to critical.

        Show
        Eric Westfall added a comment - Escalating priority on this one to critical.
        Hide
        Eric Westfall added a comment -

        There are some problems with this implementation as Aaron encountered, the way this was implemented was to default the servicePath inside of AbstractServiceDefinition based on parameters passed for namespace and serviceVersion. The serviceVersion matches the version in the Rice pom (for the Rice service) so this is kind of a problem as we want the endpoint url to remain stable across minor/patch/etc versions. Also, if there version and namespace weren't specified you'd end up with services names with "unspecifiedNamespace/unspecifiedVersion" in their endpoint url.

        Aaron addressed this by patching AbstractServiceDefinition so that it only includes namespace and version in the servicePath if they are specified. Though we still end up with the version number i mentioned before.

        I'm going to roll back the changes that Travis made on this issue originally and reimplement this in our rice spring files so that we construct the service path that we want and inject it into the SoapServiceDefinition. I'll probably declare a parent spring bean for these purposes as well.

        Show
        Eric Westfall added a comment - There are some problems with this implementation as Aaron encountered, the way this was implemented was to default the servicePath inside of AbstractServiceDefinition based on parameters passed for namespace and serviceVersion. The serviceVersion matches the version in the Rice pom (for the Rice service) so this is kind of a problem as we want the endpoint url to remain stable across minor/patch/etc versions. Also, if there version and namespace weren't specified you'd end up with services names with "unspecifiedNamespace/unspecifiedVersion" in their endpoint url. Aaron addressed this by patching AbstractServiceDefinition so that it only includes namespace and version in the servicePath if they are specified. Though we still end up with the version number i mentioned before. I'm going to roll back the changes that Travis made on this issue originally and reimplement this in our rice spring files so that we construct the service path that we want and inject it into the SoapServiceDefinition. I'll probably declare a parent spring bean for these purposes as well.
        Hide
        Eric Westfall added a comment -

        Work for this has been completed and committed, endpoint urls are now getting generated in the proper form. I also ran the SOAPServiceTest and RESTServiceTest (the test Aaron indicated were having problems) and they should succeed now.

        Show
        Eric Westfall added a comment - Work for this has been completed and committed, endpoint urls are now getting generated in the proper form. I also ran the SOAPServiceTest and RESTServiceTest (the test Aaron indicated were having problems) and they should succeed now.
        Hide
        Rice-CI User (Inactive) added a comment -

        Integrated in rice-trunk-nightly #217 (See http://ci.rice.kuali.org/job/rice-trunk-nightly/217/)
        KULRICE-5209 - moved BlanketApprovalOrchestrationQueueImpl to the appropriate package
        KULRICE-5209 - BlanketApproveProcessor to BlanketApprovalOrchestrationQueueImpl
        KULRICE-5209 - improved javadoc on BlanketApproveProcessor
        KULRICE-5209 - refactored and fixed servicePath issues

        Show
        Rice-CI User (Inactive) added a comment - Integrated in rice-trunk-nightly #217 (See http://ci.rice.kuali.org/job/rice-trunk-nightly/217/ ) KULRICE-5209 - moved BlanketApprovalOrchestrationQueueImpl to the appropriate package KULRICE-5209 - BlanketApproveProcessor to BlanketApprovalOrchestrationQueueImpl KULRICE-5209 - improved javadoc on BlanketApproveProcessor KULRICE-5209 - refactored and fixed servicePath issues
        Hide
        Jessica Coltrin (Inactive) added a comment -

        Closing since these items are now in the release notes.

        Show
        Jessica Coltrin (Inactive) added a comment - Closing since these items are now in the release notes.

          People

          • Assignee:
            Eric Westfall
            Reporter:
            Eric Westfall
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Time Tracking

              Estimated:
              Original Estimate - 1 day
              1d
              Remaining:
              Remaining Estimate - 1 day
              1d
              Logged:
              Time Spent - Not Specified
              Not Specified

                Structure Helper Panel