Kuali Rice Development
  1. Kuali Rice Development
  2. KULRICE-5256

Maintenance Docs - Fix issues with show/hide inactive rows

    Details

    • Type: Bug Fix Bug Fix
    • Status: Closed Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.0.0-m6, 2.0
    • Fix Version/s: 2.0.0-m6, 2.0
    • Component/s: Development
    • Security Level: Public (Public: Anyone can view)
    • Labels:
      None
    • Similar issues:
      KULRICE-4235Show Inactive link blows up on maintenance documents (methodToCall violation)
      KULRICE-9352Show/hide active rows on a collection doesn't work in the inquiry view
      KULRICE-9159Show/hide active rows on a collection doesn't work
      KULRICE-1102bugs with show hide active/inactive
      KULRICE-7637show inactive / hide inactive button on subtab is not working correctly.
      KULRICE-9706Create or identify Smoke Test that verifies show/hide inactive lines
      KULRICE-10641Maintenance document missing show/hide inactive button when collection implements Inactivatable
      KULRICE-6414Label for collection field does not show/hide correctly with progressive disclosure or refresh
      KULRICE-4771Show/Hide buttons affect incorrect rows on Inquiry with multiple collections
      KULRICE-13346Create AFT for Maintenance document toggling active/inactive button.
    • Rice Module:
      KRAD
    • KAI Review Status:
      Not Required
    • KTI Review Status:
      Not Required

      Description

      Show/hide inactive rows on collections not working yet.

      See the book maintenance document for examples of collections that implement Inactivatable

      Relevant code:

      CollectionGroup#

      private boolean showInactive;
      private CollectionFilter activeCollectionFilter;

      UifControllerBase#toggleInactiveRecordDisplay

      UifFieldDefinitions

      <bean id="ActionField_ShowInactive" parent="ActionField_SmallSecondary" p:methodToCall="toggleInactiveRecordDisplay"
      p:actionLabel="show inactive" p:clientSideJs="toggleInactiveRecordDisplay('

      {@#component.context['collectionGroup'].id}', true);"/>

      <bean id="ActionField_HideInactive" parent="ActionField_SmallSecondary" p:methodToCall="toggleInactiveRecordDisplay"
      p:actionLabel="hide inactive" p:clientSideJs="toggleInactiveRecordDisplay('{@#component.context['collectionGroup'].id}

      ', false);"/>

      core.js

      toggleInactiveRecordDisplay

        Activity

        Hide
        Jerry Neal (Inactive) added a comment -

        Also, there is some special logic that needs to be implemented. For example, a new collection line cannot be hidden. This brings up
        the issue of how to identify a new collection line for non-business objects. There are some others as well. See InactiveRecordsHidingUtils
        in KNS for details. This logic can be implemented in MaintenanceActiveCollectionFilter. Can't remember exactly what all missing, for sure the
        new collection line check. We will also need to do this check for delete line.

        Show
        Jerry Neal (Inactive) added a comment - Also, there is some special logic that needs to be implemented. For example, a new collection line cannot be hidden. This brings up the issue of how to identify a new collection line for non-business objects. There are some others as well. See InactiveRecordsHidingUtils in KNS for details. This logic can be implemented in MaintenanceActiveCollectionFilter. Can't remember exactly what all missing, for sure the new collection line check. We will also need to do this check for delete line.
        Hide
        Samuel Holtzkampf (Inactive) added a comment -

        Look into adding option to hide the Show Inactive button.

        Show
        Samuel Holtzkampf (Inactive) added a comment - Look into adding option to hide the Show Inactive button.
        Hide
        Samuel Holtzkampf (Inactive) added a comment -

        Added flag to hide the show/hide inactive button. Also only display button on Edit doc and Inquiries, not on New doc or Lookup results.

        Show
        Samuel Holtzkampf (Inactive) added a comment - Added flag to hide the show/hide inactive button. Also only display button on Edit doc and Inquiries, not on New doc or Lookup results.
        Hide
        Rice-CI User (Inactive) added a comment -

        Integrated in rice-trunk-nightly #115 (See http://ci.rice.kuali.org/job/rice-trunk-nightly/115/)
        KULRICE-5256 : Fix show/hide inactive rows on collections

        Show
        Rice-CI User (Inactive) added a comment - Integrated in rice-trunk-nightly #115 (See http://ci.rice.kuali.org/job/rice-trunk-nightly/115/ ) KULRICE-5256 : Fix show/hide inactive rows on collections
        Hide
        Rice-CI User (Inactive) added a comment -

        Integrated in rice-trunk-nightly #128 (See http://ci.rice.kuali.org/job/rice-trunk-nightly/128/)
        KULRICE-5256 : Default the showHideInactiveButton flag to true.

        Show
        Rice-CI User (Inactive) added a comment - Integrated in rice-trunk-nightly #128 (See http://ci.rice.kuali.org/job/rice-trunk-nightly/128/ ) KULRICE-5256 : Default the showHideInactiveButton flag to true.
        Hide
        Jessica Coltrin (Inactive) added a comment -

        Closing since this item is now in the 2.0 release notes.

        Show
        Jessica Coltrin (Inactive) added a comment - Closing since this item is now in the 2.0 release notes.

          People

          • Assignee:
            Samuel Holtzkampf (Inactive)
            Reporter:
            Jerry Neal (Inactive)
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Structure Helper Panel