Uploaded image for project: 'Kuali Rice Development'
  1. Kuali Rice Development
  2. KULRICE-5284

Maintenance Docs - Add option for message when line is deleted

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.5
    • Security Level: Public (Public: Anyone can view)
    • Labels:
      None
    • Rice Module:
      KRAD
    • Sprint:
      Core 2.5.0-m4 Sprint 2
    • KAI Review Status:
      Not Required
    • KTI Review Status:
      Not Required

      Description

      Currently when a collection line is deleted it is removed from the view, likewise when a line is added
      the old line is just blank fields. Give option to display a message on each side instead.

        Attachments

          Issue Links

            Activity

            Hide
            kbtaylor Kristina Taylor (Inactive) added a comment -

            The mockup is very helpful, thank you! Pagination is optional but can be there. If the capability for adding a message at the top of the collection is not there, we can talk to Jerry to add it. I will ask him if this is already possible or if we need to do some work to make it possible.

            Show
            kbtaylor Kristina Taylor (Inactive) added a comment - The mockup is very helpful, thank you! Pagination is optional but can be there. If the capability for adding a message at the top of the collection is not there, we can talk to Jerry to add it. I will ask him if this is already possible or if we need to do some work to make it possible.
            Hide
            kbtaylor Kristina Taylor (Inactive) added a comment - - edited

            From Jerry:

            The ability to have messages is present. You just add error, info, or warning message to the GlobalVariables.getMessageMap(), and associate it with the ID of the collection group. We will need to add functionality to the maintenance framework for tracking which records have been deleted, or compare the lists (old and new) for each request and build the messages.

            I would question the ‘Undo delete’ link on the message. That is increasing the scope and is not something they can currently do (they can just cancel the document).

            I agree with Jerry on the increase of scope for undo, so I have created KULRICE-12837 to handle that as an improvement. It was not possible in the KNS and thus is not an equivalency item.

            As far as solving the issue, I think the message only has to be there immediately after the deletion is done, so we may not have to track records or compare lists as Jerry suggests. Again, this issue will not include the undo action, so only the message has to be included.

            Show
            kbtaylor Kristina Taylor (Inactive) added a comment - - edited From Jerry: The ability to have messages is present. You just add error, info, or warning message to the GlobalVariables.getMessageMap(), and associate it with the ID of the collection group. We will need to add functionality to the maintenance framework for tracking which records have been deleted, or compare the lists (old and new) for each request and build the messages. I would question the ‘Undo delete’ link on the message. That is increasing the scope and is not something they can currently do (they can just cancel the document). I agree with Jerry on the increase of scope for undo, so I have created KULRICE-12837 to handle that as an improvement. It was not possible in the KNS and thus is not an equivalency item. As far as solving the issue, I think the message only has to be there immediately after the deletion is done, so we may not have to track records or compare lists as Jerry suggests. Again, this issue will not include the undo action, so only the message has to be included.
            Hide
            shahess Shannon Hess added a comment - - edited

            Conversation with Kristina regarding issue:

            [6/23/2014 2:04:05 PM] Shannon Hess: Question on  KULRICE-5284 -- The message should be optional?  So by default no message when a collection line is deleted?
            [6/23/2014 2:29:04 PM] Shannon Hess: It seems to me it would be a good message to always display.
            [6/23/2014 2:31:14 PM] Kristina B. Taylor: What Jerry meant is that the message for the text should be configurable.
            [6/23/2014 2:32:32 PM] Shannon Hess: ok, that makes sense - Right now I have the default text as "An item from {0} was successfully deleted."  ex - "An item from subAccounts was successfully deleted."
            [6/23/2014 2:33:26 PM] Kristina B. Taylor: See if you can follow the mockup a bit closer, like "You have deleted..."
            [6/23/2014 2:33:41 PM] Kristina B. Taylor: I'm not sure how critical the phrasing is.
            [6/23/2014 2:35:36 PM] Shannon Hess: Ok, I can make it "You have deleted an item from subAccounts"   But you are also saying that there needs to be a way for a user to enter in whatever they want?
            [6/23/2014 2:36:02 PM] Kristina B. Taylor: I think he just meant to put it as a key in ApplicaitonResources.properties like we do all our other messages.
            
            Show
            shahess Shannon Hess added a comment - - edited Conversation with Kristina regarding issue: [6/23/2014 2:04:05 PM] Shannon Hess: Question on KULRICE-5284 -- The message should be optional? So by default no message when a collection line is deleted? [6/23/2014 2:29:04 PM] Shannon Hess: It seems to me it would be a good message to always display. [6/23/2014 2:31:14 PM] Kristina B. Taylor: What Jerry meant is that the message for the text should be configurable. [6/23/2014 2:32:32 PM] Shannon Hess: ok, that makes sense - Right now I have the default text as "An item from {0} was successfully deleted." ex - "An item from subAccounts was successfully deleted." [6/23/2014 2:33:26 PM] Kristina B. Taylor: See if you can follow the mockup a bit closer, like "You have deleted..." [6/23/2014 2:33:41 PM] Kristina B. Taylor: I'm not sure how critical the phrasing is. [6/23/2014 2:35:36 PM] Shannon Hess: Ok, I can make it "You have deleted an item from subAccounts" But you are also saying that there needs to be a way for a user to enter in whatever they want? [6/23/2014 2:36:02 PM] Kristina B. Taylor: I think he just meant to put it as a key in ApplicaitonResources.properties like we do all our other messages.
            Hide
            shahess Shannon Hess added a comment -

            The fix for this has been completed. The message uses the collection label in the message when a line is deleted (not the collection name as shown above in the conversation with Kristina). example : You have deleted an item from Sub Accounts.

            Using the phrase "You have ... " is very rare in the Kuali Rice code. It the phrasing is not critical, it may be better to change the message to something like "An item from Sub Accounts was successfully deleted."

            I'll also attach some screen shots to show what it looks like.

            Show
            shahess Shannon Hess added a comment - The fix for this has been completed. The message uses the collection label in the message when a line is deleted (not the collection name as shown above in the conversation with Kristina). example : You have deleted an item from Sub Accounts. Using the phrase "You have ... " is very rare in the Kuali Rice code. It the phrasing is not critical, it may be better to change the message to something like "An item from Sub Accounts was successfully deleted." I'll also attach some screen shots to show what it looks like.
            Hide
            shahess Shannon Hess added a comment -

            Attaching example screen shots

            Show
            shahess Shannon Hess added a comment - Attaching example screen shots

              People

              • Assignee:
                shahess Shannon Hess
                Reporter:
                jkneal Jerry Neal (Inactive)
              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Time Tracking

                  Estimated:
                  Original Estimate - 1 day
                  1d
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 2 hours Time Not Required
                  2h