Details

    • Type: Task Task
    • Status: Closed Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.0.0-b4, 2.0
    • Component/s: Development
    • Security Level: Public (Public: Anyone can view)
    • Labels:
      None
    • Similar issues:
      KULRICE-6298Remaining Issues from lightbox code review
      KULRICE-7179Cleanup issues from Tooltip code review
      KULRICE-7581Cleanup from Master/Detail Code Review
      KULRICE-8363Review comments from RDV code review
      KULRICE-9976KRAD-Data Code review updates
      KULRICE-9830IE back problems (iframes in lightboxes)
      KULRICE-8595Remove special CSS handling for lightboxes
      KULRICE-10309In IE 9, DOM printing from Lightbox is broken
      KULRICE-8518Directy Inquriy or Inquriy from Lookup Lightbox Returns to Document on Cancel
      KULRICE-10544Code review for Inquiry
    • Rice Module:
      KRAD
    • KAI Review Status:
      Not Required
    • KTI Review Status:
      Not Required

      Description

      Issues discussed in lightbox code review that should be fixed:

      1) Does center on scroll work for lightbox?
      2) Rename LightBoxLookup and DirectInquiry (with link, and with post)
      3) Make width/height actual properties on lightbox widget
      4) Set autoScale to true by default (need to do testing to verify causes no problems) - doesn't work right now
      5) Look into plugins for fancybox (like drag)
      6) Add an option for script only on lightbox, make sure not refreshing page will not cause issues with framework (session form support)
      7) Move returnTarget on View to LookupView
      8) Consolidate java Lightbox class to one (LightBox and LightBoxLookup)
      9) Rename ajaxCall to lightboxCall
      10) JS Method to getContext() to get target
      11) watermark.showAll still necessary?
      12) Use blank lines for better readability
      13) Do we need to post the page when going to a lookup? Can we just send the values from the page via script? Note: I think we might need an option to still do this. Default lookup parameters might get added with code or the lookup altered in some other way
      14) Organization of fancybox files. Put in standard images (with fancybox subfolder)/scripts/css folders and remove fancybox folder

        Issue Links

          Activity

          Hide
          Rice-CI User (Inactive) added a comment -

          Integrated in rice-trunk-nightly #158 (See http://ci.rice.kuali.org/job/rice-trunk-nightly/158/)
          KULRICE-5373 : Light box refactor

          Show
          Rice-CI User (Inactive) added a comment - Integrated in rice-trunk-nightly #158 (See http://ci.rice.kuali.org/job/rice-trunk-nightly/158/ ) KULRICE-5373 : Light box refactor
          Hide
          Samuel Holtzkampf (Inactive) added a comment -

          Outstanding :
          4) Fancybox autoScale just sets the size of light box according to the size of the content and does not re size the light box when the browser window resizes.
          5) Added jquery.easydrag lib. Dragging works but it is very slow and not really useable - did not activate dragable.
          13) Will look at this again after Ajax improvements

          Show
          Samuel Holtzkampf (Inactive) added a comment - Outstanding : 4) Fancybox autoScale just sets the size of light box according to the size of the content and does not re size the light box when the browser window resizes. 5) Added jquery.easydrag lib. Dragging works but it is very slow and not really useable - did not activate dragable. 13) Will look at this again after Ajax improvements
          Hide
          Rice-CI User (Inactive) added a comment -

          Integrated in rice-trunk-nightly #161 (See http://ci.rice.kuali.org/job/rice-trunk-nightly/161/)

          Show
          Rice-CI User (Inactive) added a comment - Integrated in rice-trunk-nightly #161 (See http://ci.rice.kuali.org/job/rice-trunk-nightly/161/ )
          Hide
          Jessica Coltrin (Inactive) added a comment -

          double-tagging with 2.0.0-b3 for review.

          Show
          Jessica Coltrin (Inactive) added a comment - double-tagging with 2.0.0-b3 for review.
          Hide
          Jessica Coltrin (Inactive) added a comment -

          Closing since these items are now in the release notes.

          Show
          Jessica Coltrin (Inactive) added a comment - Closing since these items are now in the release notes.

            People

            • Assignee:
              Samuel Holtzkampf (Inactive)
              Reporter:
              Jerry Neal (Inactive)
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Structure Helper Panel