Uploaded image for project: 'Kuali Rice Development'
  1. Kuali Rice Development
  2. KULRICE-5388

Lookup - Add support for specifying a menubar

    Details

    • Type: Task
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.4
    • Component/s: Development, Roadmap
    • Security Level: Public (Public: Anyone can view)
    • Labels:
      None
    • Rice Module:
      KRAD
    • KRAD Feature Area:
      Lookup
    • Sprint:
      2.4.0-m2 KRAD Sprint 4
    • KAI Review Status:
      Not Required
    • KTI Review Status:
      Pending Review
    • Include in Release Notes?:
      Yes

      Description

      The focus group decide that a convenience method is not needed.
      Document in conversion guide that the menubar is now being done through the header group. See Samuel's comment that explains this well.


      KNS lookup had support for specifying a menubar that would get rendering with the page title.

      Add a Group menubarGroup to LookupView which can be configured with the XML. Then add that group
      to the lookup view header.

      Look at how links can be added for other lookups with the same view.

        Attachments

          Issue Links

            Activity

            Hide
            jcoltrin Jessica Coltrin (Inactive) added a comment -

            double-tagging with 2.0.0-b3 for review.

            Show
            jcoltrin Jessica Coltrin (Inactive) added a comment - double-tagging with 2.0.0-b3 for review.
            Hide
            cniesen Claus Niesen added a comment -

            Jerry, does this cover the menubar feature (see headergroups.jpg)?

            <property name="header.lowerGroup">
            <bean parent="Uif-HeaderLowerGroup">
            <property name="items">
            <list>
            <bean parent="Uif-Message" p:messageText="Lower Group of headerText"/>
            </list>
            </property>
            </bean>
            </property>

            Show
            cniesen Claus Niesen added a comment - Jerry, does this cover the menubar feature (see headergroups.jpg)? <property name="header.lowerGroup"> <bean parent="Uif-HeaderLowerGroup"> <property name="items"> <list> <bean parent="Uif-Message" p:messageText="Lower Group of headerText"/> </list> </property> </bean> </property>
            Hide
            jkneal Jerry Neal (Inactive) added a comment -

            Claus,

            It does but is not as convenient as the KNS version. I would suggest we create an additional property like noted, and then stick that in the header.rightGroup of the page (if not set). Similar to how the other convenience properties work. Does that make sense?

            Jerry

            Show
            jkneal Jerry Neal (Inactive) added a comment - Claus, It does but is not as convenient as the KNS version. I would suggest we create an additional property like noted, and then stick that in the header.rightGroup of the page (if not set). Similar to how the other convenience properties work. Does that make sense? Jerry
            Hide
            samuel Samuel Holtzkampf (Inactive) added a comment - - edited

            I had a chat to Jerry and we agree that a convenience property does not really make sense. If we have a convenience property for the items within that group it just takes away the group that must be set. This makes choosing the type of group and also the header group position difficult in config. This will always default to header.rightGroup (like current KNS) but we do now have the freedom in KRAD to use any of the 4 header groups positions and choose the type of group. Adding convenience property will result in them having to revert to the normal config in any case if they want any other type of layout on the menubar.

            Example of adding two buttons current KRAD :

            <property name="header.rightGroup">
            <bean parent="Uif-HorizontalBoxSection">
            <property name="items">
            <list>
            <bean parent="Uif-PrimaryActionButton" p:methodToCall="search" p:actionLabel="Search"/>
            <bean parent="Uif-PrimaryActionButton" p:methodToCall="clearValues" p:actionLabel="Clear Values"/>
            </list>
            </property>
            </bean>
            </property>

            Same example with convenience group :

            <property name="menuBarItems">

            <list>
            <bean parent="Uif-PrimaryActionButton" p:methodToCall="search" p:actionLabel="Search"/>
            <bean parent="Uif-PrimaryActionButton" p:methodToCall="clearValues" p:actionLabel="Clear Values"/>
            </list>

            </property>

            Show
            samuel Samuel Holtzkampf (Inactive) added a comment - - edited I had a chat to Jerry and we agree that a convenience property does not really make sense. If we have a convenience property for the items within that group it just takes away the group that must be set. This makes choosing the type of group and also the header group position difficult in config. This will always default to header.rightGroup (like current KNS) but we do now have the freedom in KRAD to use any of the 4 header groups positions and choose the type of group. Adding convenience property will result in them having to revert to the normal config in any case if they want any other type of layout on the menubar. Example of adding two buttons current KRAD : <property name="header.rightGroup"> <bean parent="Uif-HorizontalBoxSection"> <property name="items"> <list> <bean parent="Uif-PrimaryActionButton" p:methodToCall="search" p:actionLabel="Search"/> <bean parent="Uif-PrimaryActionButton" p:methodToCall="clearValues" p:actionLabel="Clear Values"/> </list> </property> </bean> </property> Same example with convenience group : <property name="menuBarItems"> <list> <bean parent="Uif-PrimaryActionButton" p:methodToCall="search" p:actionLabel="Search"/> <bean parent="Uif-PrimaryActionButton" p:methodToCall="clearValues" p:actionLabel="Clear Values"/> </list> </property>
            Hide
            cniesen Claus Niesen added a comment -

            KRAD Equivalency Focus Group will make a decision at a later time (see Focus Group Topics).

            Show
            cniesen Claus Niesen added a comment - KRAD Equivalency Focus Group will make a decision at a later time (see Focus Group Topics ).
            Hide
            cniesen Claus Niesen added a comment -

            The focus group decide that a convenience method is not needed.

            Show
            cniesen Claus Niesen added a comment - The focus group decide that a convenience method is not needed.
            Hide
            sonam Sona Sona (Inactive) added a comment -

            No changes needed. Documentation already exists in conversion guide.

            Show
            sonam Sona Sona (Inactive) added a comment - No changes needed. Documentation already exists in conversion guide.

              People

              • Assignee:
                sonam Sona Sona (Inactive)
                Reporter:
                jkneal Jerry Neal (Inactive)
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Time Tracking

                  Estimated:
                  Original Estimate - 2 hours
                  2h
                  Remaining:
                  Time Spent - 1 hour Remaining Estimate - 1 hour
                  1h
                  Logged:
                  Time Spent - 1 hour Remaining Estimate - 1 hour
                  1h