Kuali Rice Development
  1. Kuali Rice Development
  2. KULRICE-5400

Case/When statement does not execute RequiredConstraint (SimpleConstraint) DictionaryValidatoinServiceImpl

    Details

    • Type: Bug Fix Bug Fix
    • Status: Closed Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.0.0-m5
    • Fix Version/s: 2.0.0-m7, 2.0
    • Component/s: Data Dictionary
    • Security Level: Public (Public: Anyone can view)
    • Labels:
      None
    • Similar issues:
      KULRICE-5553Case/When not implemented properly
      KULRICE-7699AttributeDefinition is missing SimpleConstraint
      KULRICE-8916Improve SimpleConstraint to support both inclusive and exclusive min/max
      KULRICE-12344Issue with IdentityArchiveServiceImpl when entity does not have principal
      KULRICE-12708States are not taken into account when required indicator is set
      KULRICE-3045User lookup workaround for case when name field is not rendered
      KULRICE-12414Responsibility actions are not saved in all cases when editing roles
      KULRICE-6411Character Encoding Statement Needed
      KULRICE-1296Add an ordering component to the unit test annotations for statements and files
      KULRICE-4524Manual execution of createproject.groovy for 1.0.3
    • Rice Module:
      KRAD
    • Application Requirement:
      Rice
    • KAI Review Status:
      Not Required
    • KTI Review Status:
      Not Required

      Description

      Created a case/when constraint that is supposed to add a RequiredConstraint (really a SimpleConstraint) to be executed but the RequiredConstraint never gets executed.

      Running the debugger the case/when executes properly and the RequiredConstraint (actually a SimpleConstraint with required=true) successfully gets added to the list of additionalConstraints and then added to the constraintQueue but it does not get executed by the ExistenceConstraintProcessor.java

      I think it is in this piece of code in the DictionaryValidationServiceImpl.java.
      // If this constraint is not one that this process handles, then skip and add to the queue for the next processor;
      // obviously this would be redundant (we're only looking at constraints that this processor can process) except that
      // the previous processor might have stuck a new constraint (or constraints) on the queue
      if (!constraintType.isInstance(constraint))

      { result.addSkipped(attributeValueReader, processor.getName()); additionalConstraints.add(constraint); continue; }

      I think it is because in the debugger the constraintType is ExistenceConstraint.class but SimpleConstraint.java does not implement ExistenceConstraint.java

        Issue Links

          Activity

          Scott Gibson (Inactive) made changes -
          Field Original Value New Value
          Assignee Will Gomes [ wgomes ]
          Fix Version/s 2.0.0-m7 [ 16314 ]
          Fix Version/s 2.0 [ 14190 ]
          Scott Gibson (Inactive) made changes -
          Start Date
          Fix Date 2011-08-08 [ set to sprint end date ]
          Scott Gibson (Inactive) made changes -
          Start Date
          Fix Date 2011-09-06 [ set to sprint end date ]
          Norm Wright made changes -
          Link This issue cloned to KULRICE-5439 [ KULRICE-5439 ]
          Show
          Norm Wright added a comment - A test that shows this error can be found in https://test.kuali.org/svn/student/branches/ks-1.3/ks-enroll/ks-enroll-api/src/test/java/org/kuali/student/r2/common/datadictionary/TestRiceDataDictionaryValidatorImplAgainstAcal.java testValidate13
          Will Gomes (Inactive) made changes -
          Status Open [ 1 ] Resolved [ 5 ]
          Resolution Fixed [ 1 ]
          Hide
          Rice-CI User (Inactive) added a comment -

          Integrated in rice-trunk-nightly #137 (See http://ci.rice.kuali.org/job/rice-trunk-nightly/137/)
          KULRICE-5400 Implement ExistanceConstraint on SimpleConstraint so it gets processed by constraint processor.

          Show
          Rice-CI User (Inactive) added a comment - Integrated in rice-trunk-nightly #137 (See http://ci.rice.kuali.org/job/rice-trunk-nightly/137/ ) KULRICE-5400 Implement ExistanceConstraint on SimpleConstraint so it gets processed by constraint processor.
          Norm Wright made changes -
          Link This issue cloned to KULRICE-5454 [ KULRICE-5454 ]
          Norm Wright made changes -
          Link This issue cloned to KULRICE-5553 [ KULRICE-5553 ]
          Hide
          Jessica Coltrin (Inactive) added a comment -

          Closing since these items are now in the release notes.

          Show
          Jessica Coltrin (Inactive) added a comment - Closing since these items are now in the release notes.
          Jessica Coltrin (Inactive) made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          Shem Patterson (Inactive) made changes -
          Workflow custom [ 100904 ] Copy of custom for rice [ 212887 ]
          Shem Patterson (Inactive) made changes -
          Workflow Copy of custom for rice [ 212887 ] custom [ 222635 ]
          Shem Patterson (Inactive) made changes -
          Workflow custom [ 222635 ] Rice Workflow [ 232383 ]

            People

            • Assignee:
              Will Gomes (Inactive)
              Reporter:
              Norm Wright
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Structure Helper Panel