Kuali Rice Development
  1. Kuali Rice Development
  2. KULRICE-5804

Ability to configure results limits differently for different lookups needs to be added to KRAD - it was contributed for KNS in KULRICE-5686

    Details

    • Type: New Feature New Feature
    • Status: Closed Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.3.0-m1, 2.3
    • Component/s: Development, Roadmap
    • Security Level: Public (Public: Anyone can view)
    • Labels:
      None
    • Similar issues:
      KULRICE-5686Need the ability to configure results limits differently for different lookups
      KULRICE-3283Allow for System Parameters to be set differently for different client applications
      KULRICE-8523KNS Theme - Font size differences
      KULRICE-9034KR-KRAD - RESULTS_LIMIT parameter should be added and the code should be changed to use it
      KULRICE-7006Provide configuration on Collection Group to limit displayed records
      KULRICE-8664Update KENConfigurer to have the ability to specify a different datasource
      KULRICE-114User Login Differences need worked out.
      KULRICE-6967Rice impl and krad depend on different versions of slf4j
      KULRICE-13865Support different modes of operation in the Rice testing framework
      KULRICE-10453Application specific RESULTS_Limit parameters
    • Rice Module:
      KRAD
    • KRAD Feature Area:
      Lookup
    • Application Requirement:
      Rice
    • KAI Review Status:
      Not Required
    • KTI Review Status:
      Not Required
    • Include in Release Notes?:
      Yes

      Description

      In KULRICE-5686, ability to configure results limits differently for different lookups was contributed back in the KNS. It needs to be ported over to KRAD at some point.

      We need to make sure to cover the following:

      • Ability to configure lookup result limits globally by system parameter.
      • Ability to configure lookup result limits per client application by system parameter.
      • Ability to configure lookup result limits by module by system parameter.
      • Ability to configure lookup result limits by business object by system parameter.

      Additional gap analysis notes: https://docs.google.com/a/kuali.org/document/d/1EbmyKzcSXKXu4WphCihzFue1WTDUwkSejywdFXoGctA/edit

        Issue Links

          Activity

          Hide
          Shannon Hess added a comment -

          Great, thanks for the info Jerry.

          Show
          Shannon Hess added a comment - Great, thanks for the info Jerry.
          Hide
          Shannon Hess added a comment - - edited

          The following code in ViewDictionaryServiceImpl.getResultSetLimitForLookup is causing issues because the limit values in the default view overrides any limit values placed in a non-default view. I changed the code so that the view is directly checked if a viewId is provided. However, should it fall back and use the values in the default view if the limits are not specified in the non-default view?

          OLD CODE -

          if (StringUtils.equals(lView.getDataObjectClassName().getName(), dataObjectClass.getName())) {
             // if we already found a lookup view, only override if this is the default
             if (lookupView != null) {
                 if (StringUtils.equals(lView.getViewName(), UifConstants.DEFAULT_VIEW_NAME)) {
                     lookupView = lView;
                 }
             } else {
                 lookupView = lView;
             }
          }
          
          Show
          Shannon Hess added a comment - - edited The following code in ViewDictionaryServiceImpl.getResultSetLimitForLookup is causing issues because the limit values in the default view overrides any limit values placed in a non-default view. I changed the code so that the view is directly checked if a viewId is provided. However, should it fall back and use the values in the default view if the limits are not specified in the non-default view? OLD CODE - if (StringUtils.equals(lView.getDataObjectClassName().getName(), dataObjectClass.getName())) { // if we already found a lookup view, only override if this is the default if (lookupView != null ) { if (StringUtils.equals(lView.getViewName(), UifConstants.DEFAULT_VIEW_NAME)) { lookupView = lView; } } else { lookupView = lView; } }
          Hide
          Shannon Hess added a comment - - edited

          I've created the following crucible review - https://fisheye.kuali.org/cru/rice-219

          The following are working as expected in KRAD:

          • Ability to configure lookup result limits globally by system parameter.
          • Ability to configure lookup result limits per client application by system parameter.
          • Ability to configure lookup result limits by business object by system parameter.
          • Ability to configure lookup result limits by business object by system parameter differently for multiple select lookups (can be specified on URL or in View)

          According to the gap analysis, the ability to configure lookup result limits by module by system parameter is N/A. Is that still true?

          Thanks,
          Shannon

          Show
          Shannon Hess added a comment - - edited I've created the following crucible review - https://fisheye.kuali.org/cru/rice-219 The following are working as expected in KRAD: Ability to configure lookup result limits globally by system parameter. Ability to configure lookup result limits per client application by system parameter. Ability to configure lookup result limits by business object by system parameter. Ability to configure lookup result limits by business object by system parameter differently for multiple select lookups (can be specified on URL or in View) According to the gap analysis, the ability to configure lookup result limits by module by system parameter is N/A. Is that still true? Thanks, Shannon
          Hide
          Shannon Hess added a comment -

          Sample Lookups created for testing can be found on the KRAD tab, KRAD Testing - KNS L&F section uneder "Lookup Samples"

          Show
          Shannon Hess added a comment - Sample Lookups created for testing can be found on the KRAD tab, KRAD Testing - KNS L&F section uneder "Lookup Samples"
          Hide
          Shannon Hess added a comment -

          I'm going to go ahead and close this since all issues from the crucible review have been addressed.

          Show
          Shannon Hess added a comment - I'm going to go ahead and close this since all issues from the crucible review have been addressed.

            People

            • Assignee:
              Shannon Hess
              Reporter:
              Shannon Hess
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - Not Specified
                Not Specified
                Logged:
                Time Spent - 20 minutes
                20m

                  Structure Helper Panel