Details

    • Type: Task
    • Status: Closed
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.0.0-b1, 2.0
    • Component/s: Unit Testing
    • Security Level: Public (Public: Anyone can view)
    • Labels:
      None
    • Rice Module:
      KRMS
    • KAI Review Status:
      Not Required
    • KTI Review Status:
      Not Required

      Description

      Fix KRMS integration test failures at http://ci.rice.kuali.org/view/Rice%20Trunk/job/rice-trunk-integration-test-mysql/. Setting to Blocker since this must be complete prior to release on 11/7.

        Attachments

          Activity

          Hide
          riceci Rice-CI User (Inactive) added a comment -

          Integrated in rice-trunk-nightly #245 (See http://ci.rice.kuali.org/job/rice-trunk-nightly/245/)
          KULRICE-5886: Fix KRMS integration test failures

          20112011-11-03.sql, mysql-2011-11-03.sql:

          • added script for making typ_id fields on krms_rule_t, krms_agenda_t, and krms_cntxt_t nullable

          AbstractBoTest.java:

          • get BO service from KRADServiceLocator instead

          GeneicTestDao.java, TestBoService.java:

          • deleted, no longer used

          PropositionBoServiceTest.java, TermRelatedBoTest.java:

          • removed calls to super.setup()

          RepositoryCreateAndExecuteIntegrationTest.java, ValidationIntegrationTest.java:

          • removed manual registration of engine result listeners
          • removed call to super.setup()

          krms-test-config.xml:

          • added rice.KRMS.additionalSpringFiles referrring to KRMSSpringBeans-test.xml

          KRMSSpringBeans-test.xml:

          • new file for injecting beans into the krms application context (or something like that)

          KRMSTestHarnessSpringBeans.xml:

          • importing and starting up lots of Rice modules, removing our custom test beans

          ResultLogger.java:

          • removed init() method

          AgendaTest.java, CollectionOfComparablesTermBasedPropositionTest.java, KRMSTest.java, ResultLoggingTest.java:

          • removed calls to ResultLogger.init()

          KrmsRepositoryServiceLocator.java:

          • added static get for RepositoryToEngineTranslator

          KrmsTypeResolverImpl.java:

          • made null type IDs ok
          • made rule w/ null type ID use RuleTypeServiceBase.defaultRuleTypeService

          RuleTypeServiceBase.java:

          • added default loadRule implementation that creates a BasicRule
          Show
          riceci Rice-CI User (Inactive) added a comment - Integrated in rice-trunk-nightly #245 (See http://ci.rice.kuali.org/job/rice-trunk-nightly/245/ ) KULRICE-5886 : Fix KRMS integration test failures 20112011-11-03.sql, mysql-2011-11-03.sql: added script for making typ_id fields on krms_rule_t, krms_agenda_t, and krms_cntxt_t nullable AbstractBoTest.java: get BO service from KRADServiceLocator instead GeneicTestDao.java, TestBoService.java: deleted, no longer used PropositionBoServiceTest.java, TermRelatedBoTest.java: removed calls to super.setup() RepositoryCreateAndExecuteIntegrationTest.java, ValidationIntegrationTest.java: removed manual registration of engine result listeners removed call to super.setup() krms-test-config.xml: added rice.KRMS.additionalSpringFiles referrring to KRMSSpringBeans-test.xml KRMSSpringBeans-test.xml: new file for injecting beans into the krms application context (or something like that) KRMSTestHarnessSpringBeans.xml: importing and starting up lots of Rice modules, removing our custom test beans ResultLogger.java: removed init() method AgendaTest.java, CollectionOfComparablesTermBasedPropositionTest.java, KRMSTest.java, ResultLoggingTest.java: removed calls to ResultLogger.init() KrmsRepositoryServiceLocator.java: added static get for RepositoryToEngineTranslator KrmsTypeResolverImpl.java: made null type IDs ok made rule w/ null type ID use RuleTypeServiceBase.defaultRuleTypeService RuleTypeServiceBase.java: added default loadRule implementation that creates a BasicRule
          Hide
          jcoltrin Jessica Coltrin (Inactive) added a comment -

          Closing since these items are now in the release notes.

          Show
          jcoltrin Jessica Coltrin (Inactive) added a comment - Closing since these items are now in the release notes.

            People

            • Assignee:
              gilesp Peter Giles (Inactive)
              Reporter:
              masargen Matt Sargent
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: