Uploaded image for project: 'Kuali Rice Development'
  1. Kuali Rice Development
  2. KULRICE-5893

Error messages need to be resolved on the remote services

    Details

    • Type: Bug Fix
    • Status: Open
    • Priority: Major
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: Backlog
    • Component/s: Development
    • Security Level: Public (Public: Anyone can view)
    • Labels:
    • Rice Module:
      KRAD
    • KAI Review Status:
      Not Required
    • KTI Review Status:
      Not Required

      Description

      Currently the remote services pass back the error message key for remote attribute validations and then Rice resolves them. However, with truly remote service this will not be possible as the local rice instance won't be able to resolve remote service. Instead the actual error message that is being displayed to the user should be passed back from the remote service.


      Claus: Back to my question, does the error builder of RemotableAttributeError support error message with arguments (ie "This error

      {0}

      !")?

      Eric: no it does not and it's not supposed to, the idea being that messages will be resolved from local resource bundles before passing them back across the wire

      because say an application like kc was producing error messages, it would likely have some external message bundle for i18n, but it should resolve those outbound error messages prior to sending them to rice (in the case of this coming from something like an ActionTypeService, AgendaTypeService, whatever) because Rice has no idea about KC's local error message information and shouldn't need to

      Claus: So you are saying the remote service will send the actual error message that is displayed to the user? Because that's not what's happening currently. KRMS is setup to accept an error message key (i.e. peopleFlow.peopleFlowId.require), not the actual error message. KRAD (in ErrorsFields.getMessages()) then looks up the actual message (i.e. "PeopleFlow ID is required.") from the appropriate ApplicationResources.properties file (in this case KEW's).

      Eric: yeah, that's not the way it should be working, peopleflow comes from kew, so we should assume that KRMS should not even have access to kew's ApplicationResources.properties

      in practice it does because our current modularity sucks

      but imagine that KC was creating a custom action type in KRMS

      we won't have their ApplicationResources.properties available to us on the KRMS side

      so if we are getting error messages from a RemotableAttributeError, they need to be pre-resolved

      now, on the KC side in that case, they would probably do something similar to what you are doing in order to resolve the actual error message before sending it across the wire

      does that make sense?

      Claus: Uh, oh! We'll need to fix that then before the release. There is the KRMS part and the remote services we'll need to fix. I'll create a Jira for it.

      It makes sense and I understand it.

      Eric: cool, yeah we can just treat it as a bug

        Attachments

          Issue Links

            Activity

            cniesen Claus Niesen created issue -
            cniesen Claus Niesen made changes -
            Field Original Value New Value
            Link This issue discovered KULRICE-5894 [ KULRICE-5894 ]
            jcoltrin Jessica Coltrin (Inactive) made changes -
            Fix Version/s 2.0.0-b2 [ 16371 ]
            Fix Version/s 2.0 [ 14190 ]
            jcoltrin Jessica Coltrin (Inactive) made changes -
            Start Date
            Fix Date 2011-11-21 [ set to sprint end date ]
            jcoltrin Jessica Coltrin (Inactive) made changes -
            Start Date
            Fix Date 2012-01-27 [ set to sprint end date ]
            ahamid Aaron Hamid (Inactive) made changes -
            Assignee Aaron Hamid [ ahamid ]
            ahamid Aaron Hamid (Inactive) made changes -
            Status Open [ 1 ] In Progress [ 3 ]
            ahamid Aaron Hamid (Inactive) made changes -
            Status In Progress [ 3 ] Open [ 1 ]
            ewestfal Eric Westfall made changes -
            Fix Version/s 2.0.0-b2 [ 16371 ]
            jcoltrin Jessica Coltrin (Inactive) made changes -
            Fix Version/s 2.0.0-b5 [ 16377 ]
            jcoltrin Jessica Coltrin (Inactive) made changes -
            Start Date
            Fix Date 2012-01-27 2012-01-09 [ set to sprint end date ]
            gilesp Peter Giles (Inactive) made changes -
            Rice Lead gilesp jjhanso
            jjhanso Jeremy Hanson made changes -
            Fix Version/s 2.0.0-rc1 [ 16378 ]
            Fix Version/s 2.0.0-b5 [ 16377 ]
            jjhanso Jeremy Hanson made changes -
            Start Date
            Fix Date 2012-01-09 2012-01-23 [ set to sprint end date ]
            jcoltrin Jessica Coltrin (Inactive) made changes -
            Fix Version/s 2.0.0-rc2 [ 16448 ]
            Fix Version/s 2.0.0-rc1 [ 16378 ]
            jcoltrin Jessica Coltrin (Inactive) made changes -
            Start Date
            Fix Date 2012-01-23 [ set to sprint end date ]
            jjhanso Jeremy Hanson made changes -
            Assignee Aaron Hamid [ ahamid ]
            gilesp Peter Giles (Inactive) made changes -
            Fix Version/s 2.1 [ 15812 ]
            Fix Version/s 2.0 [ 14190 ]
            Fix Version/s 2.0.0-rc2 [ 16448 ]
            Rice Module [KRMS] [KRAD]
            gilesp Peter Giles (Inactive) made changes -
            Start Date
            Fix Date [ set to sprint end date ]
            gilesp Peter Giles (Inactive) made changes -
            Rice Lead jjhanso jkneal
            jcoltrin Jessica Coltrin (Inactive) made changes -
            Fix Version/s 2.2 [ 16411 ]
            jcoltrin Jessica Coltrin (Inactive) made changes -
            Start Date
            Fix Date [ set to sprint end date ]
            jkneal Jerry Neal (Inactive) made changes -
            Fix Version/s 2.1 [ 15812 ]
            Affects Version/s 2.0.0-b1 [ 16315 ]
            jcoltrin Jessica Coltrin (Inactive) made changes -
            Fix Version/s 2.2-backlog [ 16475 ]
            jcoltrin Jessica Coltrin (Inactive) made changes -
            Start Date
            Fix Date [ set to sprint end date ]
            gilesp Peter Giles (Inactive) made changes -
            Link This issue is relied upon by KULRICE-6948 [ KULRICE-6948 ]
            jcoltrin Jessica Coltrin (Inactive) made changes -
            Priority Critical [ 2 ] Major [ 3 ]
            jcoltrin Jessica Coltrin (Inactive) made changes -
            Fix Version/s 2.2.1 [ 16733 ]
            Fix Version/s 2.2 [ 16411 ]
            Fix Version/s 2.2-backlog [ 16475 ]
            jcoltrin Jessica Coltrin (Inactive) made changes -
            Fix Version/s 2.3-backlog [ 16596 ]
            Fix Version/s 2.2.1 [ 16733 ]
            spatterson Shem Patterson (Inactive) made changes -
            Workflow custom [ 104541 ] Copy of custom for rice [ 207180 ]
            spatterson Shem Patterson (Inactive) made changes -
            Workflow Copy of custom for rice [ 207180 ] custom [ 216928 ]
            spatterson Shem Patterson (Inactive) made changes -
            Workflow custom [ 216928 ] Rice Workflow [ 226676 ]
            jcoltrin Jessica Coltrin (Inactive) made changes -
            Fix Version/s 2.4 [ 16913 ]
            Fix Version/s 2.4-backlog [ 16596 ]
            jcoltrin Jessica Coltrin (Inactive) made changes -
            Fix Version/s Backlog [ 15811 ]
            Fix Version/s 2.4 [ 16913 ]
            kbtaylor Kristina Taylor (Inactive) made changes -
            Rank Ranked higher
            kbtaylor Kristina Taylor (Inactive) made changes -
            Rank Ranked higher
            ewestfal Eric Westfall made changes -
            Labels Old

              People

              • Assignee:
                Unassigned
                Reporter:
                cniesen Claus Niesen
              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated: