Uploaded image for project: 'Kuali Rice Development'
  1. Kuali Rice Development
  2. KULRICE-6405

Block-level inside elements appear inside inline elements

    Details

    • Type: Bug Fix
    • Status: Closed
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.2
    • Component/s: Accessibility
    • Security Level: Public (Public: Anyone can view)
    • Labels:
      None
    • Rice Module:
      KRAD
    • Application Requirement:
      KS
    • KAI Review Status:
      Not Required
    • KTI Review Status:
      Not Required

      Description

      divs are currently buried under span tags
      ideally, we shouldn't be using spans at all - its really a last resort kind of fix
      this doesn't validate, has caused and will cause odd behavior with CSS formatting, and will significantly complicate any future CSS reformatting efforts.

        Attachments

          Issue Links

            Activity

            Hide
            garettg Garett Gowens added a comment -

            Example to illustrate the description of this jira, here is what a basic group bean with a horizontal orientation will produce (somewhat stripped down):

            <div id="bean_id_div">
            <div id="bean_id_group">
            <span>
            <span class="fieldLine boxLayoutHorizontalItem">
            <div id="nested_bean_1_div">nested bean here</div>
            </span>
            <span class="fieldLine boxLayoutHorizontalItem">
            <div id="nested_bean_2_div">nested bean here</div>
            </span>
            </span>
            </div>
            </div>

            Show
            garettg Garett Gowens added a comment - Example to illustrate the description of this jira, here is what a basic group bean with a horizontal orientation will produce (somewhat stripped down): <div id="bean_id_div"> <div id="bean_id_group"> <span> <span class="fieldLine boxLayoutHorizontalItem"> <div id="nested_bean_1_div">nested bean here</div> </span> <span class="fieldLine boxLayoutHorizontalItem"> <div id="nested_bean_2_div">nested bean here</div> </span> </span> </div> </div>
            Hide
            wwashington William Washington (Inactive) added a comment -

            seems like the solution would be to use DIVs with left floats instead of in-lined spans. correct?

            Show
            wwashington William Washington (Inactive) added a comment - seems like the solution would be to use DIVs with left floats instead of in-lined spans. correct?
            Hide
            jkneal Jerry Neal (Inactive) added a comment -

            Reducing priority as this doesn't seem to be an issue that is blocking development.

            Show
            jkneal Jerry Neal (Inactive) added a comment - Reducing priority as this doesn't seem to be an issue that is blocking development.
            Hide
            bsmith Brian Smith (Inactive) added a comment -

            There will be a lot of reduction as part of the jsp rework, but the use of spans will still be necessary in some areas (though I may change some to div)

            Show
            bsmith Brian Smith (Inactive) added a comment - There will be a lot of reduction as part of the jsp rework, but the use of spans will still be necessary in some areas (though I may change some to div)
            Hide
            jyetman Jill Yetman (Inactive) added a comment -

            @Jerry - Perhaps I am missing something, but my understanding is that this bug is currently blocking our visual design. I don't want to try to apply a more complex and complete visual layer until I know that the block elements are structured appropriately. If you don't think this should be a blocking issue, I'd like to discuss it in more detail with you, our UI Dev - Garett, and possibly Kamal.

            @Brian - Can you confirm that the plan is to ensure that spans and divs are used appropriately? In other words, will spans only be used for in-line elements?

            Show
            jyetman Jill Yetman (Inactive) added a comment - @Jerry - Perhaps I am missing something, but my understanding is that this bug is currently blocking our visual design. I don't want to try to apply a more complex and complete visual layer until I know that the block elements are structured appropriately. If you don't think this should be a blocking issue, I'd like to discuss it in more detail with you, our UI Dev - Garett, and possibly Kamal. @Brian - Can you confirm that the plan is to ensure that spans and divs are used appropriately? In other words, will spans only be used for in-line elements?
            Hide
            bsmith Brian Smith (Inactive) added a comment - - edited

            After reviewing the HTML5 spec in how they define Grouping content vs. Text-level semantics, I think we will change all areas which use incorrectly use span (to group content that is not text/inline) to now use DIV in this work.

            Show
            bsmith Brian Smith (Inactive) added a comment - - edited After reviewing the HTML5 spec in how they define Grouping content vs. Text-level semantics, I think we will change all areas which use incorrectly use span (to group content that is not text/inline) to now use DIV in this work.
            Hide
            bsmith Brian Smith (Inactive) added a comment -

            This should be mostly fixes

            Show
            bsmith Brian Smith (Inactive) added a comment - This should be mostly fixes

              People

              • Assignee:
                bsmith Brian Smith (Inactive)
                Reporter:
                jyetman Jill Yetman (Inactive)
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: