Kuali Rice Development
  1. Kuali Rice Development
  2. KULRICE-6542

Remove PersonService.updatePersonIfNeccessary and determine if code within needs to go to a helper somewhere

    Details

    • Type: Improvement Improvement
    • Status: Open Open
    • Priority: Major Major
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: Backlog
    • Component/s: Development
    • Security Level: Public (Public: Anyone can view)
    • Labels:
    • Similar issues:
      KULRICE-3168Determine if "properties" bean in CommonSpringBeans.xml is needed, if not remove it
      KULRICE-13226Remove helper text functionality
      KULRICE-3055determine whether the required attribute tables were a good idea
      KULRICE-9417Determine if we really need org.kuali.rice.krad.data.provider.util.PersistenceUtils
      KULRICE-11724Code Report
      KULRICE-9338Determine whether we need OrmUtils merge/reattach functionality
      KULRICE-4637Remove deprecated code
      KULRICE-10952Logic to determine if a given date is within an InactivatableFromTo range is flawed in InactivatableFromToUtils
      KULRICE-13169Investigate why extensions for View Helper Service don't need an interface when running locally
      KULRICE-13188Remove helper text functionality and add 2 options instead for showing text
    • Rice Module:
      KIM
    • KAI Review Status:
      Not Required
    • KTI Review Status:
      Not Required

      Description

      From a code review on the KIM service for 2.0, Jonathan mentions the following:

      Why don't we mark this one as deprecated. Really, if the person does not need to be changed, and the caller has those two parameters, then it should make this determination locally. They should not need to call into a service (which could be remote?) just to compare a string. If anything, this seems more like a KNS/KRAD helper service API method than something which belongs on the KIM APIs.
      

      I'm thinking rather than mark it deprecated we just remove it.

        Activity

        There are no comments yet on this issue.

          People

          • Assignee:
            Unassigned
            Reporter:
            Eric Westfall
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:

              Structure Helper Panel