Kuali Rice Development
  1. Kuali Rice Development
  2. KULRICE-6587

Document Search Results open in a new window regardless of the system parameter (DOCUMENT_SEARCH_POPUP_IND) value

    Details

    • Type: Bug Fix Bug Fix
    • Status: Closed Closed
    • Priority: Critical Critical
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.0.0-rc2, 2.0
    • Component/s: Development
    • Security Level: Public (Public: Anyone can view)
    • Labels:
      None
    • Similar issues:
      KULRICE-1605Clicking on a Document ID from Doc Search opens a new window (different behavior than Action List)
      KULRICE-4104Opening from doc search opens new window - clicking close returns to the portal in the new window
      KULRICE-10915Create a system param for opening inquiries in lightboxes or new browser window
      KULRICE-2548Docs opened from action list and document search are opening in a new window
      KULRICE-12002Lookup with lightbox disabled opens new window upon returning a value
      KULRICE-3928KIM Lookups not opening inquiries in new windows
      KULRICE-5355Lookup - return values opens new tab, the return target is not set
      KULRICE-8371KRMS - Copy rule search parmeter window prepopulates rule id
      KULRICE-2388New System Parameters for address related documents
      KULRICE-12542Prevent KRAD views from opening in doc search iframe
    • Rice Module:
      KNS, KRAD
    • KAI Review Status:
      Not Required
    • KTI Review Status:
      Not Required

      Description

      ActionList and DocumentSearch both use System parameter values to decide if a link should open in a new window or not. While ActionList behaves as expected (System parameter ACTION_LIST_DOCUMENT_POPUP_IND value drives this behavior), document search does not.

      DocumentSearchCriteriaBoLookupableHelperService.generateDocumentHandlerUrl method generates the link url and it uses the following piece of code to decide the target window behavior.

      DocumentSearchCriteriaBoLookupableHelperService.java
      if (isDocumentHandlerPopup()) {
           link.setTarget("_blank");
      }
      

      The target is set only when the system parameter maps to a true value. However, KualiLookup.jsp overrides this behavior with this if/else logic.

      KualiLookup.jsp
      <c:choose>
      <c:when test="${empty column.columnAnchor.target}"><c:set var="anchorTarget" value="_blank" /></c:when>
      <c:otherwise><c:set var="anchorTarget" value="${column.columnAnchor.target}" /></c:otherwise>
      </c:choose>
      

      So, in cases where apps have overridden the DOCUMENT_SEARCH_POPUP_IND parameter to have a false value, DocumentSearchCriteriaBoLookupableHelperService won't set the anchor target and the KualiLookup.jsp will default that to open in a new window.

      Since KualiLookup.jsp is common across all lookups and this maybe the default behavior we want for BO lookups, it would help to replace DocumentSearchCriteriaBoLookupableHelperService code to

      if (isDocumentHandlerPopup()) {
        link.setTarget("_blank");
      } else {
        link.setTarget("_self");
      }
      

        Activity

        Hide
        Jessica Coltrin (Inactive) added a comment -

        Closing since these items are now in the release notes.

        Show
        Jessica Coltrin (Inactive) added a comment - Closing since these items are now in the release notes.

          People

          • Assignee:
            Sona Sona (Inactive)
            Reporter:
            Chitra Chandran
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Structure Helper Panel