Uploaded image for project: 'Kuali Rice Development'
  1. Kuali Rice Development
  2. KULRICE-6587

Document Search Results open in a new window regardless of the system parameter (DOCUMENT_SEARCH_POPUP_IND) value

    Details

    • Type: Bug Fix
    • Status: Closed
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.0.0-rc2, 2.0
    • Component/s: Development
    • Security Level: Public (Public: Anyone can view)
    • Labels:
      None
    • Rice Module:
      KNS, KRAD
    • KAI Review Status:
      Not Required
    • KTI Review Status:
      Not Required

      Description

      ActionList and DocumentSearch both use System parameter values to decide if a link should open in a new window or not. While ActionList behaves as expected (System parameter ACTION_LIST_DOCUMENT_POPUP_IND value drives this behavior), document search does not.

      DocumentSearchCriteriaBoLookupableHelperService.generateDocumentHandlerUrl method generates the link url and it uses the following piece of code to decide the target window behavior.

      DocumentSearchCriteriaBoLookupableHelperService.java
      if (isDocumentHandlerPopup()) {
           link.setTarget("_blank");
      }
      

      The target is set only when the system parameter maps to a true value. However, KualiLookup.jsp overrides this behavior with this if/else logic.

      KualiLookup.jsp
      <c:choose>
      <c:when test="${empty column.columnAnchor.target}"><c:set var="anchorTarget" value="_blank" /></c:when>
      <c:otherwise><c:set var="anchorTarget" value="${column.columnAnchor.target}" /></c:otherwise>
      </c:choose>
      

      So, in cases where apps have overridden the DOCUMENT_SEARCH_POPUP_IND parameter to have a false value, DocumentSearchCriteriaBoLookupableHelperService won't set the anchor target and the KualiLookup.jsp will default that to open in a new window.

      Since KualiLookup.jsp is common across all lookups and this maybe the default behavior we want for BO lookups, it would help to replace DocumentSearchCriteriaBoLookupableHelperService code to

      if (isDocumentHandlerPopup()) {
        link.setTarget("_blank");
      } else {
        link.setTarget("_self");
      }
      

        Attachments

          Activity

          cchandran Chitra Chandran created issue -
          cchandran Chitra Chandran made changes -
          Field Original Value New Value
          Description ActionList and DocumentSearch both lookup System parameter values to decide if a link should open in a new window or not. While ActionList behaves as expected (System parameter ACTION_LIST_DOCUMENT_POPUP_IND value drives this behavior), document search does not.

          DocumentSearchCriteriaBoLookupableHelperService.generateDocumentHandlerUrl method generates the link url and it uses the following piece of code to decide the target window behavior.

                  if (isDocumentHandlerPopup()) {
                      link.setTarget("_blank");
                  }

          The target is set only when the system parameter value maps to a true value.

          However, KualiLookup.jsp overrides this behavior with this if/else logic.

          {code:title=KualiLookup.jsp|borderStyle=solid}
          <c:choose>
          <c:when test="${empty column.columnAnchor.target}"><c:set var="anchorTarget" value="_blank" /></c:when>
          <c:otherwise><c:set var="anchorTarget" value="${column.columnAnchor.target}" /></c:otherwise>
          </c:choose>
          {code}

          So, in cases where apps have overridden the DOCUMENT_SEARCH_POPUP_IND parameter to have a false value, DocumentSearchCriteriaBoLookupableHelperService won't set the anchor target and the KualiLookup.jsp will default that to open in a new window.

          Since KualiLookup.jsp is common across all lookups and this maybe the default behavior we want for all BO lookups, it would help to replace the following code from

          {code:title=DocumentSearchCriteriaBoLookupableHelperService.java|borderStyle=solid}

                  if (isDocumentHandlerPopup()) {
                      link.setTarget("_blank");
                  }
          {code}
          to
          {code}
          if (isDocumentHandlerPopup()) {
            link.setTarget("_blank");
          } else {
            link.setTarget("_self");
          }
          {code}
          ActionList and DocumentSearch both lookup System parameter values to decide if a link should open in a new window or not. While ActionList behaves as expected (System parameter ACTION_LIST_DOCUMENT_POPUP_IND value drives this behavior), document search does not.

          DocumentSearchCriteriaBoLookupableHelperService.generateDocumentHandlerUrl method generates the link url and it uses the following piece of code to decide the target window behavior.

          {code:title=DocumentSearchCriteriaBoLookupableHelperService.java|borderStyle=solid}

                  if (isDocumentHandlerPopup()) {
                      link.setTarget("_blank");
                  }
          {code}

          The target is set only when the system parameter value maps to a true value.

          However, KualiLookup.jsp overrides this behavior with this if/else logic.

          {code:title=KualiLookup.jsp|borderStyle=solid}
          <c:choose>
          <c:when test="${empty column.columnAnchor.target}"><c:set var="anchorTarget" value="_blank" /></c:when>
          <c:otherwise><c:set var="anchorTarget" value="${column.columnAnchor.target}" /></c:otherwise>
          </c:choose>
          {code}

          So, in cases where apps have overridden the DOCUMENT_SEARCH_POPUP_IND parameter to have a false value, DocumentSearchCriteriaBoLookupableHelperService won't set the anchor target and the KualiLookup.jsp will default that to open in a new window.

          Since KualiLookup.jsp is common across all lookups and this maybe the default behavior we want for all BO lookups, it would help to replace DocumentSearchCriteriaBoLookupableHelperService code to

           
          {code}
          if (isDocumentHandlerPopup()) {
            link.setTarget("_blank");
          } else {
            link.setTarget("_self");
          }
          {code}
          cchandran Chitra Chandran made changes -
          Fix Version/s 2.0.0-rc2 [ 16448 ]
          Description ActionList and DocumentSearch both lookup System parameter values to decide if a link should open in a new window or not. While ActionList behaves as expected (System parameter ACTION_LIST_DOCUMENT_POPUP_IND value drives this behavior), document search does not.

          DocumentSearchCriteriaBoLookupableHelperService.generateDocumentHandlerUrl method generates the link url and it uses the following piece of code to decide the target window behavior.

          {code:title=DocumentSearchCriteriaBoLookupableHelperService.java|borderStyle=solid}

                  if (isDocumentHandlerPopup()) {
                      link.setTarget("_blank");
                  }
          {code}

          The target is set only when the system parameter value maps to a true value.

          However, KualiLookup.jsp overrides this behavior with this if/else logic.

          {code:title=KualiLookup.jsp|borderStyle=solid}
          <c:choose>
          <c:when test="${empty column.columnAnchor.target}"><c:set var="anchorTarget" value="_blank" /></c:when>
          <c:otherwise><c:set var="anchorTarget" value="${column.columnAnchor.target}" /></c:otherwise>
          </c:choose>
          {code}

          So, in cases where apps have overridden the DOCUMENT_SEARCH_POPUP_IND parameter to have a false value, DocumentSearchCriteriaBoLookupableHelperService won't set the anchor target and the KualiLookup.jsp will default that to open in a new window.

          Since KualiLookup.jsp is common across all lookups and this maybe the default behavior we want for all BO lookups, it would help to replace DocumentSearchCriteriaBoLookupableHelperService code to

           
          {code}
          if (isDocumentHandlerPopup()) {
            link.setTarget("_blank");
          } else {
            link.setTarget("_self");
          }
          {code}
          ActionList and DocumentSearch both use System parameter values to decide if a link should open in a new window or not. While ActionList behaves as expected (System parameter ACTION_LIST_DOCUMENT_POPUP_IND value drives this behavior), document search does not.

          DocumentSearchCriteriaBoLookupableHelperService.generateDocumentHandlerUrl method generates the link url and it uses the following piece of code to decide the target window behavior.

          {code:title=DocumentSearchCriteriaBoLookupableHelperService.java|borderStyle=solid}
          if (isDocumentHandlerPopup()) {
               link.setTarget("_blank");
          }
          {code}

          The target is set only when the system parameter maps to a true value. However, KualiLookup.jsp overrides this behavior with this if/else logic.

          {code:title=KualiLookup.jsp|borderStyle=solid}
          <c:choose>
          <c:when test="${empty column.columnAnchor.target}"><c:set var="anchorTarget" value="_blank" /></c:when>
          <c:otherwise><c:set var="anchorTarget" value="${column.columnAnchor.target}" /></c:otherwise>
          </c:choose>
          {code}

          So, in cases where apps have overridden the DOCUMENT_SEARCH_POPUP_IND parameter to have a false value, DocumentSearchCriteriaBoLookupableHelperService won't set the anchor target and the KualiLookup.jsp will default that to open in a new window.

          Since KualiLookup.jsp is common across all lookups and this maybe the default behavior we want for BO lookups, it would help to replace DocumentSearchCriteriaBoLookupableHelperService code to

          {code}
          if (isDocumentHandlerPopup()) {
            link.setTarget("_blank");
          } else {
            link.setTarget("_self");
          }
          {code}
          Priority Major [ 3 ] Critical [ 2 ]
          Assignee Matt Sargent [ masargen ]
          Component/s Development [ 11244 ]
          Component/s Database [ 11246 ]
          cchandran Chitra Chandran made changes -
          Start Date
          Fix Date 2012-02-20 [ set to sprint end date ]
          cchandran Chitra Chandran made changes -
          Summary Document Search Results opening in a new window regardless of the system parameter (DOCUMENT_SEARCH_POPUP_IND) value Document Search Results open in a new window regardless of the system parameter (DOCUMENT_SEARCH_POPUP_IND) value
          masargen Matt Sargent made changes -
          Fix Version/s 2.0 [ 14190 ]
          Assignee Matt Sargent [ masargen ] Jeremy Hanson [ jjhanso ]
          Rice Lead jjhanso
          masargen Matt Sargent made changes -
          Start Date
          Fix Date 2012-02-20 2012-02-24 [ set to sprint end date ]
          jjhanso Jeremy Hanson made changes -
          Assignee Jeremy Hanson [ jjhanso ] sona sona [ sonam ]
          sonam Sona Sona (Inactive) made changes -
          Status Open [ 1 ] Resolved [ 5 ]
          Resolution Fixed [ 1 ]
          jcoltrin Jessica Coltrin (Inactive) made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          spatterson Shem Patterson (Inactive) made changes -
          Workflow custom [ 130943 ] Copy of custom for rice [ 213739 ]
          spatterson Shem Patterson (Inactive) made changes -
          Workflow Copy of custom for rice [ 213739 ] custom [ 223487 ]
          spatterson Shem Patterson (Inactive) made changes -
          Workflow custom [ 223487 ] Rice Workflow [ 233235 ]

            People

            • Assignee:
              sonam Sona Sona (Inactive)
              Reporter:
              cchandran Chitra Chandran
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: