Uploaded image for project: 'Kuali Rice Development'
  1. Kuali Rice Development
  2. KULRICE-6587

Document Search Results open in a new window regardless of the system parameter (DOCUMENT_SEARCH_POPUP_IND) value

    Details

    • Type: Bug Fix
    • Status: Closed
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.0.0-rc2, 2.0
    • Component/s: Development
    • Security Level: Public (Public: Anyone can view)
    • Labels:
      None
    • Rice Module:
      KNS, KRAD
    • KAI Review Status:
      Not Required
    • KTI Review Status:
      Not Required

      Description

      ActionList and DocumentSearch both use System parameter values to decide if a link should open in a new window or not. While ActionList behaves as expected (System parameter ACTION_LIST_DOCUMENT_POPUP_IND value drives this behavior), document search does not.

      DocumentSearchCriteriaBoLookupableHelperService.generateDocumentHandlerUrl method generates the link url and it uses the following piece of code to decide the target window behavior.

      DocumentSearchCriteriaBoLookupableHelperService.java
      if (isDocumentHandlerPopup()) {
           link.setTarget("_blank");
      }
      

      The target is set only when the system parameter maps to a true value. However, KualiLookup.jsp overrides this behavior with this if/else logic.

      KualiLookup.jsp
      <c:choose>
      <c:when test="${empty column.columnAnchor.target}"><c:set var="anchorTarget" value="_blank" /></c:when>
      <c:otherwise><c:set var="anchorTarget" value="${column.columnAnchor.target}" /></c:otherwise>
      </c:choose>
      

      So, in cases where apps have overridden the DOCUMENT_SEARCH_POPUP_IND parameter to have a false value, DocumentSearchCriteriaBoLookupableHelperService won't set the anchor target and the KualiLookup.jsp will default that to open in a new window.

      Since KualiLookup.jsp is common across all lookups and this maybe the default behavior we want for BO lookups, it would help to replace DocumentSearchCriteriaBoLookupableHelperService code to

      if (isDocumentHandlerPopup()) {
        link.setTarget("_blank");
      } else {
        link.setTarget("_self");
      }
      

        Attachments

          Activity

          No work has yet been logged on this issue.

            People

            • Assignee:
              sonam Sona Sona (Inactive)
              Reporter:
              cchandran Chitra Chandran
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: