Kuali Rice Development
  1. Kuali Rice Development
  2. KULRICE-6661

Client side validation errors not getting removed when value changed with a date picker

    Details

    • Type: Bug Fix Bug Fix
    • Status: Closed Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.2.0-m1, 2.2
    • Component/s: Development
    • Security Level: Public (Public: Anyone can view)
    • Labels:
      None
    • Similar issues:
      KULRICE-7026Alter behavior of client side validation
      KULRICE-11109Server-side Validation Error on valid dates
      KULRICE-8074Getting client side validation errors when no errors are present
      KULRICE-13117Disable Date Picker Control when the field is disabled
      KULRICE-6835Issues with client side validation
      KULRICE-10883Date picker (and other widgets) still work when a field is disabled
      KULRICE-12616Date Picker icon still has color even when disabled
      KULRICE-7315Modify client side validation to treat all the related items of an input field as one
      KULRICE-7312Client-side validation tooltip doesn't open (for timed interval) when other validation treatment is applied
      KULRICE-4708Support for client side field validation
    • Rice Module:
      KRAD
    • KAI Review Status:
      Not Required
    • KTI Review Status:
      Not Required

      Description

      From Bonnie:

      I have two questions about displaying warning messages (see the attached screen)

      1) I have filed out the Start/End Date fields using the date picker, however the warning message won't go away until I manually modify Start/End Date fields.
      2) After clicking on one of the date picker icons, a warning message appears that reads "Holiday Calendar Name - Required". Shouldn't this warning message be suppressed until the user clicks "Save"?

        Issue Links

          Activity

          Hide
          Jerry Neal (Inactive) added a comment -

          Eric,

          Note this should be done on the 2.2 branch.

          thanks,
          Jerry

          Show
          Jerry Neal (Inactive) added a comment - Eric, Note this should be done on the 2.2 branch. thanks, Jerry
          Hide
          Eric Njogu (Inactive) added a comment -

          I cannot get to dev2.ks.kuali.org. Is there an alternative URL where I can view this behaviour?

          Show
          Eric Njogu (Inactive) added a comment - I cannot get to dev2.ks.kuali.org. Is there an alternative URL where I can view this behaviour?
          Hide
          Jerry Neal (Inactive) added a comment -

          Reassigning to Dan since he needs some Jiras

          Show
          Jerry Neal (Inactive) added a comment - Reassigning to Dan since he needs some Jiras
          Hide
          Daniel Seibert (Inactive) added a comment -

          committed fix for item 1. when datpicker onSelect event, trigger onfocusout event for related input.

          Show
          Daniel Seibert (Inactive) added a comment - committed fix for item 1. when datpicker onSelect event, trigger onfocusout event for related input.
          Hide
          Daniel Seibert (Inactive) added a comment -

          For item 2. The behaviour is as expected. In the example, the Academic Calendar Name is a required field. the focus is initially put on this field. when the user focuses out of the name field to the datepicker, client side validation is performed.

          Show
          Daniel Seibert (Inactive) added a comment - For item 2. The behaviour is as expected. In the example, the Academic Calendar Name is a required field. the focus is initially put on this field. when the user focuses out of the name field to the datepicker, client side validation is performed.
          Hide
          William Washington (Inactive) added a comment -

          The validation behavior is still problematic. When fixed, the validation scripting should do a few things (there is no required date picker in the KRAD kitchen sink or a test view, so I'm unable to know what part of this was fixed):

          A. Not trigger validation when the field still has focus. Currently it's running validation after every keystroke.
          B. Not trigger validation while the date picker is shown.
          C. Either put the focus back in the field after populating the field, or move focus to the next field.

          We still have a usability issue that arises in the edge case when someone is using the keyboard to tab to a field with a date picker, in an attempt to get to the date picker (most keyboard users are likely to just key in the date as it's faster than using a date picker & mouse). In this edge case, the input will get and lose focus before the date picker shows up, and trigger the client-side validation. If the date picker is configured to show onfocus and issue A above is fixed, it could provide a potential solution, but having the date picker always show onfocus could be overwhelming/annoying.

          Also, Bonnie's second question #2 (below) doesn't have to do with the date picker…the Holiday Calendar Name field is receiving focus when the page loads, and clicking the date picker removes focus from that field and therefore validation is triggered. (Note that clicking any of the date fields as the first step on the page represent the least-likely scenario, as we expect users would begin filling the form out with the first field on the page.)

          Show
          William Washington (Inactive) added a comment - The validation behavior is still problematic. When fixed, the validation scripting should do a few things (there is no required date picker in the KRAD kitchen sink or a test view, so I'm unable to know what part of this was fixed): A. Not trigger validation when the field still has focus. Currently it's running validation after every keystroke. B. Not trigger validation while the date picker is shown. C. Either put the focus back in the field after populating the field, or move focus to the next field. We still have a usability issue that arises in the edge case when someone is using the keyboard to tab to a field with a date picker, in an attempt to get to the date picker (most keyboard users are likely to just key in the date as it's faster than using a date picker & mouse). In this edge case, the input will get and lose focus before the date picker shows up, and trigger the client-side validation. If the date picker is configured to show onfocus and issue A above is fixed, it could provide a potential solution, but having the date picker always show onfocus could be overwhelming/annoying. Also, Bonnie's second question #2 (below) doesn't have to do with the date picker…the Holiday Calendar Name field is receiving focus when the page loads, and clicking the date picker removes focus from that field and therefore validation is triggered. (Note that clicking any of the date fields as the first step on the page represent the least-likely scenario, as we expect users would begin filling the form out with the first field on the page.)
          Hide
          Brian Smith (Inactive) added a comment -

          A) All fields trigger on lost focus, fields are validated on keystroke only when they are returned to
          B) Date picker needs some changes to limit when validation occurs on fields using it - I will attempt to make these changes in my validation work
          C) I think the focus should return to the field or the icon

          You can turn focusing on the first field of page off by setting the Page property autoFocus to false

          Show
          Brian Smith (Inactive) added a comment - A) All fields trigger on lost focus, fields are validated on keystroke only when they are returned to B) Date picker needs some changes to limit when validation occurs on fields using it - I will attempt to make these changes in my validation work C) I think the focus should return to the field or the icon You can turn focusing on the first field of page off by setting the Page property autoFocus to false
          Hide
          Daniel Seibert (Inactive) added a comment -

          This jira is very similar to KULRICE-6835.

          Fixed issues with datepicker validation.
          Some issues cleared with setting options on datepicker.
          Also fixed a couple of bugs related to DatePatternConstraints.

          Setup options include:

          • datepicker widget options: constrainInput, dateFormat, altField, altFormat affect the text input display and validation.
          • krad constraints
          • whether the inputField is bound to a String or a Date also affects behavior

          Documentation under way to explain the options and provide best practices.
          Additional datepicker examples have been added to the kitchen sink.

          Show
          Daniel Seibert (Inactive) added a comment - This jira is very similar to KULRICE-6835 . Fixed issues with datepicker validation. Some issues cleared with setting options on datepicker. Also fixed a couple of bugs related to DatePatternConstraints. Setup options include: datepicker widget options: constrainInput, dateFormat, altField, altFormat affect the text input display and validation. krad constraints whether the inputField is bound to a String or a Date also affects behavior Documentation under way to explain the options and provide best practices. Additional datepicker examples have been added to the kitchen sink.
          Hide
          Daniel Seibert (Inactive) added a comment -

          This Jira and KULRICE-6835 cover several issues with the datepicker. Most have been resolved.

          Show
          Daniel Seibert (Inactive) added a comment - This Jira and KULRICE-6835 cover several issues with the datepicker. Most have been resolved.

            People

            • Assignee:
              Daniel Seibert (Inactive)
              Reporter:
              Jerry Neal (Inactive)
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Structure Helper Panel