Kuali Rice Development
  1. Kuali Rice Development
  2. KULRICE-6689

Replace string concatenation with StringBuilder.append when rejoining with commas in DocumentSearchServiceImpl.saveSearch

    Details

    • Type: Task Task
    • Status: Closed Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.0.0-rc1, 2.0
    • Fix Version/s: 2.0.0-rc1, 2.0
    • Component/s: Development, Performance
    • Security Level: Public (Public: Anyone can view)
    • Labels:
      None
    • Similar issues:
      KULRICE-7436replace literal strings with constants
      KULRICE-2503Replace instances of DocumentTypeService.getClassByName(String) with DataDictionaryService.getValidDocumentClassByTypeName(String)
      KULRICE-2715Some instances of the string "GO" were replaced with "/" in country and state data
      KULRICE-7563Easy display of List<String> NEW control(s)
      KULRICE-9007RoleMemberBo.groovy prevents replacement of KIM services
      KULRICE-11917Commas are added to search criteria of the Lookup Operators page
      KULRICE-13270When buttons are selected, commas are added to the second field on the Input Addons demo
      KULRICE-5507Bug - long string/gobbledygook not encapsulated properly in code
      KULRICE-10762KRAD Demo Library Collections Auto Sequence adds commas to Input Fields
      KULRICE-5344remove Attributes & AttributeSet class replace with Map<String, String>
    • KAI Review Status:
      Not Required
    • KTI Review Status:
      Not Required

      Description

      Replace string concatenation with StringBuilder.append when rejoining with commas in DocumentSearchServiceImpl.saveSearch
      Replace:

                              String newSearchOrder = "";
                              for (String aNewOrder : newOrder) {
                                  if (!"".equals(newSearchOrder)) {
                                      newSearchOrder += ",";
                                  }
                                  newSearchOrder += aNewOrder;
                              }
      

      with:

              StringBuilder newSearchOrder = new StringBuilder("");
              for (String aNewOrder : newOrder) {
                  if (newSearchOrder.length() != 0) {
                      newSearchOrder.append(",");
                  }
                  newSearchOrder.append(aNewOrder);
              }
      
      

        Activity

        Hide
        Jessica Coltrin (Inactive) added a comment -

        Closing since this item is now in the 2.0 release notes.

        Show
        Jessica Coltrin (Inactive) added a comment - Closing since this item is now in the 2.0 release notes.

          People

          • Assignee:
            Erik Meade
            Reporter:
            Erik Meade
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Structure Helper Panel